Subject: Re: [PATCH v12 06/14] mm: HUGE_VMAP arch support cleanup

From: kernel test robot <[email-masked]>
Date: Wed, 3 Feb 2021 02:21:14 +0800

Hi Nicholas,

I love your patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on arm64/for-next/core v5.11-rc6 next-20210125]
[cannot apply to hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nicholas-Piggin/huge-vmalloc-mappings/20210202-190833
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: x86_64-randconfig-a005-20210202 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 275c6af7d7f1ed63a03d05b4484413e447133269)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/25ffbe7d58a1f780ae44f140143eaaf6ab93061a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Nicholas-Piggin/huge-vmalloc-mappings/20210202-190833
        git checkout 25ffbe7d58a1f780ae44f140143eaaf6ab93061a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email-masked]>

All errors (new ones prefixed by >>):

>> mm/debug_vm_pgtable.c:221:31: error: too few arguments to function call, single argument 'prot' was not specified
           if (!arch_vmap_pmd_supported())
                ~~~~~~~~~~~~~~~~~~~~~~~ ^
   arch/x86/include/asm/vmalloc.h:10:6: note: 'arch_vmap_pmd_supported' declared here
   bool arch_vmap_pmd_supported(pgprot_t prot);
        ^
   mm/debug_vm_pgtable.c:343:31: error: too few arguments to function call, single argument 'prot' was not specified
           if (!arch_vmap_pud_supported())
                ~~~~~~~~~~~~~~~~~~~~~~~ ^
   arch/x86/include/asm/vmalloc.h:9:6: note: 'arch_vmap_pud_supported' declared here
   bool arch_vmap_pud_supported(pgprot_t prot);
        ^
   2 errors generated.

vim +/prot +221 mm/debug_vm_pgtable.c

   215	
   216	#ifdef CONFIG_HAVE_ARCH_HUGE_VMAP
   217	static void __init pmd_huge_tests(pmd_t *pmdp, unsigned long pfn, pgprot_t prot)
   218	{
   219		pmd_t pmd;
   220	
 > 221		if (!arch_vmap_pmd_supported())
   222			return;
   223	
   224		pr_debug("Validating PMD huge\n");
   225		/*
   226		 * X86 defined pmd_set_huge() verifies that the given
   227		 * PMD is not a populated non-leaf entry.
   228		 */
   229		WRITE_ONCE(*pmdp, __pmd(0));
   230		WARN_ON(!pmd_set_huge(pmdp, __pfn_to_phys(pfn), prot));
   231		WARN_ON(!pmd_clear_huge(pmdp));
   232		pmd = READ_ONCE(*pmdp);
   233		WARN_ON(!pmd_none(pmd));
   234	}
   235	#else /* CONFIG_HAVE_ARCH_HUGE_VMAP */
   236	static void __init pmd_huge_tests(pmd_t *pmdp, unsigned long pfn, pgprot_t prot) { }
   237	#endif /* CONFIG_HAVE_ARCH_HUGE_VMAP */
   238	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email-masked]