From: Guenter Roeck <linux@roeck-us•net>
To: Lakshmi Ramasubramanian <nramas@linux•microsoft.com>
Cc: mark.rutland@arm•com, tao.li@vivo•com, zohar@linux•ibm.com,
paulus@samba•org, vincenzo.frascino@arm•com,
frowand.list@gmail•com, sashal@kernel•org, robh@kernel•org,
masahiroy@kernel•org, jmorris@namei•org,
takahiro.akashi@linaro•org, linux-arm-kernel@lists•infradead.org,
catalin.marinas@arm•com, serge@hallyn•com,
devicetree@vger•kernel.org, pasha.tatashin@soleen•com,
will@kernel•org, prsriva@linux•microsoft.com,
hsinyi@chromium•org, allison@lohutok•net,
christophe.leroy@c-s•fr, mbrugger@suse•com,
balajib@linux•microsoft.com, gregkh@linuxfoundation•org,
linux-kernel@vger•kernel.org, james.morse@arm•com,
dmitry.kasatkin@gmail•com, joe@perches•com,
linux-integrity@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
bauerman@linux•ibm.com
Subject: Re: [PATCH v18 03/11] of: Add a common kexec FDT setup function
Date: Sun, 21 Feb 2021 17:32:07 -0800 [thread overview]
Message-ID: <20210222013207.GA142216@roeck-us.net> (raw)
In-Reply-To: <20210213161049.6190-4-nramas@linux.microsoft.com>
On Sat, Feb 13, 2021 at 08:10:41AM -0800, Lakshmi Ramasubramanian wrote:
> From: Rob Herring <robh@kernel•org>
>
> Both arm64 and powerpc do essentially the same FDT /chosen setup for
> kexec. The differences are either omissions that arm64 should have
> or additional properties that will be ignored. The setup code can be
> combined and shared by both powerpc and arm64.
>
> The differences relative to the arm64 version:
> - If /chosen doesn't exist, it will be created (should never happen).
> - Any old dtb and initrd reserved memory will be released.
> - The new initrd and elfcorehdr are marked reserved.
> - "linux,booted-from-kexec" is set.
>
> The differences relative to the powerpc version:
> - "kaslr-seed" and "rng-seed" may be set.
> - "linux,elfcorehdr" is set.
> - Any existing "linux,usable-memory-range" is removed.
>
> Combine the code for setting up the /chosen node in the FDT and updating
> the memory reservation for kexec, for powerpc and arm64, in
> of_kexec_alloc_and_setup_fdt() and move it to "drivers/of/kexec.c".
>
> Signed-off-by: Rob Herring <robh@kernel•org>
> Signed-off-by: Lakshmi Ramasubramanian <nramas@linux•microsoft.com>
s390:allmodconfig:
drivers/of/kexec.c: In function 'of_kexec_alloc_and_setup_fdt':
drivers/of/kexec.c:378:10: error: 'const struct kimage' has no member named 'arch'
378 | image->arch.elf_load_addr,
| ^~
drivers/of/kexec.c:379:10: error: 'const struct kimage' has no member named 'arch'
379 | image->arch.elf_headers_sz);
| ^~
drivers/of/kexec.c:387:35: error: 'const struct kimage' has no member named 'arch'
387 | ret = fdt_add_mem_rsv(fdt, image->arch.elf_load_addr,
| ^~
drivers/of/kexec.c:388:16: error: 'const struct kimage' has no member named 'arch'
388 | image->arch.elf_headers_sz);
| ^~
Guenter
next prev parent reply other threads:[~2021-02-22 1:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 16:10 [PATCH v18 00/10] Carry forward IMA measurement log on kexec on ARM64 Lakshmi Ramasubramanian
2021-02-13 16:10 ` [PATCH v18 01/11] powerpc: Rename kexec elfcorehdr_addr to elf_load_addr Lakshmi Ramasubramanian
2021-02-15 21:31 ` Thiago Jung Bauermann
2021-02-13 16:10 ` [PATCH v18 02/11] arm64: Rename kexec elf_headers_mem " Lakshmi Ramasubramanian
2021-02-15 21:34 ` Thiago Jung Bauermann
2021-02-13 16:10 ` [PATCH v18 03/11] of: Add a common kexec FDT setup function Lakshmi Ramasubramanian
2021-02-15 21:41 ` Thiago Jung Bauermann
2021-02-22 1:32 ` Guenter Roeck [this message]
2021-02-22 1:35 ` Lakshmi Ramasubramanian
2021-02-13 16:10 ` [PATCH v18 04/11] arm64: Use common of_kexec_alloc_and_setup_fdt() Lakshmi Ramasubramanian
2021-02-15 21:46 ` Thiago Jung Bauermann
2021-02-13 16:10 ` [PATCH v18 05/11] powerpc: " Lakshmi Ramasubramanian
2021-02-15 21:50 ` Thiago Jung Bauermann
2021-02-13 16:10 ` [PATCH v18 06/11] powerpc: Move ima buffer fields to struct kimage Lakshmi Ramasubramanian
2021-02-15 21:58 ` Thiago Jung Bauermann
2021-02-13 16:10 ` [PATCH v18 07/11] powerpc: Enable passing IMA log to next kernel on kexec Lakshmi Ramasubramanian
2021-02-13 16:10 ` [PATCH v18 08/11] powerpc: Move arch independent ima kexec functions to drivers/of/kexec.c Lakshmi Ramasubramanian
2021-02-13 16:10 ` [PATCH v18 09/11] kexec: Use fdt_appendprop_addrrange() to add ima buffer to FDT Lakshmi Ramasubramanian
2021-02-13 16:10 ` [PATCH v18 10/11] powerpc: Delete unused function delete_fdt_mem_rsv() Lakshmi Ramasubramanian
2021-02-13 16:10 ` [PATCH v18 11/11] arm64: Enable passing IMA log to next kernel on kexec Lakshmi Ramasubramanian
2021-02-18 1:25 ` [PATCH v18 00/10] Carry forward IMA measurement log on kexec on ARM64 Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222013207.GA142216@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=allison@lohutok$(echo .)net \
--cc=balajib@linux$(echo .)microsoft.com \
--cc=bauerman@linux$(echo .)ibm.com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmitry.kasatkin@gmail$(echo .)com \
--cc=frowand.list@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hsinyi@chromium$(echo .)org \
--cc=james.morse@arm$(echo .)com \
--cc=jmorris@namei$(echo .)org \
--cc=joe@perches$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-integrity@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=masahiroy@kernel$(echo .)org \
--cc=mbrugger@suse$(echo .)com \
--cc=nramas@linux$(echo .)microsoft.com \
--cc=pasha.tatashin@soleen$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=prsriva@linux$(echo .)microsoft.com \
--cc=robh@kernel$(echo .)org \
--cc=sashal@kernel$(echo .)org \
--cc=serge@hallyn$(echo .)com \
--cc=takahiro.akashi@linaro$(echo .)org \
--cc=tao.li@vivo$(echo .)com \
--cc=vincenzo.frascino@arm$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=zohar@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox