Subject: Re: [PATCH v3] powerpc/traps: Enhance readability for trap types

From: Segher Boessenkool <[email-masked]>
Date: Fri, 9 Apr 2021 12:45:06 -0500

On Fri, Apr 09, 2021 at 06:14:19PM +0200, Christophe Leroy wrote:
> >+#define INTERRUPT_SYSTEM_RESET    0x100
> 
> INT_SRESET

SRESET exists on many PowerPC, it means "soft reset".  Not the same
thing at all.

I think "INT" is not a great prefix fwiw, there are many things you can
abbr to "INT".

> >+#define INTERRUPT_DATA_SEGMENT    0x380
> 
> INT_DSEG

exceptions-64s.S calls this "DSLB" (I remember "DSSI" though -- but neither
is a very official name).  It probably is a good idea to look at that
existing code, not make up even more new names :-)

> >+#define INTERRUPT_DOORBELL        0xa00
> 
> INT_DBELL

That saves three characters and makes it very not understandable.

Segher