From: Jisheng Zhang <Jisheng.Zhang@synaptics•com>
To: Christophe Leroy <christophe.leroy@csgroup•eu>
Cc: Anup Patel <anup@brainfault•org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership•com>,
Paul Mackerras <paulus@samba•org>,
linux-hexagon@vger•kernel.org, linux-riscv@lists•infradead.org,
Vincent Chen <deanbo422@gmail•com>,
Anton Ivanov <anton.ivanov@cambridgegreys•com>,
Jonas Bonn <jonas@southpole•se>,
Brian Cain <bcain@codeaurora•org>,
Richard Weinberger <richard@nod•at>, Helge Deller <deller@gmx•de>,
Russell King <linux@armlinux•org.uk>,
Ley Foon Tan <ley.foon.tan@intel•com>,
linux-parisc@vger•kernel.org, linux-snps-arc@lists•infradead.org,
uclinux-h8-devel@lists•sourceforge.jp,
Albert Ou <aou@eecs•berkeley.edu>, Jeff Dike <jdike@addtoit•com>,
linux-um@lists•infradead.org,
Stefan Kristiansson <stefan.kristiansson@saunalahti•fi>,
openrisc@lists•librecores.org, Greentime Hu <green.hu@gmail•com>,
Paul Walmsley <paul.walmsley@sifive•com>,
Stafford Horne <shorne@gmail•com>,
linux-arm-kernel@lists•infradead.org,
Yoshinori Sato <ysato@users•sourceforge.jp>,
Nick Hu <nickhu@andestech•com>,
Vineet Gupta <vgupta@synopsys•com>,
linux-kernel@vger•kernel.org, Palmer Dabbelt <palmer@dabbelt•com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] init: consolidate trap_init()
Date: Wed, 14 Apr 2021 17:38:32 +0800 [thread overview]
Message-ID: <20210414173832.52bc3ddb@xhacker.debian> (raw)
In-Reply-To: <20210414172757.3ebfaa4c@xhacker.debian>
On Wed, 14 Apr 2021 17:27:57 +0800
Jisheng Zhang <Jisheng.Zhang@synaptics•com> wrote:
> CAUTION: Email originated externally, do not click links or open attachments unless you recognize the sender and know the content is safe.
>
>
> On Wed, 14 Apr 2021 11:10:42 +0200
> Christophe Leroy <christophe.leroy@csgroup•eu> wrote:
>
> >
> > Le 14/04/2021 à 10:58, Jisheng Zhang a écrit :
> > > Many architectures implement the trap_init() as NOP, since there is
> > > no such default for trap_init(), this empty stub is duplicated among
> > > these architectures. Provide a generic but weak NOP implementation
> > > to drop the empty stubs of trap_init() in these architectures.
> >
> > You define the weak function in the __init section.
> >
> > Most but not all architectures had it in __init section.
> >
> > And the remaining ones may not be defined in __init section. For instance look at the one in alpha
> > architecture.
> >
> > Have you checked that it is not a problem ? It would be good to say something about it in the commit
> > description.
>
> For those non-nop platforms, I can only test x86/arm64/, but both has
> __init mark. I'm not sure whether this is a problem for alpha etc. Maybe
> I can check which section the trap_init() sits. Or to avoid any possible
> regression, I can add __init mark to those remaining ones without it in
> preparation patches.
>
Hi,
I found only three platforms don't have the __init marker for trap_init(), I
will add the __init marker in three preparation patches in new version.
thanks
next prev parent reply other threads:[~2021-04-14 9:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 8:58 [PATCH] init: consolidate trap_init() Jisheng Zhang
2021-04-14 9:10 ` Christophe Leroy
2021-04-14 9:27 ` Jisheng Zhang
2021-04-14 9:38 ` Jisheng Zhang [this message]
2021-04-14 10:00 ` [PATCH v2] " Jisheng Zhang
2021-08-22 19:48 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414173832.52bc3ddb@xhacker.debian \
--to=jisheng.zhang@synaptics$(echo .)com \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=anton.ivanov@cambridgegreys$(echo .)com \
--cc=anup@brainfault$(echo .)org \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=bcain@codeaurora$(echo .)org \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=deanbo422@gmail$(echo .)com \
--cc=deller@gmx$(echo .)de \
--cc=green.hu@gmail$(echo .)com \
--cc=jdike@addtoit$(echo .)com \
--cc=jonas@southpole$(echo .)se \
--cc=ley.foon.tan@intel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux-um@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nickhu@andestech$(echo .)com \
--cc=openrisc@lists$(echo .)librecores.org \
--cc=palmer@dabbelt$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=richard@nod$(echo .)at \
--cc=shorne@gmail$(echo .)com \
--cc=stefan.kristiansson@saunalahti$(echo .)fi \
--cc=uclinux-h8-devel@lists$(echo .)sourceforge.jp \
--cc=vgupta@synopsys$(echo .)com \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox