Subject: Re: [PATCH] powerpc/64s/radix: Enable huge vmalloc mappings

From: kernel test robot <[email-masked]>
Date: Sun, 2 May 2021 16:03:57 +0800

Hi Nicholas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on powerpc/next]
[also build test WARNING on linus/master next-20210430]
[cannot apply to scottwood/next v5.12]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-64s-radix-Enable-huge-vmalloc-mappings/20210502-125808
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc64-defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1c8b90cff6679d7690891101efc07a1edd98e9a7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Nicholas-Piggin/powerpc-64s-radix-Enable-huge-vmalloc-mappings/20210502-125808
        git checkout 1c8b90cff6679d7690891101efc07a1edd98e9a7
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email-masked]>

All warnings (new ones prefixed by >>):

   fs/proc/kcore.c: In function 'add_modules_range':
>> fs/proc/kcore.c:626:20: warning: self-comparison always evaluates to false [-Wtautological-compare]
     626 |  if (MODULES_VADDR != VMALLOC_START && MODULES_END != VMALLOC_END) {
         |                    ^~
   fs/proc/kcore.c:626:52: warning: self-comparison always evaluates to false [-Wtautological-compare]
     626 |  if (MODULES_VADDR != VMALLOC_START && MODULES_END != VMALLOC_END) {
         |                                                    ^~

vim +626 fs/proc/kcore.c

9492587cf35d37 KAMEZAWA Hiroyuki 2009-09-22  618  
81ac3ad9061dd9 KAMEZAWA Hiroyuki 2009-09-22  619  #if defined(CONFIG_MODULES) && defined(MODULES_VADDR)
81ac3ad9061dd9 KAMEZAWA Hiroyuki 2009-09-22  620  /*
81ac3ad9061dd9 KAMEZAWA Hiroyuki 2009-09-22  621   * MODULES_VADDR has no intersection with VMALLOC_ADDR.
81ac3ad9061dd9 KAMEZAWA Hiroyuki 2009-09-22  622   */
eebf36480678f9 YueHaibing        2019-03-28  623  static struct kcore_list kcore_modules;
81ac3ad9061dd9 KAMEZAWA Hiroyuki 2009-09-22  624  static void __init add_modules_range(void)
81ac3ad9061dd9 KAMEZAWA Hiroyuki 2009-09-22  625  {
bf3e2692468fe4 Baoquan He        2014-10-09 @626  	if (MODULES_VADDR != VMALLOC_START && MODULES_END != VMALLOC_END) {
81ac3ad9061dd9 KAMEZAWA Hiroyuki 2009-09-22  627  		kclist_add(&kcore_modules, (void *)MODULES_VADDR,
81ac3ad9061dd9 KAMEZAWA Hiroyuki 2009-09-22  628  			MODULES_END - MODULES_VADDR, KCORE_VMALLOC);
81ac3ad9061dd9 KAMEZAWA Hiroyuki 2009-09-22  629  	}
bf3e2692468fe4 Baoquan He        2014-10-09  630  }
81ac3ad9061dd9 KAMEZAWA Hiroyuki 2009-09-22  631  #else
81ac3ad9061dd9 KAMEZAWA Hiroyuki 2009-09-22  632  static void __init add_modules_range(void)
81ac3ad9061dd9 KAMEZAWA Hiroyuki 2009-09-22  633  {
81ac3ad9061dd9 KAMEZAWA Hiroyuki 2009-09-22  634  }
81ac3ad9061dd9 KAMEZAWA Hiroyuki 2009-09-22  635  #endif
81ac3ad9061dd9 KAMEZAWA Hiroyuki 2009-09-22  636  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email-masked]