From: Greg Kurz <groug@kaod•org>
To: Christoph Hellwig <hch@lst•de>
Cc: Daniel Vetter <daniel@ffwll•ch>,
kvm@vger•kernel.org, David Airlie <airlied@linux•ie>,
linux-kernel@vger•kernel.org, dri-devel@lists•freedesktop.org,
qemu-devel@nongnu•org,
Alex Williamson <alex.williamson@redhat•com>,
Paul Mackerras <paulus@samba•org>,
Jason Gunthorpe <jgg@nvidia•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
qemu-ppc@nongnu•org, linux-api@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org
Subject: Re: remove the nvlink2 pci_vfio subdriver v2
Date: Tue, 4 May 2021 14:22:36 +0200 [thread overview]
Message-ID: <20210504142236.76994047@bahia.lan> (raw)
In-Reply-To: <20210326061311.1497642-1-hch@lst.de>
On Fri, 26 Mar 2021 07:13:09 +0100
Christoph Hellwig <hch@lst•de> wrote:
> Hi all,
>
> the nvlink2 vfio subdriver is a weird beast. It supports a hardware
> feature without any open source component - what would normally be
> the normal open source userspace that we require for kernel drivers,
> although in this particular case user space could of course be a
> kernel driver in a VM. It also happens to be a complete mess that
> does not properly bind to PCI IDs, is hacked into the vfio_pci driver
> and also pulles in over 1000 lines of code always build into powerpc
> kernels that have Power NV support enabled. Because of all these
> issues and the lack of breaking userspace when it is removed I think
> the best idea is to simply kill.
>
> Changes since v1:
> - document the removed subtypes as reserved
> - add the ACK from Greg
>
> Diffstat:
> arch/powerpc/platforms/powernv/npu-dma.c | 705 ---------------------------
> b/arch/powerpc/include/asm/opal.h | 3
> b/arch/powerpc/include/asm/pci-bridge.h | 1
> b/arch/powerpc/include/asm/pci.h | 7
> b/arch/powerpc/platforms/powernv/Makefile | 2
> b/arch/powerpc/platforms/powernv/opal-call.c | 2
> b/arch/powerpc/platforms/powernv/pci-ioda.c | 185 -------
> b/arch/powerpc/platforms/powernv/pci.c | 11
> b/arch/powerpc/platforms/powernv/pci.h | 17
> b/arch/powerpc/platforms/pseries/pci.c | 23
> b/drivers/vfio/pci/Kconfig | 6
> b/drivers/vfio/pci/Makefile | 1
> b/drivers/vfio/pci/vfio_pci.c | 18
> b/drivers/vfio/pci/vfio_pci_private.h | 14
> b/include/uapi/linux/vfio.h | 38 -
Hi Christoph,
FYI, these uapi changes break build of QEMU.
I guess QEMU people should take some action before this percolates
to the QEMU source tree.
Cc'ing relevant QEMU lists to bring the discussion there.
Cheers,
--
Greg
> drivers/vfio/pci/vfio_pci_nvlink2.c | 490 ------------------
> 16 files changed, 12 insertions(+), 1511 deletions(-)
next prev parent reply other threads:[~2021-05-04 12:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 6:13 remove the nvlink2 pci_vfio subdriver v2 Christoph Hellwig
2021-03-26 6:13 ` [PATCH 1/2] vfio/pci: remove vfio_pci_nvlink2 Christoph Hellwig
2021-04-06 19:38 ` Alex Williamson
2021-04-12 9:41 ` Michael Ellerman
2021-04-12 14:23 ` Alex Williamson
2021-04-22 13:49 ` Michael Ellerman
2021-04-22 13:52 ` Jason Gunthorpe
2021-03-26 6:13 ` [PATCH 2/2] powerpc/powernv: remove the nvlink support Christoph Hellwig
2021-05-04 12:22 ` Greg Kurz [this message]
2021-05-04 12:59 ` remove the nvlink2 pci_vfio subdriver v2 Greg Kroah-Hartman
2021-05-04 13:00 ` Christoph Hellwig
2021-05-04 13:08 ` Cornelia Huck
2021-05-04 13:20 ` Greg Kurz
2021-05-04 13:30 ` Greg Kroah-Hartman
2021-05-04 14:11 ` Greg Kurz
2021-05-04 15:33 ` Alex Williamson
2021-05-04 14:23 ` Daniel Vetter
2021-05-04 15:53 ` Jason Gunthorpe
2021-05-04 16:30 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504142236.76994047@bahia.lan \
--to=groug@kaod$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=alex.williamson@redhat$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hch@lst$(echo .)de \
--cc=jgg@nvidia$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=qemu-devel@nongnu$(echo .)org \
--cc=qemu-ppc@nongnu$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox