From: "Dmitry V. Levin" <ldv@altlinux•org>
To: Nicholas Piggin <npiggin@gmail•com>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 1/2] powerpc/64s/syscall: Use pt_regs.trap to distinguish syscall ABI difference between sc and scv syscalls
Date: Thu, 20 May 2021 14:41:04 +0300 [thread overview]
Message-ID: <20210520114104.GB1198@altlinux.org> (raw)
In-Reply-To: <20210520111931.2597127-1-npiggin@gmail.com>
On Thu, May 20, 2021 at 09:19:30PM +1000, Nicholas Piggin wrote:
> The sc and scv 0 system calls have different ABI conventions, and
> ptracers need to know which system call type is being used if it wants
> to look at the syscall registers.
typo: s/if it wants/if they want/
> Document that pt_regs.trap can be used for this, and fix one in-tree user
> to work with scv 0 syscalls.
>
> Fixes: 7fa95f9adaee ("powerpc/64s: system call support for scv/rfscv instructions")
> Reported-by: "Dmitry V. Levin" <ldv@altlinux•org>
> Suggested-by: "Dmitry V. Levin" <ldv@altlinux•org>
> Signed-off-by: Nicholas Piggin <npiggin@gmail•com>
Also consider adding
Cc: stable@vger•kernel.org # 5.9+
Besides that, looks good, thanks!
--
ldv
next prev parent reply other threads:[~2021-05-20 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 11:19 [PATCH 1/2] powerpc/64s/syscall: Use pt_regs.trap to distinguish syscall ABI difference between sc and scv syscalls Nicholas Piggin
2021-05-20 11:19 ` [PATCH 2/2] powerpc/64s/syscall: Fix ptrace syscall info with " Nicholas Piggin
2021-05-20 11:45 ` Dmitry V. Levin
2021-05-20 11:41 ` Dmitry V. Levin [this message]
2021-05-21 12:44 ` [PATCH 1/2] powerpc/64s/syscall: Use pt_regs.trap to distinguish syscall ABI difference between sc and " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210520114104.GB1198@altlinux.org \
--to=ldv@altlinux$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=npiggin@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox