From: Christoph Hellwig <hch@lst•de>
To: Qian Cai <quic_qiancai@quicinc•com>
Cc: heikki.krogerus@linux•intel.com,
linux-devicetree <devicetree@vger•kernel.org>,
peterz@infradead•org, joonas.lahtinen@linux•intel.com,
dri-devel@lists•freedesktop.org, chris@chris-wilson•co.uk,
grant.likely@arm•com, paulus@samba•org,
Frank Rowand <frowand.list@gmail•com>,
mingo@kernel•org, jxgao@google•com, sstabellini@kernel•org,
Saravana Kannan <saravanak@google•com>,
Joerg Roedel <joro@8bytes•org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel•com>,
Christoph Hellwig <hch@lst•de>,
Bartosz Golaszewski <bgolaszewski@baylibre•com>,
bskeggs@redhat•com, linux-pci@vger•kernel.org,
xen-devel@lists•xenproject.org,
Marek Szyprowski <m.szyprowski@samsung•com>,
Dan Williams <dan.j.williams@intel•com>,
matthew.auld@intel•com, Nicolas Boichat <drinkcat@chromium•org>,
thomas.hellstrom@linux•intel.com,
Jim Quinlan <james.quinlan@broadcom•com>,
Will Deacon <will@kernel•org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>,
intel-gfx@lists•freedesktop.org,
maarten.lankhorst@linux•intel.com,
Robin Murphy <robin.murphy@arm•com>,
jani.nikula@linux•intel.com, Rob Herring <robh+dt@kernel•org>,
rodrigo.vivi@intel•com, bhelgaas@google•com,
Claire Chang <tientzu@chromium•org>,
boris.ostrovsky@oracle•com,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
jgross@suse•com, airlied@linux•ie,
Thierry Reding <treding@nvidia•com>,
Greg KH <gregkh@linuxfoundation•org>,
Randy Dunlap <rdunlap@infradead•org>,
lkml <linux-kernel@vger•kernel.org>,
"list@263•net:IOMMU DRIVERS" <iommu@lists•linux-foundation.org>,
daniel@ffwll•ch, xypron.glpk@gmx•de, thomas.lendacky@amd•com,
linuxppc-dev@lists•ozlabs.org, bauerman@linux•ibm.com
Subject: Re: [PATCH v14 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing
Date: Thu, 24 Jun 2021 07:43:15 +0200 [thread overview]
Message-ID: <20210624054315.GA25381@lst.de> (raw)
In-Reply-To: <19d4c7a2-744d-21e0-289c-a576e1f0e6f3@quicinc.com>
On Wed, Jun 23, 2021 at 02:44:34PM -0400, Qian Cai wrote:
> is_swiotlb_force_bounce at /usr/src/linux-next/./include/linux/swiotlb.h:119
>
> is_swiotlb_force_bounce() was the new function introduced in this patch here.
>
> +static inline bool is_swiotlb_force_bounce(struct device *dev)
> +{
> + return dev->dma_io_tlb_mem->force_bounce;
> +}
To me the crash looks like dev->dma_io_tlb_mem is NULL. Can you
turn this into :
return dev->dma_io_tlb_mem && dev->dma_io_tlb_mem->force_bounce;
for a quick debug check?
next prev parent reply other threads:[~2021-06-24 5:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 3:40 [PATCH v14 00/12] Restricted DMA Claire Chang
2021-06-19 3:40 ` [PATCH v14 01/12] swiotlb: Refactor swiotlb init functions Claire Chang
2021-06-22 21:02 ` Stefano Stabellini
2021-06-19 3:40 ` [PATCH v14 02/12] swiotlb: Refactor swiotlb_create_debugfs Claire Chang
2021-06-19 3:40 ` [PATCH v14 03/12] swiotlb: Set dev->dma_io_tlb_mem to the swiotlb pool used Claire Chang
2021-06-19 3:40 ` [PATCH v14 04/12] swiotlb: Update is_swiotlb_buffer to add a struct device argument Claire Chang
2021-06-19 3:40 ` [PATCH v14 05/12] swiotlb: Update is_swiotlb_active " Claire Chang
2021-06-19 3:40 ` [PATCH v14 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing Claire Chang
2021-06-23 16:39 ` Qian Cai
2021-06-23 18:37 ` Will Deacon
2021-06-23 18:44 ` Qian Cai
2021-06-24 5:43 ` Christoph Hellwig [this message]
2021-06-24 6:05 ` Claire Chang
2021-06-24 11:14 ` Robin Murphy
2021-06-24 11:18 ` Will Deacon
2021-06-24 11:34 ` Robin Murphy
2021-06-24 11:48 ` Will Deacon
2021-06-24 14:10 ` Qian Cai
2021-06-24 15:55 ` Konrad Rzeszutek Wilk
2021-06-24 15:58 ` Claire Chang
2021-06-24 19:20 ` Konrad Rzeszutek Wilk
2021-06-19 3:40 ` [PATCH v14 07/12] swiotlb: Move alloc_size to swiotlb_find_slots Claire Chang
2021-06-19 3:40 ` [PATCH v14 08/12] swiotlb: Refactor swiotlb_tbl_unmap_single Claire Chang
2021-06-19 3:40 ` [PATCH v14 09/12] swiotlb: Add restricted DMA alloc/free support Claire Chang
2021-06-19 3:40 ` [PATCH v14 10/12] swiotlb: Add restricted DMA pool initialization Claire Chang
2021-06-19 3:40 ` [PATCH v14 11/12] dt-bindings: of: Add restricted DMA pool Claire Chang
2021-06-19 3:40 ` [PATCH v14 12/12] of: Add plumbing for " Claire Chang
2021-06-23 8:38 ` [PATCH v14 00/12] Restricted DMA Konrad Rzeszutek Wilk
2021-06-23 9:01 ` Claire Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624054315.GA25381@lst.de \
--to=hch@lst$(echo .)de \
--cc=airlied@linux$(echo .)ie \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=bauerman@linux$(echo .)ibm.com \
--cc=bgolaszewski@baylibre$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=boris.ostrovsky@oracle$(echo .)com \
--cc=bskeggs@redhat$(echo .)com \
--cc=chris@chris-wilson$(echo .)co.uk \
--cc=dan.j.williams@intel$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=drinkcat@chromium$(echo .)org \
--cc=frowand.list@gmail$(echo .)com \
--cc=grant.likely@arm$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=heikki.krogerus@linux$(echo .)intel.com \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=james.quinlan@broadcom$(echo .)com \
--cc=jani.nikula@linux$(echo .)intel.com \
--cc=jgross@suse$(echo .)com \
--cc=joonas.lahtinen@linux$(echo .)intel.com \
--cc=joro@8bytes$(echo .)org \
--cc=jxgao@google$(echo .)com \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=matthew.auld@intel$(echo .)com \
--cc=mingo@kernel$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=quic_qiancai@quicinc$(echo .)com \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=robh+dt@kernel$(echo .)org \
--cc=robin.murphy@arm$(echo .)com \
--cc=rodrigo.vivi@intel$(echo .)com \
--cc=saravanak@google$(echo .)com \
--cc=sstabellini@kernel$(echo .)org \
--cc=thomas.hellstrom@linux$(echo .)intel.com \
--cc=thomas.lendacky@amd$(echo .)com \
--cc=tientzu@chromium$(echo .)org \
--cc=treding@nvidia$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
--cc=xypron.glpk@gmx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox