Subject: Re: [PATCH 3/3] powerpc/smp: Enable CACHE domain for shared processor

From: Gautham R Shenoy <[email-masked]>
Date: Tue, 24 Aug 2021 14:25:57 +0530

Hello Srikar,

On Sat, Aug 21, 2021 at 02:54:19PM +0530, Srikar Dronamraju wrote:
[..snip..]

The patch looks good to me.

Reviewed-by: Gautham R. Shenoy <[email-masked]>

> ---
>  arch/powerpc/kernel/smp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
> index 3d26d3c61e94..47b15f31cc29 100644
> --- a/arch/powerpc/kernel/smp.c
> +++ b/arch/powerpc/kernel/smp.c
> @@ -1365,7 +1365,7 @@ static bool update_mask_by_l2(int cpu, cpumask_var_t *mask)
>  	l2_cache = cpu_to_l2cache(cpu);
>  	if (!l2_cache || !*mask) {
>  		/* Assume only core siblings share cache with this CPU */
> -		for_each_cpu(i, submask_fn(cpu))
> +		for_each_cpu(i, cpu_sibling_mask(cpu))
>  			set_cpus_related(cpu, i, cpu_l2_cache_mask);
> 
>  		return false;
> -- 
> 2.18.2
>