From: Segher Boessenkool <segher@kernel•crashing.org>
To: Ganesh <ganeshgr@linux•ibm.com>
Cc: mikey@neuling•org, linuxppc-dev@lists•ozlabs.org,
mahesh@linux•ibm.com, npiggin@gmail•com
Subject: Re: [PATCH v2 1/3] powerpc/pseries: Parse control memory access error
Date: Wed, 25 Aug 2021 09:47:13 -0500 [thread overview]
Message-ID: <20210825144713.GQ1583@gate.crashing.org> (raw)
In-Reply-To: <92790955-ce8d-1826-2317-c889038545fc@linux.ibm.com>
On Wed, Aug 25, 2021 at 05:06:29PM +0530, Ganesh wrote:
>
> On 8/25/21 2:54 AM, Segher Boessenkool wrote:
> >On Tue, Aug 24, 2021 at 04:39:57PM +1000, Michael Ellerman wrote:
> >>>+ case MC_ERROR_CTRL_MEM_ACCESS_PTABLE_WALK:
> >>>+ mce_err.u.ra_error_type =
> >>>+ MCE_RA_ERROR_PAGE_TABLE_WALK_LOAD_STORE_FOREIGN;
> >>That name is ridiculously long, but I guess that's not your fault :)
> >>We can fix it up in a later patch.
> >It also has surprisingly little information content for the 47 chars
> >length it has :-) What does this even mean?!
>
> It means control memory access error/real address error is detected during
> page
> table walk.
This isn't obvious from the name. The name contains some words your
explanation does not, as well: LOAD, STORE, FOREIGN. Most importantly,
the name is just a jumble of words, with no apparent connection between
them.
I didn't ask for an explanation, sorry if you misunderstood. I was just
exploring the many ways this name is baffling :-)
Segher
next prev parent reply other threads:[~2021-08-25 14:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 9:20 [PATCH v2 1/3] powerpc/pseries: Parse control memory access error Ganesh Goudar
2021-08-05 9:20 ` [PATCH v2 2/3] selftests/powerpc: Add test for real address error handling Ganesh Goudar
2021-08-24 12:48 ` Michael Ellerman
2021-08-25 11:31 ` Ganesh
2021-08-26 3:27 ` Michael Ellerman
2021-08-26 12:57 ` Ganesh
2021-08-05 9:20 ` [PATCH v2 3/3] powerpc/mce: Modify the real address error logging messages Ganesh Goudar
2021-08-23 18:53 ` [PATCH v2 1/3] powerpc/pseries: Parse control memory access error Ganesh
2021-08-24 6:39 ` Michael Ellerman
2021-08-24 21:24 ` Segher Boessenkool
2021-08-25 11:36 ` Ganesh
2021-08-25 14:47 ` Segher Boessenkool [this message]
2021-08-25 11:03 ` Ganesh
2021-08-26 2:36 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825144713.GQ1583@gate.crashing.org \
--to=segher@kernel$(echo .)crashing.org \
--cc=ganeshgr@linux$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mahesh@linux$(echo .)ibm.com \
--cc=mikey@neuling$(echo .)org \
--cc=npiggin@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox