Subject: Re: [PATCH v2 1/2] KVM: PPC: Book3S PR: Disable SCV when AIL could be disabled

From: kernel test robot <[email-masked]>
Date: Wed, 2 Feb 2022 21:09:35 +0800

Hi Nicholas,

I love your patch! Yet something to improve:

[auto build test ERROR on powerpc/topic/ppc-kvm]
[also build test ERROR on powerpc/next v5.17-rc2 next-20220202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nicholas-Piggin/KVM-PPC-Book3S-PR-Fixes-for-AIL-and-SCV/20220129-152655
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git topic/ppc-kvm
config: powerpc-randconfig-r005-20220131 (https://download.01.org/0day-ci/archive/20220202/[email-masked]/config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a751cf4de8f5854152b969afed947b0640ab0c33
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Nicholas-Piggin/KVM-PPC-Book3S-PR-Fixes-for-AIL-and-SCV/20220129-152655
        git checkout a751cf4de8f5854152b969afed947b0640ab0c33
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/kvm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email-masked]>

All errors (new ones prefixed by >>):

   arch/powerpc/kvm/book3s_pr.c: In function 'kvmppc_core_vcpu_load_pr':
>> arch/powerpc/kvm/book3s_pr.c:146:74: error: 'struct thread_struct' has no member named 'fscr'
     146 |                 if (cpu_has_feature(CPU_FTR_ARCH_300) && (current->thread.fscr & FSCR_SCV))
         |                                                                          ^
   arch/powerpc/kvm/book3s_pr.c: In function 'kvmppc_core_vcpu_put_pr':
   arch/powerpc/kvm/book3s_pr.c:184:74: error: 'struct thread_struct' has no member named 'fscr'
     184 |                 if (cpu_has_feature(CPU_FTR_ARCH_300) && (current->thread.fscr & FSCR_SCV))
         |                                                                          ^

vim +146 arch/powerpc/kvm/book3s_pr.c

   141	
   142		/* Disable AIL if supported */
   143		if (cpu_has_feature(CPU_FTR_HVMODE)) {
   144			if (cpu_has_feature(CPU_FTR_ARCH_207S))
   145				mtspr(SPRN_LPCR, mfspr(SPRN_LPCR) & ~LPCR_AIL);
 > 146			if (cpu_has_feature(CPU_FTR_ARCH_300) && (current->thread.fscr & FSCR_SCV))
   147				mtspr(SPRN_FSCR, mfspr(SPRN_FSCR) & ~FSCR_SCV);
   148		}
   149	
   150		vcpu->cpu = smp_processor_id();
   151	#ifdef CONFIG_PPC_BOOK3S_32
   152		current->thread.kvm_shadow_vcpu = vcpu->arch.shadow_vcpu;
   153	#endif
   154	
   155		if (kvmppc_is_split_real(vcpu))
   156			kvmppc_fixup_split_real(vcpu);
   157	
   158		kvmppc_restore_tm_pr(vcpu);
   159	}
   160	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email-masked]