Subject: Re: [PATCH v3 01/12] powerpc: Move and rename func_descr_t

From: Kees Cook <[email-masked]>
Date: Thu, 10 Feb 2022 16:51:59 -0800

On Sun, Oct 17, 2021 at 02:38:14PM +0200, Christophe Leroy wrote:
> There are three architectures with function descriptors, try to
> have common names for the address they contain in order to
> refactor some functions into generic functions later.
> 
> powerpc has 'entry'
> ia64 has 'ip'
> parisc has 'addr'
> 
> Vote for 'addr' and update 'func_descr_t' accordingly.
> 
> Move it in asm/elf.h to have it at the same place on all
> three architectures, remove the typedef which hides its real
> type, and change it to a smoother name 'struct func_desc'.
> 
> Signed-off-by: Christophe Leroy <[email-masked]>

I like the name. :)

Reviewed-by: Kees Cook <[email-masked]>

-- 
Kees Cook