From: Kees Cook <keescook@chromium•org>
To: Linus Torvalds <torvalds@linux-foundation•org>
Cc: "alsa-devel@alsa-project•org" <alsa-devel@alsa-project•org>,
"linux-aspeed@lists•ozlabs.org" <linux-aspeed@lists•ozlabs.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor•com>,
"linux-iio@vger•kernel.org" <linux-iio@vger•kernel.org>,
"nouveau@lists•freedesktop.org" <nouveau@lists•freedesktop.org>,
"Rasmus Villemoes" <linux@rasmusvillemoes•dk>,
dri-devel <dri-devel@lists•freedesktop.org>,
"James Bottomley" <James.Bottomley@hansenpartnership•com>,
"Cristiano Giuffrida" <c.giuffrida@vu•nl>,
"Bos, H.J." <h.j.bos@vu•nl>,
"samba-technical@lists•samba.org"
<samba-technical@lists•samba.org>,
"linux1394-devel@lists•sourceforge.net"
<linux1394-devel@lists•sourceforge.net>,
"drbd-dev@lists•linbit.com" <drbd-dev@lists•linbit.com>,
linux-arch <linux-arch@vger•kernel.org>,
CIFS <linux-cifs@vger•kernel.org>,
"KVM list" <kvm@vger•kernel.org>,
linux-scsi <linux-scsi@vger•kernel.org>,
linux-rdma <linux-rdma@vger•kernel.org>,
"linux-staging@lists•linux.dev" <linux-staging@lists•linux.dev>,
"amd-gfx list" <amd-gfx@lists•freedesktop.org>,
"Jason Gunthorpe" <jgg@ziepe•ca>,
"intel-wired-lan@lists•osuosl.org"
<intel-wired-lan@lists•osuosl.org>,
"kgdb-bugreport@lists•sourceforge.net"
<kgdb-bugreport@lists•sourceforge.net>,
"bcm-kernel-feedback-list@broadcom•com"
<bcm-kernel-feedback-list@broadcom•com>,
"Dan Carpenter" <dan.carpenter@oracle•com>,
"Linux Media Mailing List" <linux-media@vger•kernel.org>,
"Arnd Bergman" <arnd@arndb•de>,
"Linux PM" <linux-pm@vger•kernel.org>,
intel-gfx <intel-gfx@lists•freedesktop.org>,
"Brian Johannesmeyer" <bjohannesmeyer@gmail•com>,
"Nathan Chancellor" <nathan@kernel•org>,
linux-fsdevel <linux-fsdevel@vger•kernel.org>,
"Christophe JAILLET" <christophe.jaillet@wanadoo•fr>,
"Jakob Koschel" <jakobkoschel@gmail•com>,
"v9fs-developer@lists•sourceforge.net"
<v9fs-developer@lists•sourceforge.net>,
linux-tegra <linux-tegra@vger•kernel.org>,
"Thomas Gleixner" <tglx@linutronix•de>,
"Andy Shevchenko" <andriy.shevchenko@linux•intel.com>,
"Linux ARM" <linux-arm-kernel@lists•infradead.org>,
"linux-sgx@vger•kernel.org" <linux-sgx@vger•kernel.org>,
linux-block <linux-block@vger•kernel.org>,
Netdev <netdev@vger•kernel.org>,
"linux-usb@vger•kernel.org" <linux-usb@vger•kernel.org>,
linux-wireless <linux-wireless@vger•kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger•kernel.org>,
"Linux F2FS Dev Mailing List"
<linux-f2fs-devel@lists•sourceforge.net>,
"David Laight" <David.Laight@aculab•com>,
"tipc-discussion@lists•sourceforge.net"
<tipc-discussion@lists•sourceforge.net>,
"Linux Crypto Mailing List" <linux-crypto@vger•kernel.org>,
dma <dmaengine@vger•kernel.org>,
"linux-mediatek@lists•infradead.org"
<linux-mediatek@lists•infradead.org>,
"Andrew Morton" <akpm@linux-foundation•org>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
"Christian König" <christian.koenig@amd•com>,
"Mike Rapoport" <rppt@kernel•org>
Subject: Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr
Date: Wed, 2 Mar 2022 12:59:28 -0800 [thread overview]
Message-ID: <202203021256.69D7C4BCA6@keescook> (raw)
In-Reply-To: <CAHk-=wikKPC0LUqZ8++EC5JOvGdBqVH9uUaTX=DvBioDoReYww@mail.gmail.com>
On Wed, Mar 02, 2022 at 12:18:45PM -0800, Linus Torvalds wrote:
> On Wed, Mar 2, 2022 at 12:07 PM Kees Cook <keescook@chromium•org> wrote:
> >
> > I've long wanted to change kfree() to explicitly set pointers to NULL on
> > free. https://github.com/KSPP/linux/issues/87
>
> We've had this discussion with the gcc people in the past, and gcc
> actually has some support for it, but it's sadly tied to the actual
> function name (ie gcc has some special-casing for "free()")
>
> See
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94527
>
> for some of that discussion.
>
> Oh, and I see some patch actually got merged since I looked there last
> so that you can mark "deallocator" functions, but I think it's only
> for the context matching, not for actually killing accesses to the
> pointer afterwards.
Ah! I missed that getting added in GCC 11. But yes, there it is:
https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-malloc-function-attribute
Hah, now we may need to split __malloc from __alloc_size. ;)
I'd still like the NULL assignment behavior, though, since some things
can easily avoid static analysis.
--
Kees Cook
next prev parent reply other threads:[~2022-03-02 21:00 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 11:08 [PATCH 0/6] Remove usage of list iterator past the loop body Jakob Koschel
2022-02-28 11:08 ` [PATCH 1/6] drivers: usb: remove " Jakob Koschel
2022-02-28 11:24 ` Dan Carpenter
2022-02-28 12:03 ` Jakob Koschel
2022-02-28 13:18 ` Dan Carpenter
2022-02-28 18:20 ` Joe Perches
2022-03-01 5:52 ` Dan Carpenter
2022-02-28 11:08 ` [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr Jakob Koschel
2022-02-28 11:20 ` Greg KH
2022-02-28 12:06 ` Jakob Koschel
2022-03-01 17:37 ` Greg KH
2022-02-28 12:19 ` Christian König
2022-02-28 19:56 ` Linus Torvalds
2022-02-28 20:03 ` Linus Torvalds
2022-02-28 20:10 ` Linus Torvalds
2022-02-28 20:14 ` Linus Torvalds
2022-02-28 20:53 ` Segher Boessenkool
2022-02-28 20:16 ` Matthew Wilcox
2022-02-28 20:27 ` Johannes Berg
2022-02-28 20:41 ` Linus Torvalds
2022-02-28 20:37 ` Linus Torvalds
2022-02-28 23:26 ` Matthew Wilcox
2022-03-01 0:45 ` Linus Torvalds
2022-03-01 0:57 ` Linus Torvalds
2022-03-01 18:14 ` Kees Cook
2022-03-01 18:47 ` Linus Torvalds
2022-03-01 19:01 ` Matthew Wilcox
2022-03-01 3:03 ` David Laight
2022-02-28 21:47 ` Jakob Koschel
2022-03-01 0:41 ` Linus Torvalds
2022-03-01 6:32 ` Jakub Kicinski
2022-03-01 11:28 ` Jakob Koschel
2022-03-01 17:36 ` Greg KH
2022-03-01 17:40 ` Jakob Koschel
2022-03-01 17:58 ` Greg KH
2022-03-01 18:21 ` Kees Cook
2022-03-02 9:31 ` Xiaomeng Tong
2022-03-02 14:04 ` David Laight
2022-03-03 2:27 ` Xiaomeng Tong
2022-03-03 4:58 ` David Laight
2022-03-03 7:26 ` Xiaomeng Tong
2022-03-03 9:30 ` David Laight
2022-03-03 12:37 ` Xiaomeng Tong
2022-03-03 12:18 ` [Kgdb-bugreport] " Daniel Thompson
2022-03-04 6:59 ` Xiaomeng Tong
2022-03-03 7:32 ` Jakob Koschel
2022-03-03 8:30 ` Xiaomeng Tong
2022-03-03 8:38 ` Xiaomeng Tong
2022-02-28 20:07 ` Christian König
2022-02-28 20:42 ` James Bottomley
2022-02-28 20:56 ` Christian König
2022-02-28 21:13 ` James Bottomley
2022-03-01 7:03 ` Christian König
2022-02-28 22:05 ` Jakob Koschel
2022-02-28 21:18 ` Jeffrey Walton
2022-02-28 21:59 ` Mike Rapoport
2022-02-28 22:28 ` James Bottomley
2022-02-28 22:50 ` Barnabás Pőcze
2022-03-01 0:30 ` Segher Boessenkool
2022-03-01 0:54 ` Linus Torvalds
2022-03-01 19:06 ` Linus Torvalds
2022-03-01 19:42 ` Linus Torvalds
2022-03-01 22:58 ` David Laight
2022-03-01 23:03 ` Linus Torvalds
2022-03-01 23:19 ` David Laight
2022-03-01 23:55 ` Linus Torvalds
2022-03-02 9:29 ` Rasmus Villemoes
2022-03-02 20:07 ` Kees Cook
2022-03-02 20:18 ` Linus Torvalds
2022-03-02 20:59 ` Kees Cook [this message]
2022-03-03 8:37 ` Dan Carpenter
2022-03-03 10:56 ` Dan Carpenter
2022-03-01 2:15 ` David Laight
2022-02-28 13:13 ` Dan Carpenter
2022-02-28 11:08 ` [PATCH 3/6] treewide: fix incorrect use to determine if list is empty Jakob Koschel
2022-02-28 11:38 ` Dan Carpenter
2022-02-28 11:08 ` [PATCH 4/6] drivers: remove unnecessary use of list iterator variable Jakob Koschel
2022-02-28 11:08 ` [PATCH 5/6] treewide: remove dereference of list iterator after loop body Jakob Koschel
2022-02-28 11:08 ` [PATCH 6/6] treewide: remove check of list iterator against head past the " Jakob Koschel
2022-02-28 11:22 ` Dominique Martinet
2022-02-28 13:12 ` Dan Carpenter
2022-03-01 20:36 ` Linus Torvalds
2022-03-02 17:14 ` [Intel-gfx] " Tvrtko Ursulin
2022-03-07 15:00 ` [PATCH 0/6] Remove usage of list iterator " Dan Carpenter
2022-03-07 15:26 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202203021256.69D7C4BCA6@keescook \
--to=keescook@chromium$(echo .)org \
--cc=David.Laight@aculab$(echo .)com \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=arnd@arndb$(echo .)de \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=bjohannesmeyer@gmail$(echo .)com \
--cc=c.giuffrida@vu$(echo .)nl \
--cc=christian.koenig@amd$(echo .)com \
--cc=christophe.jaillet@wanadoo$(echo .)fr \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=dmaengine@vger$(echo .)kernel.org \
--cc=drbd-dev@lists$(echo .)linbit.com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=gustavo@embeddedor$(echo .)com \
--cc=h.j.bos@vu$(echo .)nl \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jakobkoschel@gmail$(echo .)com \
--cc=jgg@ziepe$(echo .)ca \
--cc=kgdb-bugreport@lists$(echo .)sourceforge.net \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-aspeed@lists$(echo .)ozlabs.org \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-cifs@vger$(echo .)kernel.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-f2fs-devel@lists$(echo .)sourceforge.net \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux-sgx@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linux1394-devel@lists$(echo .)sourceforge.net \
--cc=linux@rasmusvillemoes$(echo .)dk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nathan@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nouveau@lists$(echo .)freedesktop.org \
--cc=rppt@kernel$(echo .)org \
--cc=samba-technical@lists$(echo .)samba.org \
--cc=tglx@linutronix$(echo .)de \
--cc=tipc-discussion@lists$(echo .)sourceforge.net \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=v9fs-developer@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox