From: "Clément Léger" <clement.leger@bootlin•com>
To: Rob Herring <robh@kernel•org>
Cc: Nathan Lynch <nathanl@linux•ibm.com>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
Ohhoon Kwon <ohoono.kwon@samsung•com>,
David Hildenbrand <david@redhat•com>,
Steen Hegelund <steen.hegelund@microchip•com>,
Daniel Henrique Barboza <danielhb413@gmail•com>,
YueHaibing <yuehaibing@huawei•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
Paul Mackerras <paulus@samba•org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux•ibm.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>,
Allan Nielsen <allan.nielsen@microchip•com>,
Andrew Morton <akpm@linux-foundation•org>,
Laurent Dufour <ldufour@linux•ibm.com>,
Frank Rowand <frowand.list@gmail•com>,
Horatiu Vultur <horatiu.vultur@microchip•com>,
David Gibson <david@gibson•dropbear.id.au>
Subject: Re: [PATCH 1/3] of: dynamic: add of_property_alloc() and of_property_free()
Date: Fri, 6 May 2022 09:43:39 +0200 [thread overview]
Message-ID: <20220506094339.55b8aa63@fixe.home> (raw)
In-Reply-To: <YnQLYjcIc0PjvWYR@robh.at.kernel.org>
Le Thu, 5 May 2022 12:37:38 -0500,
Rob Herring <robh@kernel•org> a écrit :
> > >
> > > - /* mark the property as dynamic */
> > > - of_property_set_flag(new, OF_DYNAMIC);
> > > + prop->value = kzalloc(alloc_len, allocflags);
> > > + if (!prop->value)
> > > + goto out_err;
> > >
> > > - return new;
> > > + if (value)
> > > + memcpy(prop->value, value, value_len);
> >
> > Could you use kmemdup() instead of kzalloc+memcpy ?
>
> I'd prefer there be 1 alloc for struct property and value instead of 2.
> And maybe 'name' gets rolled into it too, but that gets a bit more
> complicated to manage I think.
At least for value it should be easy indeed. i'll check what I can do
for the name.
>
> With memcpy, note this series[1].
Ok, good to know, should I base my series on that one ?
>
> Rob
>
> [1] https://lore.kernel.org/all/20220504014440.3697851-30-keescook@chromium.org/
--
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com
next prev parent reply other threads:[~2022-05-06 7:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 15:40 [PATCH 0/3] of: add of_property_alloc/free() and of_node_alloc/free() Clément Léger
2022-05-04 15:40 ` [PATCH 1/3] of: dynamic: add of_property_alloc() and of_property_free() Clément Léger
2022-05-05 7:30 ` Christophe Leroy
2022-05-05 9:47 ` Clément Léger
2022-05-05 17:37 ` Rob Herring
2022-05-06 7:43 ` Clément Léger [this message]
2022-05-05 19:37 ` Rob Herring
2022-05-06 7:49 ` Clément Léger
2022-06-01 22:30 ` Tyrel Datwyler
2022-06-02 14:06 ` Rob Herring
2022-06-02 18:07 ` Tyrel Datwyler
2022-05-04 15:40 ` [PATCH 2/3] of: dynamic: add of_node_alloc() and of_node_free() Clément Léger
2022-05-05 7:32 ` Christophe Leroy
2022-05-05 19:43 ` Rob Herring
2022-05-06 10:43 ` Clément Léger
2022-05-09 16:55 ` Rob Herring
2022-05-04 15:40 ` [PATCH 3/3] powerpc/pseries: use of_property_*() and of_node_*() functions Clément Léger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220506094339.55b8aa63@fixe.home \
--to=clement.leger@bootlin$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=allan.nielsen@microchip$(echo .)com \
--cc=aneesh.kumar@linux$(echo .)ibm.com \
--cc=danielhb413@gmail$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=david@redhat$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=frowand.list@gmail$(echo .)com \
--cc=horatiu.vultur@microchip$(echo .)com \
--cc=ldufour@linux$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nathanl@linux$(echo .)ibm.com \
--cc=ohoono.kwon@samsung$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=steen.hegelund@microchip$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=yuehaibing@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox