From: Miquel Raynal <miquel.raynal@bootlin•com>
To: Pratyush Yadav <p.yadav@ti•com>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin•com>,
"Lucas Stach" <dev@lynxeye•de>,
"Vignesh Raghavendra" <vigneshr@ti•com>,
linux-aspeed@lists•ozlabs.org,
"Neil Armstrong" <narmstrong@baylibre•com>,
"Stefan Agner" <stefan@agner•ch>,
"Thierry Reding" <thierry.reding@gmail•com>,
linux-mtd@lists•infradead.org,
"Jerome Brunet" <jbrunet@baylibre•com>,
"Jonathan Hunter" <jonathanh@nvidia•com>,
"Joel Stanley" <joel@jms•id.au>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix•de>,
"Kevin Hilman" <khilman@baylibre•com>,
"Tudor Ambarus" <tudor.ambarus@microchip•com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail•com>,
linux-tegra@vger•kernel.org, linux-amlogic@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
"Andrew Jeffery" <andrew@aj•id.au>,
"Nicolas Ferre" <nicolas.ferre@microchip•com>,
"Michael Walle" <michael@walle•cc>,
"Liang Yang" <liang.yang@amlogic•com>,
kernel@pengutronix•de, "Richard Weinberger" <richard@nod•at>,
"Paul Mackerras" <paulus@samba•org>,
linuxppc-dev@lists•ozlabs.or
Subject: Re: [PATCH 00/14] mtd: Fix platform remove callbacks to always return 0
Date: Tue, 7 Jun 2022 12:47:46 +0200 [thread overview]
Message-ID: <20220607124746.20a2eaf0@xps-13> (raw)
In-Reply-To: <20220607093236.67txulke76mi6t75@ti.com>
Hi Pratyush, Uwe,
p.yadav@ti•com wrote on Tue, 7 Jun 2022 15:02:36 +0530:
> Hi Miquel,
>
> On 06/06/22 03:18PM, Miquel Raynal wrote:
> > Hi Folks,
> >
> > u.kleine-koenig@pengutronix•de wrote on Fri, 3 Jun 2022 23:07:44 +0200:
> >
> > > Hello,
> > >
> > > this series prepares to make platform remove callbacks return void.
> > > Therefor first update them to always return 0. The rationale is that the
> > > Linux device model doesn't handle failures on remove and if a remove
> > > callback returns an error, it just emits a quite generic error message
> > > and still removes the device.
> >
> > Tudor, Pratyush, Richard, Vignesh,
> >
> > The series looks good to me (besides the atmel patch), I think it's
> > best to take it directly through mtd/next instead of going through all
> > the different internal branches, please let me know if you disagree
> > with the idea.
>
> Patch 2 does not look good to me. It modifies the aspeed-smc driver in
> drivers/mtd/spi-nor/controllers/ but the driver has been moved to
> drivers/spi/ in Mark's next branch [0]. The patch would likely conflict
> with that.
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit?id=9c63b846e6df43e5b3d31263f7db545f32deeda3
Right, I believe Uwe is sending per-subsystems series so now that he is
aware we can safely drop patch 2.
Thanks,
Miquèl
prev parent reply other threads:[~2022-06-07 10:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 21:07 [PATCH 00/14] mtd: Fix platform remove callbacks to always return 0 Uwe Kleine-König
2022-06-03 21:07 ` [PATCH 03/14] mtd: powernv_flash: Warn about failure to unregister mtd device Uwe Kleine-König
2022-06-09 13:09 ` Miquel Raynal
2022-06-06 13:18 ` [PATCH 00/14] mtd: Fix platform remove callbacks to always return 0 Miquel Raynal
2022-06-07 9:32 ` Pratyush Yadav
2022-06-07 10:47 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607124746.20a2eaf0@xps-13 \
--to=miquel.raynal@bootlin$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrew@aj$(echo .)id.au \
--cc=dev@lynxeye$(echo .)de \
--cc=jbrunet@baylibre$(echo .)com \
--cc=joel@jms$(echo .)id.au \
--cc=jonathanh@nvidia$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=khilman@baylibre$(echo .)com \
--cc=liang.yang@amlogic$(echo .)com \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-aspeed@lists$(echo .)ozlabs.org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.or \
--cc=martin.blumenstingl@googlemail$(echo .)com \
--cc=michael@walle$(echo .)cc \
--cc=narmstrong@baylibre$(echo .)com \
--cc=nicolas.ferre@microchip$(echo .)com \
--cc=p.yadav@ti$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=richard@nod$(echo .)at \
--cc=stefan@agner$(echo .)ch \
--cc=thierry.reding@gmail$(echo .)com \
--cc=tudor.ambarus@microchip$(echo .)com \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=vigneshr@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox