From: Rob Herring <robh@kernel•org>
To: Vaibhav Jain <vaibhav@linux•ibm.com>
Cc: devicetree@vger•kernel.org, Frank Rowand <frowand.list@gmail•com>,
Ritesh Harjani <ritesh.list@gmail•com>,
linux-kernel@vger•kernel.org,
Prakhar Srivastava <prsriva@linux•microsoft.com>,
Lakshmi Ramasubramanian <nramas@linux•microsoft.com>,
"Eric W. Biederman" <ebiederm@xmission•com>,
Thiago Jung Bauermann <bauerman@linux•vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation•org>,
Mimi Zohar <zohar@linux•vnet.ibm.com>,
linuxppc-dev@lists•ozlabs.org,
Thiago Jung Bauermann <bauerman@linux•ibm.com>,
Robin Murphy <robin.murphy@arm•com>
Subject: Re: [PATCH v3] of: check previous kernel's ima-kexec-buffer against memory bounds
Date: Tue, 7 Jun 2022 13:07:41 -0600 [thread overview]
Message-ID: <20220607190741.GA3644258-robh@kernel.org> (raw)
In-Reply-To: <20220531041446.3334259-1-vaibhav@linux.ibm.com>
On Tue, 31 May 2022 09:44:46 +0530, Vaibhav Jain wrote:
> Presently ima_get_kexec_buffer() doesn't check if the previous kernel's
> ima-kexec-buffer lies outside the addressable memory range. This can result
> in a kernel panic if the new kernel is booted with 'mem=X' arg and the
> ima-kexec-buffer was allocated beyond that range by the previous kernel.
> The panic is usually of the form below:
>
> $ sudo kexec --initrd initrd vmlinux --append='mem=16G'
>
> <snip>
> BUG: Unable to handle kernel data access on read at 0xc000c01fff7f0000
> Faulting instruction address: 0xc000000000837974
> Oops: Kernel access of bad area, sig: 11 [#1]
> <snip>
> NIP [c000000000837974] ima_restore_measurement_list+0x94/0x6c0
> LR [c00000000083b55c] ima_load_kexec_buffer+0xac/0x160
> Call Trace:
> [c00000000371fa80] [c00000000083b55c] ima_load_kexec_buffer+0xac/0x160
> [c00000000371fb00] [c0000000020512c4] ima_init+0x80/0x108
> [c00000000371fb70] [c0000000020514dc] init_ima+0x4c/0x120
> [c00000000371fbf0] [c000000000012240] do_one_initcall+0x60/0x2c0
> [c00000000371fcc0] [c000000002004ad0] kernel_init_freeable+0x344/0x3ec
> [c00000000371fda0] [c0000000000128a4] kernel_init+0x34/0x1b0
> [c00000000371fe10] [c00000000000ce64] ret_from_kernel_thread+0x5c/0x64
> Instruction dump:
> f92100b8 f92100c0 90e10090 910100a0 4182050c 282a0017 3bc00000 40810330
> 7c0802a6 fb610198 7c9b2378 f80101d0 <a1240000> 2c090001 40820614 e9240010
> ---[ end trace 0000000000000000 ]---
>
> Fix this issue by checking returned PFN range of previous kernel's
> ima-kexec-buffer with page_is_ram() to ensure correct memory bounds.
>
> Fixes: 467d27824920 ("powerpc: ima: get the kexec buffer passed by the previous kernel")
> Cc: Frank Rowand <frowand.list@gmail•com>
> Cc: Prakhar Srivastava <prsriva@linux•microsoft.com>
> Cc: Lakshmi Ramasubramanian <nramas@linux•microsoft.com>
> Cc: Thiago Jung Bauermann <bauerman@linux•ibm.com>
> Cc: Rob Herring <robh@kernel•org>
> Cc: Ritesh Harjani <ritesh.list@gmail•com>
> Cc: Robin Murphy <robin.murphy@arm•com>
> Signed-off-by: Vaibhav Jain <vaibhav@linux•ibm.com>
> ---
> Changelog
> ==========
> v3:
> * change the type for {start,end}_pfn to unsigned long [ Ritesh ]
> * Switched to page_is_ram() from pfn_vaild() [ Rob ]
>
> v2:
> * Instead of using memblock to determine the valid bounds use pfn_valid() to do
> so since memblock may not be available late after the kernel init. [ Mpe ]
> * Changed the patch prefix from 'powerpc' to 'of' [ Mpe ]
> * Updated the 'Fixes' tag to point to correct commit that introduced this
> function. [ Rob ]
> * Fixed some whitespace/tab issues in the patch description [ Rob ]
> * Added another check for checking ig 'tmp_size' for ima-kexec-buffer is > 0
> ---
> drivers/of/kexec.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
Applied, thanks!
prev parent reply other threads:[~2022-06-07 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 4:14 [PATCH v3] of: check previous kernel's ima-kexec-buffer against memory bounds Vaibhav Jain
2022-06-07 19:07 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607190741.GA3644258-robh@kernel.org \
--to=robh@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bauerman@linux$(echo .)ibm.com \
--cc=bauerman@linux$(echo .)vnet.ibm.com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=ebiederm@xmission$(echo .)com \
--cc=frowand.list@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nramas@linux$(echo .)microsoft.com \
--cc=prsriva@linux$(echo .)microsoft.com \
--cc=ritesh.list@gmail$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=vaibhav@linux$(echo .)ibm.com \
--cc=zohar@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox