From: Jesper Nilsson <Jesper.Nilsson@axis•com>
To: Serge Semin <Sergey.Semin@baikalelectronics•ru>
Cc: "Krzysztof Wilczyński" <kw@linux•com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin•com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext•com>,
"Neil Armstrong" <narmstrong@baylibre•com>,
"linux-pci@vger•kernel.org" <linux-pci@vger•kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel•org>,
"Binghui Wang" <wangbinghui@hisilicon•com>,
"Frank Li" <Frank.Li@nxp•com>,
"Bjorn Andersson" <bjorn.andersson@linaro•org>,
"Minghuan Lian" <minghuan.Lian@nxp•com>,
"Thierry Reding" <thierry.reding@gmail•com>,
"Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics•ru>,
"Alim Akhtar" <alim.akhtar@samsung•com>,
"Jonathan Chocron" <jonnyc@amazon•com>,
"Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba•co.jp>,
"Jonathan Hunter" <jonathanh@nvidia•com>,
"Fabio Estevam" <festevam@gmail•com>,
"Jerome Brunet" <jbrunet@baylibre•com>,
"Rob Herring" <robh@kernel•org>,
"Jesper Nilsson" <Jesper.Nilsson@axis•com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm•com>,
"Kevin Hilman" <khilman@baylibre•com>,
"Pratyush Anand" <pratyush.anand@gmail•com>,
"linux-tegra@vger•kernel.org" <linux-tegra@vger•kernel.org>,
linux-arm-kernel <linux-arm-kernel@axis•com>,
"Kishon Vijay Abraham I" <kishon@ti•com>,
"linux-rockchip@lists•infradead.org"
<linux-rockchip@lists•infradead.org>,
"Rahul Tanwar" <rtanwar@maxlinear•com>,
"Andy Gross" <agross@kernel•org>,
"NXP Linux Team" <linux-imx@nxp•com>,
"Xiaowei Song" <songxiaowei@hisilicon•com>,
"Greentime Hu" <greentime.hu@sifive•com>,
"Richard Zhu" <hongxing.zhu@nxp•com>,
"linux-omap@vger•kernel.org" <linux-omap@vger•kernel.org>,
"Srikanth Thokala" <srikanth.thokala@intel•com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail•com>,
"linux-arm-msm@vger•kernel.org" <linux-arm-msm@vger•kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix•de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro•org>,
"Yue Wang" <yue.wang@Amlogic•com>,
"linux-samsung-soc@vger•kernel.org"
<linux-samsung-soc@vger•kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive•com>,
"Bjorn Helgaas" <bhelgaas@google•com>,
"linux-amlogic@lists•infradead.org"
<linux-amlogic@lists•infradead.org>,
"Alexey Malahov" <Alexey.Malahov@baikalelectronics•ru>,
"Mingkai Hu" <mingkai.hu@nxp•com>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"Roy Zang" <roy.zang@nxp•com>,
"Jingoo Han" <jingoohan1@gmail•com>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"Heiko Stuebner" <heiko@sntech•de>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"Serge Semin" <fancer.lancer@gmail•com>,
"Stanimir Varbanov" <svarbanov@mm-sol•com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro•org>,
"Masami Hiramatsu" <mhiramat@kernel•org>,
"Pengutronix Kernel Team" <kernel@pengutronix•de>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys•com>,
"Shawn Guo" <shawnguo@kernel•org>,
"Lucas Stach" <l.stach@pengutronix•de>
Subject: Re: [PATCH RESEND v5 15/18] PCI: dwc: Add dw_ prefix to the pcie_port structure name
Date: Mon, 27 Jun 2022 13:47:33 +0200 [thread overview]
Message-ID: <20220627114733.GG13332@axis.com> (raw)
In-Reply-To: <20220624143428.8334-16-Sergey.Semin@baikalelectronics.ru>
On Fri, Jun 24, 2022 at 04:34:25PM +0200, Serge Semin wrote:
> All of the DW PCIe core driver entities have names with the dw_ prefix in
> order to easily distinguish local and common PCIe name spaces. All except
> the pcie_port structure which contains the DW PCIe Root Port descriptor.
> For historical reason the structure has retained the original name since
> commit 340cba6092c2 ("pci: Add PCIe driver for Samsung Exynos") when
> the DW PCIe IP-core support was added to the kernel. Let's finally fix
> that by adding the dw_ prefix to the structure name and by adding the _rp
> suffix to be similar to the EP counterpart. Thus the name will be coherent
> with the common driver naming policy. It shall make the driver code more
> readable eliminating visual confusion between the local and generic PCI
> name spaces.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics•ru>
> Reviewed-by: Rob Herring <robh@kernel•org>
Sorry, I never replied in the thread for the last patch,
your reasoning for not changing the parameter name made sense.
For the ARTPEC-6 parts,
Acked-by: Jesper Nilsson <jesper.nilsson@axis•com>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis•com
next prev parent reply other threads:[~2022-06-28 0:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220624143428.8334-1-Sergey.Semin@baikalelectronics.ru>
2022-06-24 14:34 ` [PATCH RESEND v5 13/18] PCI: dwc: Add start_link/stop_link inliners Serge Semin
2022-06-28 6:43 ` Manivannan Sadhasivam
2022-06-24 14:34 ` [PATCH RESEND v5 15/18] PCI: dwc: Add dw_ prefix to the pcie_port structure name Serge Semin
2022-06-27 11:47 ` Jesper Nilsson [this message]
2022-06-27 12:16 ` Neil Armstrong
2022-06-28 6:46 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627114733.GG13332@axis.com \
--to=jesper.nilsson@axis$(echo .)com \
--cc=Alexey.Malahov@baikalelectronics$(echo .)ru \
--cc=Frank.Li@nxp$(echo .)com \
--cc=Pavel.Parkhomenko@baikalelectronics$(echo .)ru \
--cc=Sergey.Semin@baikalelectronics$(echo .)ru \
--cc=agross@kernel$(echo .)org \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=fancer.lancer@gmail$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=greentime.hu@sifive$(echo .)com \
--cc=gustavo.pimentel@synopsys$(echo .)com \
--cc=hayashi.kunihiko@socionext$(echo .)com \
--cc=heiko@sntech$(echo .)de \
--cc=hongxing.zhu@nxp$(echo .)com \
--cc=jbrunet@baylibre$(echo .)com \
--cc=jingoohan1@gmail$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=jonnyc@amazon$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=khilman@baylibre$(echo .)com \
--cc=kishon@ti$(echo .)com \
--cc=krzysztof.kozlowski@linaro$(echo .)org \
--cc=kw@linux$(echo .)com \
--cc=l.stach@pengutronix$(echo .)de \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@axis$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=lpieralisi@kernel$(echo .)org \
--cc=manivannan.sadhasivam@linaro$(echo .)org \
--cc=martin.blumenstingl@googlemail$(echo .)com \
--cc=mhiramat@kernel$(echo .)org \
--cc=minghuan.Lian@nxp$(echo .)com \
--cc=mingkai.hu@nxp$(echo .)com \
--cc=narmstrong@baylibre$(echo .)com \
--cc=nobuhiro1.iwamatsu@toshiba$(echo .)co.jp \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=pratyush.anand@gmail$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=roy.zang@nxp$(echo .)com \
--cc=rtanwar@maxlinear$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=songxiaowei@hisilicon$(echo .)com \
--cc=srikanth.thokala@intel$(echo .)com \
--cc=svarbanov@mm-sol$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=wangbinghui@hisilicon$(echo .)com \
--cc=yue.wang@Amlogic$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox