From: Frederic Weisbecker <frederic@kernel•org>
To: Peter Zijlstra <peterz@infradead•org>
Cc: juri.lelli@redhat•com,
"Rafael J. Wysocki" <rafael.j.wysocki@intel•com>,
rafael@kernel•org, catalin.marinas@arm•com,
linus.walleij@linaro•org, bsegall@google•com, guoren@kernel•org,
pavel@ucw•cz, agordeev@linux•ibm.com, srivatsa@csail•mit.edu,
linux-arch@vger•kernel.org, vincent.guittot@linaro•org,
chenhuacai@kernel•org, linux-acpi@vger•kernel.org,
agross@kernel•org, geert@linux-m68k•org, linux-imx@nxp•com,
vgupta@kernel•org, mattst88@gmail•com, borntraeger@linux•ibm.com,
mturquette@baylibre•com, sammy@sammy•net, pmladek@suse•com,
linux-pm@vger•kernel.org, Sascha Hauer <s.hauer@pengutronix•de>,
linux-um@lists•infradead.org, npiggin@gmail•com,
tglx@linutronix•de, linux-omap@vger•kernel.org,
dietmar.eggemann@arm•com, andreyknvl@gmail•com,
gregkh@linuxfoundation•org, linux-kernel@vger•kernel.org,
linux-perf-users@vger•kernel.org, senozhatsky@chromium•org,
svens@linux•ibm.com, jolsa@kernel•org, tj@kernel•org,
Andrew Morton <akpm@linux-foundation•org>,
mark.rutland@arm•com, linux-ia64 @vger.kernel.org,
dave.hansen@linux•intel.com,
virtualization@lists•linux-foundation.org,
James.Bottomley@hansenpartnership•com, jcmvbkbc@gmail•com,
thierry.reding@gmail•com, kernel@xen0n•name, cl@linux•com,
linux-s390@vger•kernel.org, vschneid@redhat•com,
john.ogness@linutronix•de, ysato@users•sourceforge.jp,
linux-sh@vger•kernel.org, festevam@gmail•com, deller@gmx•de,
daniel.lezcano@linaro•org, jonathanh@nvidia•com,
dennis@kernel•org, lenb@kernel•org,
linux-xtensa@linux-xtensa•org, kernel@pengutronix•de,
gor@linux•ibm.com, linux-arm-msm@vger•kernel.org,
linux-alpha@vger•kernel.org, linux-m68k@lists•linux-m68k.org,
loongarch@lists•linux.dev, shorne@gmail•com, chris@zankel•net,
sboyd@kernel•org, dinguyen@kernel•org, bristot@redhat•com,
alexander.shishkin@linux•intel.com, fweisbec@gmail•com,
lpieralisi@kernel•org, atishp@atishpatra•org,
linux@rasmusvillemoes•dk, kasan-dev@googlegroups•com,
will@kernel•org, boris.ostrovsky@oracle•com, khilman@kernel•org,
linux-csky@vger•kernel.org, pv -drivers@vmware•com,
linux-snps-arc@lists•infradead.org, mgorman@suse•de,
jacob.jun.pan@linux•intel.com, Arnd Bergmann <arnd@arndb•de>,
ulli.kroll@googlemail•com, linux-clk@vger•kernel.org,
rostedt@goodmis•org, ink@jurassic•park.msu.ru, bcain@quicinc•com,
tsbogend@alpha•franken.de, linux-parisc@vger•kernel.org,
ryabinin.a.a@gmail•com, sudeep.holla@arm•com,
shawnguo@kernel•org, davem@davemloft•net, dalias@libc•org,
tony@atomide•com, amakhalov@vmware•com,
konrad.dybcio@somainline•org, bjorn.andersson@linaro•org,
glider@google•com, hpa@zytor•com, sparclinux@vger•kernel.org,
linux-hexagon@vger•kernel.org, linux-riscv@lists•infradead.org,
vincenzo.frascino@arm•com, anton.ivanov@cambridgegreys•com,
jonas@southpole•se, yury.norov@gmail•com, richard@nod•at,
x86@kernel•org, linux@armlinux•org.uk, mingo@redhat•com,
aou@eecs•berkeley.edu, hca@linux•ibm.com,
richard.henderson@linaro•org, stefan.kristiansson@saunalahti•fi,
openrisc@lists•librecores.org, acme@kernel•org,
paul.walmsley@sifive•com, linux-tegra@vger•kernel.org,
namhyung@kernel•org, andriy.shevchenko@linux•intel.com,
jpoimboe@kernel•org, dvyukov@google•com, jgross@suse•com,
monstr@monstr•eu, linux-mips@vger•kernel.org, palmer@dabbelt•com,
anup@brainfault•org, bp@alien8•de, johannes@sipsolutions•net,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2 03/44] cpuidle/poll: Ensure IRQ state is invariant
Date: Tue, 20 Sep 2022 12:43:25 +0200 [thread overview]
Message-ID: <20220920104325.GA72346@lothringen> (raw)
In-Reply-To: <YymAXPkZkyFIEjXM@hirez.programming.kicks-ass.net>
On Tue, Sep 20, 2022 at 10:57:00AM +0200, Peter Zijlstra wrote:
> On Mon, Sep 19, 2022 at 03:19:27PM +0200, Frederic Weisbecker wrote:
> > On Mon, Sep 19, 2022 at 11:59:42AM +0200, Peter Zijlstra wrote:
> > > cpuidle_state::enter() methods should be IRQ invariant
> >
> > Got a bit confused with the invariant thing since the first chunck I
> > see in this patch is a conversion to an non-traceable local_irq_enable().
> >
> > Maybe just add a short mention about that and why?
>
> Changelog now reads:
>
> ---
> Subject: cpuidle/poll: Ensure IRQ state is invariant
> From: Peter Zijlstra <peterz@infradead•org>
> Date: Tue May 31 15:43:32 CEST 2022
>
> cpuidle_state::enter() methods should be IRQ invariant.
>
> Additionally make sure to use raw_local_irq_*() methods since this
> cpuidle callback will be called with RCU already disabled.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead•org>
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel•com>
Reviewed-by: Frederic Weisbecker <frederic@kernel•org>
Thanks!
next prev parent reply other threads:[~2022-09-20 11:28 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 9:59 [PATCH v2 00/44] cpuidle,rcu: Clean up the mess Peter Zijlstra
2022-09-19 9:59 ` [PATCH v2 01/44] x86/perf/amd: Remove tracing from perf_lopwr_cb() Peter Zijlstra
2022-09-19 9:59 ` [PATCH v2 02/44] x86/idle: Replace x86_idle with a static_call Peter Zijlstra
2022-09-19 9:59 ` [PATCH v2 03/44] cpuidle/poll: Ensure IRQ state is invariant Peter Zijlstra
2022-09-19 13:19 ` Frederic Weisbecker
2022-09-20 8:57 ` Peter Zijlstra
2022-09-20 10:43 ` Frederic Weisbecker [this message]
2022-09-19 9:59 ` [PATCH v2 04/44] cpuidle: Move IRQ state validation Peter Zijlstra
2022-09-19 9:59 ` [PATCH v2 05/44] cpuidle,riscv: Push RCU-idle into driver Peter Zijlstra
2022-09-19 11:54 ` Anup Patel
2022-09-19 13:46 ` Frederic Weisbecker
2022-09-19 9:59 ` [PATCH v2 06/44] cpuidle,tegra: " Peter Zijlstra
2022-09-19 14:05 ` Frederic Weisbecker
2022-09-19 9:59 ` [PATCH v2 07/44] cpuidle,psci: " Peter Zijlstra
2022-09-19 14:11 ` Frederic Weisbecker
2022-09-21 21:51 ` Kajetan Puchalski
2022-09-22 0:45 ` Guo Ren
2022-09-19 9:59 ` [PATCH v2 08/44] cpuidle,imx6: " Peter Zijlstra
2022-09-19 14:21 ` Frederic Weisbecker
2022-09-19 15:00 ` Peter Zijlstra
2022-09-20 8:58 ` Peter Zijlstra
2022-09-20 9:01 ` Frederic Weisbecker
2022-09-19 14:49 ` Frederic Weisbecker
2022-09-19 15:01 ` Peter Zijlstra
2022-09-19 15:03 ` Peter Zijlstra
2022-09-19 15:17 ` Frederic Weisbecker
2022-09-19 9:59 ` [PATCH v2 09/44] cpuidle,omap3: " Peter Zijlstra
2022-09-19 14:31 ` Frederic Weisbecker
2022-09-19 15:19 ` Peter Zijlstra
2022-09-20 8:39 ` Frederic Weisbecker
2022-09-19 14:43 ` Frederic Weisbecker
2022-09-19 9:59 ` [PATCH v2 10/44] cpuidle,armada: " Peter Zijlstra
2022-09-19 14:39 ` Frederic Weisbecker
2022-09-19 9:59 ` [PATCH v2 11/44] cpuidle,omap4: " Peter Zijlstra
2022-09-20 10:53 ` Frederic Weisbecker
2022-09-19 9:59 ` [PATCH v2 12/44] cpuidle,dt: " Peter Zijlstra
2022-10-04 11:03 ` Ulf Hansson
2022-10-04 11:43 ` Ulf Hansson
2022-11-16 15:29 ` Peter Zijlstra
2022-11-22 16:04 ` Ulf Hansson
2022-09-19 9:59 ` [PATCH v2 13/44] cpuidle: Fix ct_idle_*() usage Peter Zijlstra
2022-09-19 9:59 ` [PATCH v2 14/44] cpuidle,cpu_pm: Remove RCU fiddling from cpu_pm_{enter,exit}() Peter Zijlstra
2022-10-04 11:04 ` Ulf Hansson
2022-09-19 9:59 ` [PATCH v2 15/44] acpi_idle: Remove tracing Peter Zijlstra
2022-09-19 9:59 ` [PATCH v2 16/44] cpuidle: Annotate poll_idle() Peter Zijlstra
2022-09-19 9:59 ` [PATCH v2 17/44] objtool/idle: Validate __cpuidle code as noinstr Peter Zijlstra
2022-09-19 9:59 ` [PATCH v2 18/44] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE *again* Peter Zijlstra
2022-09-19 9:59 ` [PATCH v2 19/44] cpuidle,intel_idle: Fix CPUIDLE_FLAG_INIT_XSTATE Peter Zijlstra
2022-09-19 9:59 ` [PATCH v2 20/44] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IBRS Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 21/44] arch/idle: Change arch_cpu_idle() IRQ behaviour Peter Zijlstra
2022-09-20 5:08 ` Guo Ren
2022-09-19 10:00 ` [PATCH v2 22/44] x86/tdx: Remove TDX_HCALL_ISSUE_STI Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 23/44] arm,smp: Remove trace_.*_rcuidle() usage Peter Zijlstra
2022-10-04 11:08 ` Ulf Hansson
2022-09-19 10:00 ` [PATCH v2 24/44] arm64,smp: " Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 25/44] printk: " Peter Zijlstra
2022-09-20 2:49 ` Sergey Senozhatsky
2022-09-19 10:00 ` [PATCH v2 26/44] time/tick-broadcast: Remove RCU_NONIDLE usage Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 27/44] cpuidle,sched: Remove annotations from TIF_{POLLING_NRFLAG,NEED_RESCHED} Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 28/44] cpuidle,mwait: Make noinstr clean Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 29/44] cpuidle,tdx: Make tdx " Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 30/44] cpuidle,xenpv: Make more PARAVIRT_XXL " Peter Zijlstra
2022-09-19 10:45 ` Juergen Gross
2022-09-19 10:00 ` [PATCH v2 31/44] cpuidle,nospec: Make " Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 32/44] cpuidle,acpi: " Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 33/44] ftrace: WARN on rcuidle Peter Zijlstra
2022-09-26 18:41 ` Steven Rostedt
2022-10-04 17:19 ` Mark Rutland
2022-09-19 10:00 ` [PATCH v2 34/44] cpuidle,omap3: Use WFI for omap3_pm_idle() Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 35/44] cpuidle,omap3: Push RCU-idle into omap_sram_idle() Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 36/44] cpuidle,omap4: Push RCU-idle into omap4_enter_lowpower() Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 37/44] arm,omap2: Use WFI for omap2_pm_idle() Peter Zijlstra
2022-09-27 6:21 ` Tony Lindgren
2022-09-19 10:00 ` [PATCH v2 38/44] cpuidle,powerdomain: Remove trace_.*_rcuidle() Peter Zijlstra
2022-10-04 11:12 ` Ulf Hansson
2022-09-19 10:00 ` [PATCH v2 39/44] cpuidle,clk: " Peter Zijlstra
2022-09-28 18:01 ` Stephen Boyd
2022-10-04 11:09 ` Ulf Hansson
2022-09-19 10:00 ` [PATCH v2 40/44] ubsan: Fix objtool UACCESS warns Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 41/44] intel_idle: Add force_irq_on module param Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 42/44] entry,kasan,x86: Disallow overriding mem*() functions Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 43/44] sched: Always inline __this_cpu_preempt_check() Peter Zijlstra
2022-09-19 10:00 ` [PATCH v2 44/44] arm64,riscv,perf: Remove RCU_NONIDLE() usage Peter Zijlstra
2022-09-19 15:21 ` [PATCH v2 00/44] cpuidle,rcu: Clean up the mess Rafael J. Wysocki
2022-09-20 12:31 ` Frederic Weisbecker
2022-09-20 14:04 ` Peter Zijlstra
2022-09-27 6:31 ` Tony Lindgren
2022-10-04 15:15 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920104325.GA72346@lothringen \
--to=frederic@kernel$(echo .)org \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=agross@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=andreyknvl@gmail$(echo .)com \
--cc=atishp@atishpatra$(echo .)org \
--cc=boris.ostrovsky@oracle$(echo .)com \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=bristot@redhat$(echo .)com \
--cc=bsegall@google$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=chris@zankel$(echo .)net \
--cc=cl@linux$(echo .)com \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=deller@gmx$(echo .)de \
--cc=dennis@kernel$(echo .)org \
--cc=dietmar.eggemann@arm$(echo .)com \
--cc=dinguyen@kernel$(echo .)org \
--cc=festevam@gmail$(echo .)com \
--cc=fweisbec@gmail$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=gor@linux$(echo .)ibm.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=guoren@kernel$(echo .)org \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=john.ogness@linutronix$(echo .)de \
--cc=jolsa@kernel$(echo .)org \
--cc=jonathanh@nvidia$(echo .)com \
--cc=juri.lelli@redhat$(echo .)com \
--cc=kasan-dev@googlegroups$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=kernel@xen0n$(echo .)name \
--cc=khilman@kernel$(echo .)org \
--cc=lenb@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-csky@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-um@lists$(echo .)infradead.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linux@rasmusvillemoes$(echo .)dk \
--cc=loongarch@lists$(echo .)linux.dev \
--cc=lpieralisi@kernel$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mattst88@gmail$(echo .)com \
--cc=mturquette@baylibre$(echo .)com \
--cc=npiggin@gmail$(echo .)com \
--cc=pavel@ucw$(echo .)cz \
--cc=peterz@infradead$(echo .)org \
--cc=pmladek@suse$(echo .)com \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=sammy@sammy$(echo .)net \
--cc=sboyd@kernel$(echo .)org \
--cc=senozhatsky@chromium$(echo .)org \
--cc=shorne@gmail$(echo .)com \
--cc=srivatsa@csail$(echo .)mit.edu \
--cc=svens@linux$(echo .)ibm.com \
--cc=tglx@linutronix$(echo .)de \
--cc=thierry.reding@gmail$(echo .)com \
--cc=tj@kernel$(echo .)org \
--cc=vgupta@kernel$(echo .)org \
--cc=vincent.guittot@linaro$(echo .)org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=vschneid@redhat$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox