From: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
To: "Mickaël Salaün" <mic@digikod•net>,
"Andy Shevchenko" <andriy.shevchenko@linux•intel.com>,
"Mika Westerberg" <mika.westerberg@linux•intel.com>,
"Krzysztof Wilczyński" <kw@linux•com>,
"Michael Ellerman" <mpe@ellerman•id.au>,
"Randy Dunlap" <rdunlap@infradead•org>,
"Arnd Bergmann" <arnd@arndb•de>,
"Niklas Schnelle" <schnelle@linux•ibm.com>,
"Bjorn Helgaas" <helgaas@kernel•org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel•com>,
"Pali Rohár" <pali@kernel•org>,
"Maciej W. Rozycki" <macro@orcam•me.uk>,
"Juergen Gross" <jgross@suse•com>,
"Dominik Brodowski" <linux@dominikbrodowski•net>,
linux-kernel@vger•kernel.org, linux-alpha@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, linux-mips@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, linux-sh@vger•kernel.org,
sparclinux@vger•kernel.org, linux-pci@vger•kernel.org,
xen-devel@lists•xenproject.org, linux-acpi@vger•kernel.org
Cc: Andrew Lunn <andrew@lunn•ch>,
Thomas Bogendoerfer <tsbogend@alpha•franken.de>,
Stefano Stabellini <sstabellini@kernel•org>,
Yoshinori Sato <ysato@users•sourceforge.jp>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam•com>,
Gregory Clement <gregory.clement@bootlin•com>,
Richard Henderson <richard.henderson@linaro•org>,
Russell King <linux@armlinux•org.uk>,
Nicholas Piggin <npiggin@gmail•com>,
Bjorn Helgaas <bhelgaas@google•com>,
Rich Felker <dalias@libc•org>,
Ivan Kokshaysky <ink@jurassic•park.msu.ru>,
John Paul Adrian Glaubitz <glaubitz@physik•fu-berlin.de>,
Miguel Ojeda <ojeda@kernel•org>, Matt Turner <mattst88@gmail•com>,
Anatolij Gustschin <agust@denx•de>,
"David S. Miller" <davem@davemloft•net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>
Subject: [PATCH v7 5/6] pcmcia: Convert to use less arguments in pci_bus_for_each_resource()
Date: Thu, 23 Mar 2023 19:36:09 +0200 [thread overview]
Message-ID: <20230323173610.60442-6-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20230323173610.60442-1-andriy.shevchenko@linux.intel.com>
The pci_bus_for_each_resource() can hide the iterator loop since
it may be not used otherwise. With this, we may drop that iterator
variable definition.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
Reviewed-by: Krzysztof Wilczyński <kw@linux•com>
Acked-by: Dominik Brodowski <linux@dominikbrodowski•net>
---
drivers/pcmcia/rsrc_nonstatic.c | 9 +++------
drivers/pcmcia/yenta_socket.c | 3 +--
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c
index ad1141fddb4c..96264ebee46a 100644
--- a/drivers/pcmcia/rsrc_nonstatic.c
+++ b/drivers/pcmcia/rsrc_nonstatic.c
@@ -934,7 +934,7 @@ static int adjust_io(struct pcmcia_socket *s, unsigned int action, unsigned long
static int nonstatic_autoadd_resources(struct pcmcia_socket *s)
{
struct resource *res;
- int i, done = 0;
+ int done = 0;
if (!s->cb_dev || !s->cb_dev->bus)
return -ENODEV;
@@ -960,12 +960,9 @@ static int nonstatic_autoadd_resources(struct pcmcia_socket *s)
*/
if (s->cb_dev->bus->number == 0)
return -EINVAL;
-
- for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) {
- res = s->cb_dev->bus->resource[i];
-#else
- pci_bus_for_each_resource(s->cb_dev->bus, res, i) {
#endif
+
+ pci_bus_for_each_resource(s->cb_dev->bus, res) {
if (!res)
continue;
diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c
index 1365eaa20ff4..fd18ab571ce8 100644
--- a/drivers/pcmcia/yenta_socket.c
+++ b/drivers/pcmcia/yenta_socket.c
@@ -673,9 +673,8 @@ static int yenta_search_res(struct yenta_socket *socket, struct resource *res,
u32 min)
{
struct resource *root;
- int i;
- pci_bus_for_each_resource(socket->dev->bus, root, i) {
+ pci_bus_for_each_resource(socket->dev->bus, root) {
if (!root)
continue;
--
2.40.0.1.gaa8946217a0b
next prev parent reply other threads:[~2023-03-23 17:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 17:36 [PATCH v7 0/6] Add pci_dev_for_each_resource() helper and update users Andy Shevchenko
2023-03-23 17:36 ` [PATCH v7 1/6] kernel.h: Split out COUNT_ARGS() and CONCATENATE() Andy Shevchenko
2023-03-23 17:36 ` [PATCH v7 2/6] PCI: Introduce pci_dev_for_each_resource() Andy Shevchenko
2023-03-23 17:36 ` [PATCH v7 3/6] PCI: Allow pci_bus_for_each_resource() to take less arguments Andy Shevchenko
2023-03-24 9:00 ` Philippe Mathieu-Daudé
2023-03-30 13:24 ` kernel test robot
2023-03-30 15:38 ` Andy Shevchenko
2023-03-23 17:36 ` [PATCH v7 4/6] EISA: Convert to use less arguments in pci_bus_for_each_resource() Andy Shevchenko
2023-03-24 9:02 ` Philippe Mathieu-Daudé
2023-03-24 9:19 ` Andy Shevchenko
2023-03-23 17:36 ` Andy Shevchenko [this message]
2023-03-23 17:36 ` [PATCH v7 6/6] PCI: Make use of pci_resource_n() Andy Shevchenko
2023-03-24 9:08 ` Philippe Mathieu-Daudé
2023-03-24 9:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230323173610.60442-6-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux$(echo .)intel.com \
--cc=agust@denx$(echo .)de \
--cc=andrew@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=bhelgaas@google$(echo .)com \
--cc=dalias@libc$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=glaubitz@physik$(echo .)fu-berlin.de \
--cc=gregory.clement@bootlin$(echo .)com \
--cc=helgaas@kernel$(echo .)org \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=jgross@suse$(echo .)com \
--cc=kw@linux$(echo .)com \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linux@dominikbrodowski$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=macro@orcam$(echo .)me.uk \
--cc=mattst88@gmail$(echo .)com \
--cc=mic@digikod$(echo .)net \
--cc=mika.westerberg@linux$(echo .)intel.com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
--cc=ojeda@kernel$(echo .)org \
--cc=oleksandr_tyshchenko@epam$(echo .)com \
--cc=pali@kernel$(echo .)org \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=richard.henderson@linaro$(echo .)org \
--cc=schnelle@linux$(echo .)ibm.com \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=sstabellini@kernel$(echo .)org \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=xen-devel@lists$(echo .)xenproject.org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox