From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: stable@vger•kernel.org
Cc: Sasha Levin <sashal@kernel•org>, Ian Rogers <irogers@google•com>,
Athira Rajeev <atrajeev@linux•vnet.ibm.com>,
Arnaldo Carvalho de Melo <acme@redhat•com>,
John Garry <john.g.garry@oracle•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Hagen Paul Pfeifer <hagen@jauu•net>,
patches@lists•linux.dev, Disha Goel <disgoel@linux•vnet.ibm.com>,
Ravi Bangoria <ravi.bangoria@amd•com>,
Madhavan Srinivasan <maddy@linux•ibm.com>,
Jiri Olsa <jolsa@kernel•org>, Kajol Jain <kjain@linux•ibm.com>,
Petar Gligoric <petar.gligoric@rohde-schwarz•com>,
Namhyung Kim <namhyung@kernel•org>,
Aditya Gupta <adityag@linux•ibm.com>,
linuxppc-dev@lists•ozlabs.org
Subject: [PATCH 6.3 375/431] perf tests task_analyzer: Fix bad substitution ${$1}
Date: Sun, 9 Jul 2023 13:15:23 +0200 [thread overview]
Message-ID: <20230709111459.954441484@linuxfoundation.org> (raw)
In-Reply-To: <20230709111451.101012554@linuxfoundation.org>
From: Aditya Gupta <adityag@linux•ibm.com>
[ Upstream commit 5c4396efb53ef07d046a2e9456b240880e0c3076 ]
${$1} gives bad substitution error on sh, bash, and zsh. This seems like
a typo, and this patch modifies it to $1, since that is what it's usage
looks like from wherever `check_exec_0` is called.
This issue due to ${$1} caused all function calls to give error in
`find_str_or_fail` line, and so no test runs completely. But
'perf test "perf script task-analyzer tests"' wrongly reports
that tests passed with the status OK, which is wrong considering
the tests didn't even run completely
Fixes: e8478b84d6ba9ccf ("perf test: add new task-analyzer tests")
Signed-off-by: Aditya Gupta <adityag@linux•ibm.com>
Signed-off-by: Athira Rajeev <atrajeev@linux•vnet.ibm.com>
Signed-off-by: Kajol Jain <kjain@linux•ibm.com>
Cc: Disha Goel <disgoel@linux•vnet.ibm.com>
Cc: Hagen Paul Pfeifer <hagen@jauu•net>
Cc: Ian Rogers <irogers@google•com>
Cc: Jiri Olsa <jolsa@kernel•org>
Cc: John Garry <john.g.garry@oracle•com>
Cc: Madhavan Srinivasan <maddy@linux•ibm.com>
Cc: Namhyung Kim <namhyung@kernel•org>
Cc: Petar Gligoric <petar.gligoric@rohde-schwarz•com>
Cc: Ravi Bangoria <ravi.bangoria@amd•com>
Cc: linuxppc-dev@lists•ozlabs.org
Link: https://lore.kernel.org/r/20230613164145.50488-16-atrajeev@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat•com>
Signed-off-by: Sasha Levin <sashal@kernel•org>
---
tools/perf/tests/shell/test_task_analyzer.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/shell/test_task_analyzer.sh b/tools/perf/tests/shell/test_task_analyzer.sh
index a98e4ab66040e..6b3343234a6b2 100755
--- a/tools/perf/tests/shell/test_task_analyzer.sh
+++ b/tools/perf/tests/shell/test_task_analyzer.sh
@@ -31,7 +31,7 @@ report() {
check_exec_0() {
if [ $? != 0 ]; then
- report 1 "invokation of ${$1} command failed"
+ report 1 "invocation of $1 command failed"
fi
}
--
2.39.2
next prev parent reply other threads:[~2023-07-09 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230709111451.101012554@linuxfoundation.org>
2023-07-09 11:13 ` [PATCH 6.3 257/431] soc/fsl/qe: fix usb.c build errors Greg Kroah-Hartman
2023-07-09 11:15 ` Greg Kroah-Hartman [this message]
2023-07-09 11:15 ` [PATCH 6.3 376/431] perf tests task_analyzer: Skip tests if no libtraceevent support Greg Kroah-Hartman
2023-07-09 11:15 ` [PATCH 6.3 400/431] crypto: nx - fix build warnings when DEBUG_FS is not enabled Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230709111459.954441484@linuxfoundation.org \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=acme@redhat$(echo .)com \
--cc=adityag@linux$(echo .)ibm.com \
--cc=atrajeev@linux$(echo .)vnet.ibm.com \
--cc=disgoel@linux$(echo .)vnet.ibm.com \
--cc=hagen@jauu$(echo .)net \
--cc=irogers@google$(echo .)com \
--cc=john.g.garry@oracle$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kjain@linux$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=namhyung@kernel$(echo .)org \
--cc=patches@lists$(echo .)linux.dev \
--cc=petar.gligoric@rohde-schwarz$(echo .)com \
--cc=ravi.bangoria@amd$(echo .)com \
--cc=sashal@kernel$(echo .)org \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox