* [PATCH 6.3 257/431] soc/fsl/qe: fix usb.c build errors
[not found] <20230709111451.101012554@linuxfoundation.org>
@ 2023-07-09 11:13 ` Greg Kroah-Hartman
2023-07-09 11:15 ` [PATCH 6.3 375/431] perf tests task_analyzer: Fix bad substitution ${$1} Greg Kroah-Hartman
` (2 subsequent siblings)
3 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2023-07-09 11:13 UTC (permalink / raw)
To: stable
Cc: Sasha Levin, Kumar Gala, kernel test robot, Nicolas Schier,
Masahiro Yamada, Randy Dunlap, patches, Leo Li,
Greg Kroah-Hartman, Qiang Zhao, linuxppc-dev, linux-arm-kernel,
Nicolas Schier
From: Randy Dunlap <rdunlap@infradead•org>
[ Upstream commit 7b1a78babd0d2cd27aa07255dee0c2d7ac0f31e3 ]
Fix build errors in soc/fsl/qe/usb.c when QUICC_ENGINE is not set.
This happens when PPC_EP88XC is set, which selects CPM1 & CPM.
When CPM is set, USB_FSL_QE can be set without QUICC_ENGINE
being set. When USB_FSL_QE is set, QE_USB deafults to y, which
causes build errors when QUICC_ENGINE is not set. Making
QE_USB depend on QUICC_ENGINE prevents QE_USB from defaulting to y.
Fixes these build errors:
drivers/soc/fsl/qe/usb.o: in function `qe_usb_clock_set':
usb.c:(.text+0x1e): undefined reference to `qe_immr'
powerpc-linux-ld: usb.c:(.text+0x2a): undefined reference to `qe_immr'
powerpc-linux-ld: usb.c:(.text+0xbc): undefined reference to `qe_setbrg'
powerpc-linux-ld: usb.c:(.text+0xca): undefined reference to `cmxgcr_lock'
powerpc-linux-ld: usb.c:(.text+0xce): undefined reference to `cmxgcr_lock'
Fixes: 5e41486c408e ("powerpc/QE: add support for QE USB clocks routing")
Signed-off-by: Randy Dunlap <rdunlap@infradead•org>
Reported-by: kernel test robot <lkp@intel•com>
Link: https://lore.kernel.org/all/202301101500.pillNv6R-lkp@intel.com/
Suggested-by: Michael Ellerman <mpe@ellerman•id.au>
Cc: Christophe Leroy <christophe.leroy@csgroup•eu>
Cc: Leo Li <leoyang.li@nxp•com>
Cc: Masahiro Yamada <masahiroy@kernel•org>
Cc: Nicolas Schier <nicolas@fjasle•eu>
Cc: Qiang Zhao <qiang.zhao@nxp•com>
Cc: linuxppc-dev <linuxppc-dev@lists•ozlabs.org>
Cc: linux-arm-kernel@lists•infradead.org
Cc: Kumar Gala <galak@kernel•crashing.org>
Acked-by: Nicolas Schier <nicolas@jasle•eu>
Signed-off-by: Li Yang <leoyang.li@nxp•com>
Signed-off-by: Sasha Levin <sashal@kernel•org>
---
drivers/soc/fsl/qe/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig
index 357c5800b112f..7afa796dbbb89 100644
--- a/drivers/soc/fsl/qe/Kconfig
+++ b/drivers/soc/fsl/qe/Kconfig
@@ -39,6 +39,7 @@ config QE_TDM
config QE_USB
bool
+ depends on QUICC_ENGINE
default y if USB_FSL_QE
help
QE USB Controller support
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 6.3 375/431] perf tests task_analyzer: Fix bad substitution ${$1}
[not found] <20230709111451.101012554@linuxfoundation.org>
2023-07-09 11:13 ` [PATCH 6.3 257/431] soc/fsl/qe: fix usb.c build errors Greg Kroah-Hartman
@ 2023-07-09 11:15 ` Greg Kroah-Hartman
2023-07-09 11:15 ` [PATCH 6.3 376/431] perf tests task_analyzer: Skip tests if no libtraceevent support Greg Kroah-Hartman
2023-07-09 11:15 ` [PATCH 6.3 400/431] crypto: nx - fix build warnings when DEBUG_FS is not enabled Greg Kroah-Hartman
3 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2023-07-09 11:15 UTC (permalink / raw)
To: stable
Cc: Sasha Levin, Ian Rogers, Athira Rajeev, Arnaldo Carvalho de Melo,
John Garry, Greg Kroah-Hartman, Hagen Paul Pfeifer, patches,
Disha Goel, Ravi Bangoria, Madhavan Srinivasan, Jiri Olsa,
Kajol Jain, Petar Gligoric, Namhyung Kim, Aditya Gupta,
linuxppc-dev
From: Aditya Gupta <adityag@linux•ibm.com>
[ Upstream commit 5c4396efb53ef07d046a2e9456b240880e0c3076 ]
${$1} gives bad substitution error on sh, bash, and zsh. This seems like
a typo, and this patch modifies it to $1, since that is what it's usage
looks like from wherever `check_exec_0` is called.
This issue due to ${$1} caused all function calls to give error in
`find_str_or_fail` line, and so no test runs completely. But
'perf test "perf script task-analyzer tests"' wrongly reports
that tests passed with the status OK, which is wrong considering
the tests didn't even run completely
Fixes: e8478b84d6ba9ccf ("perf test: add new task-analyzer tests")
Signed-off-by: Aditya Gupta <adityag@linux•ibm.com>
Signed-off-by: Athira Rajeev <atrajeev@linux•vnet.ibm.com>
Signed-off-by: Kajol Jain <kjain@linux•ibm.com>
Cc: Disha Goel <disgoel@linux•vnet.ibm.com>
Cc: Hagen Paul Pfeifer <hagen@jauu•net>
Cc: Ian Rogers <irogers@google•com>
Cc: Jiri Olsa <jolsa@kernel•org>
Cc: John Garry <john.g.garry@oracle•com>
Cc: Madhavan Srinivasan <maddy@linux•ibm.com>
Cc: Namhyung Kim <namhyung@kernel•org>
Cc: Petar Gligoric <petar.gligoric@rohde-schwarz•com>
Cc: Ravi Bangoria <ravi.bangoria@amd•com>
Cc: linuxppc-dev@lists•ozlabs.org
Link: https://lore.kernel.org/r/20230613164145.50488-16-atrajeev@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat•com>
Signed-off-by: Sasha Levin <sashal@kernel•org>
---
tools/perf/tests/shell/test_task_analyzer.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/shell/test_task_analyzer.sh b/tools/perf/tests/shell/test_task_analyzer.sh
index a98e4ab66040e..6b3343234a6b2 100755
--- a/tools/perf/tests/shell/test_task_analyzer.sh
+++ b/tools/perf/tests/shell/test_task_analyzer.sh
@@ -31,7 +31,7 @@ report() {
check_exec_0() {
if [ $? != 0 ]; then
- report 1 "invokation of ${$1} command failed"
+ report 1 "invocation of $1 command failed"
fi
}
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 6.3 376/431] perf tests task_analyzer: Skip tests if no libtraceevent support
[not found] <20230709111451.101012554@linuxfoundation.org>
2023-07-09 11:13 ` [PATCH 6.3 257/431] soc/fsl/qe: fix usb.c build errors Greg Kroah-Hartman
2023-07-09 11:15 ` [PATCH 6.3 375/431] perf tests task_analyzer: Fix bad substitution ${$1} Greg Kroah-Hartman
@ 2023-07-09 11:15 ` Greg Kroah-Hartman
2023-07-09 11:15 ` [PATCH 6.3 400/431] crypto: nx - fix build warnings when DEBUG_FS is not enabled Greg Kroah-Hartman
3 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2023-07-09 11:15 UTC (permalink / raw)
To: stable
Cc: Sasha Levin, Ian Rogers, Athira Rajeev, Disha Goel, John Garry,
Greg Kroah-Hartman, Ravi Bangoria, patches,
Arnaldo Carvalho de Melo, Madhavan Srinivasan, Jiri Olsa,
Kajol Jain, Petar Gligoric, Namhyung Kim, Aditya Gupta,
linuxppc-dev
From: Aditya Gupta <adityag@linux•ibm.com>
[ Upstream commit c3ac3b0779770acd3ad7eecb5099ab4419ef2e2e ]
Test "perf script task-analyzer tests" fails in environment with missing
libtraceevent support, as perf record fails to create the perf.data
file, which further tests depend on.
Instead, when perf is not compiled with libtraceevent support, skip
those tests instead of failing them, by checking the output of `perf
record --dry-run` to see if it prints the error "libtraceevent is
necessary for tracepoint support"
For the following output, perf compiled with: `make NO_LIBTRACEEVENT=1`
Before the patch:
108: perf script task-analyzer tests :
test child forked, pid 24105
failed to open perf.data: No such file or directory (try 'perf record' first)
FAIL: "invokation of perf script report task-analyzer command failed" Error message: ""
FAIL: "test_basic" Error message: "Failed to find required string:'Comm'."
failed to open perf.data: No such file or directory (try 'perf record' first)
FAIL: "invokation of perf script report task-analyzer --ns --rename-comms-by-tids 0:random command failed" Error message: ""
FAIL: "test_ns_rename" Error message: "Failed to find required string:'Comm'."
failed to open perf.data: No such file or directory (try 'perf record' first)
<...>
perf script task-analyzer tests: FAILED!
With this patch, the script instead returns 2 signifying SKIP, and after
the patch:
108: perf script task-analyzer tests :
test child forked, pid 26010
libtraceevent is necessary for tracepoint support
WARN: Skipping tests. No libtraceevent support
test child finished with -2
perf script task-analyzer tests: Skip
Fixes: e8478b84d6ba9ccf ("perf test: Add new task-analyzer tests")
Signed-off-by: Aditya Gupta <adityag@linux•ibm.com>
Cc: Disha Goel <disgoel@linux•vnet.ibm.com>
Cc: Ian Rogers <irogers@google•com>
Cc: Jiri Olsa <jolsa@kernel•org>
Cc: John Garry <john.g.garry@oracle•com>
Cc: Madhavan Srinivasan <maddy@linux•ibm.com>
Cc: Namhyung Kim <namhyung@kernel•org>
Cc: Petar Gligoric <petar.gligoric@rohde-schwarz•com>
Cc: Ravi Bangoria <ravi.bangoria@amd•com>
Cc: linuxppc-dev@lists•ozlabs.org
Link: https://lore.kernel.org/r/20230613164145.50488-18-atrajeev@linux.vnet.ibm.com
Signed-off-by: Athira Rajeev <atrajeev@linux•vnet.ibm.com>
Signed-off-by: Kajol Jain <kjain@linux•ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat•com>
Signed-off-by: Sasha Levin <sashal@kernel•org>
---
tools/perf/tests/shell/test_task_analyzer.sh | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/tools/perf/tests/shell/test_task_analyzer.sh b/tools/perf/tests/shell/test_task_analyzer.sh
index 6b3343234a6b2..1b7f3c1ec218b 100755
--- a/tools/perf/tests/shell/test_task_analyzer.sh
+++ b/tools/perf/tests/shell/test_task_analyzer.sh
@@ -44,9 +44,20 @@ find_str_or_fail() {
fi
}
+# check if perf is compiled with libtraceevent support
+skip_no_probe_record_support() {
+ perf record -e "sched:sched_switch" -a -- sleep 1 2>&1 | grep "libtraceevent is necessary for tracepoint support" && return 2
+ return 0
+}
+
prepare_perf_data() {
# 1s should be sufficient to catch at least some switches
perf record -e sched:sched_switch -a -- sleep 1 > /dev/null 2>&1
+ # check if perf data file got created in above step.
+ if [ ! -e "perf.data" ]; then
+ printf "FAIL: perf record failed to create \"perf.data\" \n"
+ return 1
+ fi
}
# check standard inkvokation with no arguments
@@ -134,6 +145,13 @@ test_csvsummary_extended() {
find_str_or_fail "Out-Out;" csvsummary ${FUNCNAME[0]}
}
+skip_no_probe_record_support
+err=$?
+if [ $err -ne 0 ]; then
+ echo "WARN: Skipping tests. No libtraceevent support"
+ cleanup
+ exit $err
+fi
prepare_perf_data
test_basic
test_ns_rename
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 6.3 400/431] crypto: nx - fix build warnings when DEBUG_FS is not enabled
[not found] <20230709111451.101012554@linuxfoundation.org>
` (2 preceding siblings ...)
2023-07-09 11:15 ` [PATCH 6.3 376/431] perf tests task_analyzer: Skip tests if no libtraceevent support Greg Kroah-Hartman
@ 2023-07-09 11:15 ` Greg Kroah-Hartman
3 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2023-07-09 11:15 UTC (permalink / raw)
To: stable
Cc: Sasha Levin, Nayna Jain, Herbert Xu, Greg Kroah-Hartman,
Randy Dunlap, patches, Nicholas Piggin, Paulo Flabiano Smorigo,
linux-crypto, Breno Leitão, linuxppc-dev, David S. Miller
From: Randy Dunlap <rdunlap@infradead•org>
[ Upstream commit b04b076fb56560b39d695ac3744db457e12278fd ]
Fix build warnings when DEBUG_FS is not enabled by using an empty
do-while loop instead of a value:
In file included from ../drivers/crypto/nx/nx.c:27:
../drivers/crypto/nx/nx.c: In function 'nx_register_algs':
../drivers/crypto/nx/nx.h:173:33: warning: statement with no effect [-Wunused-value]
173 | #define NX_DEBUGFS_INIT(drv) (0)
../drivers/crypto/nx/nx.c:573:9: note: in expansion of macro 'NX_DEBUGFS_INIT'
573 | NX_DEBUGFS_INIT(&nx_driver);
../drivers/crypto/nx/nx.c: In function 'nx_remove':
../drivers/crypto/nx/nx.h:174:33: warning: statement with no effect [-Wunused-value]
174 | #define NX_DEBUGFS_FINI(drv) (0)
../drivers/crypto/nx/nx.c:793:17: note: in expansion of macro 'NX_DEBUGFS_FINI'
793 | NX_DEBUGFS_FINI(&nx_driver);
Also, there is no need to build nx_debugfs.o when DEBUG_FS is not
enabled, so change the Makefile to accommodate that.
Fixes: ae0222b7289d ("powerpc/crypto: nx driver code supporting nx encryption")
Fixes: aef7b31c8833 ("powerpc/crypto: Build files for the nx device driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead•org>
Cc: Breno Leitão <leitao@debian•org>
Cc: Nayna Jain <nayna@linux•ibm.com>
Cc: Paulo Flabiano Smorigo <pfsmorigo@gmail•com>
Cc: Herbert Xu <herbert@gondor•apana.org.au>
Cc: "David S. Miller" <davem@davemloft•net>
Cc: linux-crypto@vger•kernel.org
Cc: Michael Ellerman <mpe@ellerman•id.au>
Cc: Nicholas Piggin <npiggin@gmail•com>
Cc: Christophe Leroy <christophe.leroy@csgroup•eu>
Cc: linuxppc-dev@lists•ozlabs.org
Signed-off-by: Herbert Xu <herbert@gondor•apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel•org>
---
drivers/crypto/nx/Makefile | 2 +-
drivers/crypto/nx/nx.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/nx/Makefile b/drivers/crypto/nx/Makefile
index d00181a26dd65..483cef62acee8 100644
--- a/drivers/crypto/nx/Makefile
+++ b/drivers/crypto/nx/Makefile
@@ -1,7 +1,6 @@
# SPDX-License-Identifier: GPL-2.0
obj-$(CONFIG_CRYPTO_DEV_NX_ENCRYPT) += nx-crypto.o
nx-crypto-objs := nx.o \
- nx_debugfs.o \
nx-aes-cbc.o \
nx-aes-ecb.o \
nx-aes-gcm.o \
@@ -11,6 +10,7 @@ nx-crypto-objs := nx.o \
nx-sha256.o \
nx-sha512.o
+nx-crypto-$(CONFIG_DEBUG_FS) += nx_debugfs.o
obj-$(CONFIG_CRYPTO_DEV_NX_COMPRESS_PSERIES) += nx-compress-pseries.o nx-compress.o
obj-$(CONFIG_CRYPTO_DEV_NX_COMPRESS_POWERNV) += nx-compress-powernv.o nx-compress.o
nx-compress-objs := nx-842.o
diff --git a/drivers/crypto/nx/nx.h b/drivers/crypto/nx/nx.h
index c6233173c612e..2697baebb6a35 100644
--- a/drivers/crypto/nx/nx.h
+++ b/drivers/crypto/nx/nx.h
@@ -170,8 +170,8 @@ struct nx_sg *nx_walk_and_build(struct nx_sg *, unsigned int,
void nx_debugfs_init(struct nx_crypto_driver *);
void nx_debugfs_fini(struct nx_crypto_driver *);
#else
-#define NX_DEBUGFS_INIT(drv) (0)
-#define NX_DEBUGFS_FINI(drv) (0)
+#define NX_DEBUGFS_INIT(drv) do {} while (0)
+#define NX_DEBUGFS_FINI(drv) do {} while (0)
#endif
#define NX_PAGE_NUM(x) ((u64)(x) & 0xfffffffffffff000ULL)
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread