From: "Bruno Prémont" <bonbons@linux-vserver•org>
To: Thomas Zimmermann <tzimmermann@suse•de>
Cc: linux-fbdev@vger•kernel.org, Jiri Kosina <jikos@kernel•org>,
kvm@vger•kernel.org, linux-hyperv@vger•kernel.org,
linux-sh@vger•kernel.org, deller@gmx•de,
linux-staging@lists•linux.dev, linux-kernel@vger•kernel.org,
amd-gfx@lists•freedesktop.org, javierm@redhat•com,
Benjamin Tissoires <benjamin.tissoires@redhat•com>,
dri-devel@lists•freedesktop.org, linux-input@vger•kernel.org,
linux-nvidia@lists•surfsouth.com, linux-omap@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, linux-geode@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
linux-media@vger•kernel.org
Subject: Re: [PATCH 10/17] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver
Date: Wed, 12 Jul 2023 11:43:35 +0200 [thread overview]
Message-ID: <20230712114335.42644eab@hemera.lan.sysophe.eu> (raw)
In-Reply-To: <20230710130113.14563-11-tzimmermann@suse.de>
On Mon, 10 Jul 2023 14:50:14 +0200 Thomas Zimmermann wrote:
> The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
> fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do
> not set it.
>
> Flags should signal differences from the default values. After cleaning
> up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse•de>
> Cc: "Bruno Prémont" <bonbons@linux-vserver•org>
> Cc: Jiri Kosina <jikos@kernel•org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat•com>
Acked-by: Bruno Prémont <bonbons@linux-vserver•org>
Cheers,
Bruno
> ---
> drivers/hid/hid-picolcd_fb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
> index dabcd054dad9..d726aaafb146 100644
> --- a/drivers/hid/hid-picolcd_fb.c
> +++ b/drivers/hid/hid-picolcd_fb.c
> @@ -527,7 +527,6 @@ int picolcd_init_framebuffer(struct picolcd_data *data)
> info->var = picolcdfb_var;
> info->fix = picolcdfb_fix;
> info->fix.smem_len = PICOLCDFB_SIZE*8;
> - info->flags = FBINFO_FLAG_DEFAULT;
>
> fbdata = info->par;
> spin_lock_init(&fbdata->lock);
next prev parent reply other threads:[~2023-07-12 9:50 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 12:50 [PATCH 00/17] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 01/17] drm: Remove flag FBINFO_DEFAULT from fbdev emulation Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 02/17] fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 03/17] " Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 04/17] " Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 05/17] " Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 06/17] fbdev/fsl-diu-fb: Remove flag FBINFO_DEFAULT Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 07/17] vfio-mdev: Remove flag FBINFO_DEFAULT from fbdev sample driver Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 08/17] arch/sh: Do not assign FBINFO_FLAG_DEFAULT to fb_videomode.flag Thomas Zimmermann
2023-07-10 13:42 ` John Paul Adrian Glaubitz
2023-07-10 13:52 ` Thomas Zimmermann
2023-07-10 13:59 ` John Paul Adrian Glaubitz
2023-07-10 14:04 ` Thomas Zimmermann
2023-07-10 14:08 ` John Paul Adrian Glaubitz
2023-07-10 12:50 ` [PATCH 09/17] auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-10 14:24 ` Miguel Ojeda
2023-07-10 15:22 ` Thomas Zimmermann
2023-07-10 16:25 ` Miguel Ojeda
2023-07-11 6:10 ` Thomas Zimmermann
2023-07-11 10:03 ` Miguel Ojeda
2023-07-10 12:50 ` [PATCH 10/17] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver Thomas Zimmermann
2023-07-10 13:05 ` Benjamin Tissoires
2023-07-12 9:43 ` Bruno Prémont [this message]
2023-07-10 12:50 ` [PATCH 11/17] media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 12/17] staging: " Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 13/17] fbdev: " Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 14/17] " Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 15/17] fbdev/atafb: Remove flag FBINFO_FLAG_DEFAULT Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 16/17] fbdev/pxafb: " Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 17/17] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT Thomas Zimmermann
2023-07-10 17:19 ` [PATCH 00/17] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags Sam Ravnborg
2023-07-11 6:24 ` Thomas Zimmermann
2023-07-11 14:47 ` Sam Ravnborg
2023-07-11 15:24 ` Helge Deller
2023-07-11 16:04 ` Geert Uytterhoeven
2023-07-12 6:44 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712114335.42644eab@hemera.lan.sysophe.eu \
--to=bonbons@linux-vserver$(echo .)org \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=benjamin.tissoires@redhat$(echo .)com \
--cc=deller@gmx$(echo .)de \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=javierm@redhat$(echo .)com \
--cc=jikos@kernel$(echo .)org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-fbdev@vger$(echo .)kernel.org \
--cc=linux-geode@lists$(echo .)infradead.org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-nvidia@lists$(echo .)surfsouth.com \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=tzimmermann@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox