From: Herve Codina <herve.codina@bootlin•com>
To: Rob Herring <robh@kernel•org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin•com>,
Heikki Krogerus <heikki.krogerus@linux•intel.com>,
Richard Leitner <richard.leitner@linux•dev>,
linux-kernel@vger•kernel.org,
Paul Cercueil <paul@crapouillou•net>,
Aswath Govindraju <a-govindraju@ti•com>,
Conor Dooley <conor.dooley@microchip•com>,
Thierry Reding <thierry.reding@gmail•com>,
linux-riscv@lists•infradead.org,
Fabio Estevam <festevam@gmail•com>,
Bjorn Andersson <andersson@kernel•org>,
Samuel Holland <samuel@sholland•org>,
Robert Jarzmik <robert.jarzmik@free•fr>,
Jernej Skrabec <jernej.skrabec@gmail•com>,
Jonathan Hunter <jonathanh@nvidia•com>,
Chen-Yu Tsai <wens@csie•org>, Andy Gross <agross@kernel•org>,
Alan Stern <stern@rowland•harvard.edu>,
NXP Linux Team <linux-imx@nxp•com>,
linux-renesas-soc@vger•kernel.org,
Chunfeng Yun <chunfeng.yun@mediatek•com>,
Bryan O'Donoghue <bryan.odonoghue@linaro•org>,
linux-mips@vger•kernel.org, linux-sunxi@lists•linux.dev,
Guenter Roeck <linux@roeck-us•net>,
Matthias Brugger <matthias .bgg@gmail•com>,
devicetree@vger•kernel.org, Pawel Laszczak <pawell@cadence•com>,
linux-tegra@vger•kernel.org,
Mathias Nyman <mathias.nyman@intel•com>,
linux-arm-msm@vger•kernel.org,
Sascha Hauer <s.hauer@pengutronix•de>,
linuxppc-dev@lists•ozlabs.org,
Haojian Zhuang <haojian.zhuang@gmail•com>,
Roger Quadros <rogerq@kernel•org>,
linux-mediatek@lists•infradead.org,
Minas Harutyunyan <hminas@synopsys•com>,
Michal Simek <michal.simek@amd•com>, Bin Liu <b-liu@ti•com>,
linux-arm-kernel@lists•infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora•com>,
Daire McNamara <daire.mcnamara@microchip•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Peter Chen <peter.chen@kernel•org>,
linux-usb@vger•kernel.org,
Nicolas Ferre <nicolas.ferre@microchip•com>,
Li Yang <leoyang.li@nxp•com>,
Konrad Dybcio <konrad.dybcio@linaro•org>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Thinh Nguyen <Thinh.Nguyen@synopsys•com>,
Shawn Guo <shawnguo@kernel•org>,
Claudiu Beznea <clau diu.beznea@microchip•com>,
Daniel Mack <daniel@zonque•org>
Subject: Re: [PATCH] usb: Explicitly include correct DT includes
Date: Tue, 18 Jul 2023 08:31:49 +0200 [thread overview]
Message-ID: <20230718083149.77fa57ef@bootlin.com> (raw)
In-Reply-To: <20230714175027.4065135-1-robh@kernel.org>
Hi Rob,
On Fri, 14 Jul 2023 11:50:23 -0600
Rob Herring <robh@kernel•org> wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel•org>
> ---
[...]
> diff --git a/drivers/usb/gadget/udc/renesas_usbf.c b/drivers/usb/gadget/udc/renesas_usbf.c
> index 6cd0af83e91e..3482b41d0646 100644
> --- a/drivers/usb/gadget/udc/renesas_usbf.c
> +++ b/drivers/usb/gadget/udc/renesas_usbf.c
> @@ -12,10 +12,9 @@
> #include <linux/iopoll.h>
> #include <linux/kernel.h>
> #include <linux/kfifo.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> -#include <linux/of_address.h>
> -#include <linux/of_irq.h>
> -#include <linux/of_platform.h>
> +#include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/types.h>
> #include <linux/usb/composite.h>
Acked-by: Herve Codina <herve.codina@bootlin•com>
Best regards,
Hervé
prev parent reply other threads:[~2023-07-18 6:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 17:50 [PATCH] usb: Explicitly include correct DT includes Rob Herring
2023-07-17 17:42 ` Rob Herring
2023-07-18 6:31 ` Herve Codina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718083149.77fa57ef@bootlin.com \
--to=herve.codina@bootlin$(echo .)com \
--cc=Thinh.Nguyen@synopsys$(echo .)com \
--cc=a-govindraju@ti$(echo .)com \
--cc=agross@kernel$(echo .)org \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andersson@kernel$(echo .)org \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=b-liu@ti$(echo .)com \
--cc=bryan.odonoghue@linaro$(echo .)org \
--cc=chunfeng.yun@mediatek$(echo .)com \
--cc=conor.dooley@microchip$(echo .)com \
--cc=daire.mcnamara@microchip$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=haojian.zhuang@gmail$(echo .)com \
--cc=heikki.krogerus@linux$(echo .)intel.com \
--cc=hminas@synopsys$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=konrad.dybcio@linaro$(echo .)org \
--cc=leoyang.li@nxp$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mathias.nyman@intel$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=michal.simek@amd$(echo .)com \
--cc=nicolas.ferre@microchip$(echo .)com \
--cc=paul@crapouillou$(echo .)net \
--cc=pawell@cadence$(echo .)com \
--cc=peter.chen@kernel$(echo .)org \
--cc=richard.leitner@linux$(echo .)dev \
--cc=robert.jarzmik@free$(echo .)fr \
--cc=robh@kernel$(echo .)org \
--cc=rogerq@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=samuel@sholland$(echo .)org \
--cc=shawnguo@kernel$(echo .)org \
--cc=stern@rowland$(echo .)harvard.edu \
--cc=thierry.reding@gmail$(echo .)com \
--cc=wens@csie$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox