From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: stable@vger•kernel.org
Cc: Sasha Levin <sashal@kernel•org>,
Kumar Gala <galak@kernel•crashing.org>,
kernel test robot <lkp@intel•com>,
Nicolas Schier <nicolas@jasle•eu>,
Masahiro Yamada <masahiroy@kernel•org>,
Randy Dunlap <rdunlap@infradead•org>,
patches@lists•linux.dev, Leo Li <leoyang.li@nxp•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Qiang Zhao <qiang.zhao@nxp•com>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
linux-arm-kernel@lists•infradead.org,
Nicolas Schier <nicolas@fjasle•eu>
Subject: [PATCH 5.10 132/509] soc/fsl/qe: fix usb.c build errors
Date: Tue, 25 Jul 2023 12:41:11 +0200 [thread overview]
Message-ID: <20230725104559.758080115@linuxfoundation.org> (raw)
In-Reply-To: <20230725104553.588743331@linuxfoundation.org>
From: Randy Dunlap <rdunlap@infradead•org>
[ Upstream commit 7b1a78babd0d2cd27aa07255dee0c2d7ac0f31e3 ]
Fix build errors in soc/fsl/qe/usb.c when QUICC_ENGINE is not set.
This happens when PPC_EP88XC is set, which selects CPM1 & CPM.
When CPM is set, USB_FSL_QE can be set without QUICC_ENGINE
being set. When USB_FSL_QE is set, QE_USB deafults to y, which
causes build errors when QUICC_ENGINE is not set. Making
QE_USB depend on QUICC_ENGINE prevents QE_USB from defaulting to y.
Fixes these build errors:
drivers/soc/fsl/qe/usb.o: in function `qe_usb_clock_set':
usb.c:(.text+0x1e): undefined reference to `qe_immr'
powerpc-linux-ld: usb.c:(.text+0x2a): undefined reference to `qe_immr'
powerpc-linux-ld: usb.c:(.text+0xbc): undefined reference to `qe_setbrg'
powerpc-linux-ld: usb.c:(.text+0xca): undefined reference to `cmxgcr_lock'
powerpc-linux-ld: usb.c:(.text+0xce): undefined reference to `cmxgcr_lock'
Fixes: 5e41486c408e ("powerpc/QE: add support for QE USB clocks routing")
Signed-off-by: Randy Dunlap <rdunlap@infradead•org>
Reported-by: kernel test robot <lkp@intel•com>
Link: https://lore.kernel.org/all/202301101500.pillNv6R-lkp@intel.com/
Suggested-by: Michael Ellerman <mpe@ellerman•id.au>
Cc: Christophe Leroy <christophe.leroy@csgroup•eu>
Cc: Leo Li <leoyang.li@nxp•com>
Cc: Masahiro Yamada <masahiroy@kernel•org>
Cc: Nicolas Schier <nicolas@fjasle•eu>
Cc: Qiang Zhao <qiang.zhao@nxp•com>
Cc: linuxppc-dev <linuxppc-dev@lists•ozlabs.org>
Cc: linux-arm-kernel@lists•infradead.org
Cc: Kumar Gala <galak@kernel•crashing.org>
Acked-by: Nicolas Schier <nicolas@jasle•eu>
Signed-off-by: Li Yang <leoyang.li@nxp•com>
Signed-off-by: Sasha Levin <sashal@kernel•org>
---
drivers/soc/fsl/qe/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig
index 357c5800b112f..7afa796dbbb89 100644
--- a/drivers/soc/fsl/qe/Kconfig
+++ b/drivers/soc/fsl/qe/Kconfig
@@ -39,6 +39,7 @@ config QE_TDM
config QE_USB
bool
+ depends on QUICC_ENGINE
default y if USB_FSL_QE
help
QE USB Controller support
--
2.39.2
next parent reply other threads:[~2023-07-25 11:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230725104553.588743331@linuxfoundation.org>
2023-07-25 10:41 ` Greg Kroah-Hartman [this message]
2023-07-25 10:42 ` [PATCH 5.10 201/509] crypto: nx - fix build warnings when DEBUG_FS is not enabled Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725104559.758080115@linuxfoundation.org \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=galak@kernel$(echo .)crashing.org \
--cc=leoyang.li@nxp$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lkp@intel$(echo .)com \
--cc=masahiroy@kernel$(echo .)org \
--cc=nicolas@fjasle$(echo .)eu \
--cc=nicolas@jasle$(echo .)eu \
--cc=patches@lists$(echo .)linux.dev \
--cc=qiang.zhao@nxp$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=sashal@kernel$(echo .)org \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox