From: Jason Gunthorpe <jgg@nvidia•com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro•org>
Cc: Heiko Stuebner <heiko@sntech•de>,
Matthew Rosato <mjrosato@linux•ibm.com>,
Jerry Snitselaar <jsnitsel@redhat•com>,
Russell King <linux@armlinux•org.uk>,
Matthias Brugger <matthias.bgg@gmail•com>,
Thierry Reding <thierry.reding@gmail•com>,
Jernej Skrabec <jernej.skrabec@gmail•com>,
Alim Akhtar <alim.akhtar@samsung•com>,
Dmitry Osipenko <digetx@gmail•com>,
Steven Price <steven.price@arm•com>,
Will Deacon <will@kernel•org>,
Marek Szyprowski <m.szyprowski@samsung•com>,
linux-s390@vger•kernel.org, linux-samsung-soc@vger•kernel.org,
Samuel Holland <samuel@sholland•org>,
Joerg Roedel <joro@8bytes•org>, Rob Clark <robdclark@gmail•com>,
Jonathan Hunter <jonathanh@nvidia•com>,
linux-rockchip@lists•infradead.org, iommu@lists•linux.dev,
Andy Gross <agross@kernel•org>,
Nicolin Chen <nicolinc@nvidia•com>,
Yong Wu <yong.wu@mediatek•com>, Orson Zhai <orsonzhai@gmail•com>,
Gerald Schaefer <gerald.schaefer@linux•ibm.com>,
Thierry Reding <treding@nvidia•com>,
linux-sunxi@lists•linux.dev, Kevin Tian <kevin.tian@intel•com>,
Niklas Schnelle <schnelle@linux•ibm.com>,
linux-arm-msm@vger•kernel.org,
Nicholas Piggin <npiggin@gmail•com>,
Krishna Reddy <vdumpa@nvidia•com>,
linux-mediatek@lists•infradead.org,
Baolin Wang <baolin.wang@linux•alibaba.com>,
linux-tegra@vger•kernel.org, Chen-Yu Tsai <wens@csie•org>,
linux-arm-kernel@lists•infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora•com>,
Robin Murphy <robin.murphy@arm•com>,
Bjorn Andersson <andersson@kernel•org>,
Konrad Dybcio <konrad.dybcio@linaro•org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro•org>,
Chunyan Zhang <zhang.lyra@gmail•com>,
linuxppc-dev@lists•ozlabs.org,
Lu Baolu <baolu.lu@linux•intel.com>
Subject: Re: [PATCH v8 20/24] iommu: Require a default_domain for all iommu drivers
Date: Mon, 2 Oct 2023 20:00:00 -0300 [thread overview]
Message-ID: <20231002230000.GA682044@nvidia.com> (raw)
In-Reply-To: <CAA8EJprz7VVmBG68U9zLuqPd0UdSRHYoLDJSP6tCj6H6qanuTQ@mail.gmail.com>
On Tue, Oct 03, 2023 at 12:21:59AM +0300, Dmitry Baryshkov wrote:
> On Wed, 13 Sept 2023 at 16:45, Jason Gunthorpe <jgg@nvidia•com> wrote:
> >
> > At this point every iommu driver will cause a default_domain to be
> > selected, so we can finally remove this gap from the core code.
> >
> > The following table explains what each driver supports and what the
> > resulting default_domain will be:
> >
> > ops->defaut_domain
> > IDENTITY DMA PLATFORM v ARM32 dma-iommu ARCH
> > amd/iommu.c Y Y N/A either
> > apple-dart.c Y Y N/A either
> > arm-smmu.c Y Y IDENTITY either
> > qcom_iommu.c G Y IDENTITY either
> > arm-smmu-v3.c Y Y N/A either
> > exynos-iommu.c G Y IDENTITY either
> > fsl_pamu_domain.c Y Y N/A N/A PLATFORM
> > intel/iommu.c Y Y N/A either
> > ipmmu-vmsa.c G Y IDENTITY either
> > msm_iommu.c G IDENTITY N/A
>
> Unfortunately this patch breaks msm_iommu platforms. This driver
> doesn't select ARM_DMA_USE_IOMMU, so iommu_get_default_domain_type()
> returns 0, bus_iommu_probe() fails with -ENODEV.
> If I make MSM_IOMMU select ARM_DMA_USE_IOMMU, then GPU probing fails
> with -EBUSY.
Oh, OK.
Does this fix it?
diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c
index cdc7b730192a35..f7ef081c33dcb2 100644
--- a/drivers/iommu/msm_iommu.c
+++ b/drivers/iommu/msm_iommu.c
@@ -685,10 +685,16 @@ irqreturn_t msm_iommu_fault_handler(int irq, void *dev_id)
return 0;
}
+static int msm_iommu_def_domain_type(struct device *dev)
+{
+ return IOMMU_DOMAIN_IDENTITY;
+}
+
static struct iommu_ops msm_iommu_ops = {
.identity_domain = &msm_iommu_identity_domain,
.domain_alloc_paging = msm_iommu_domain_alloc_paging,
.probe_device = msm_iommu_probe_device,
+ .def_domain_type = msm_iommu_def_domain_type,
.device_group = generic_device_group,
.pgsize_bitmap = MSM_IOMMU_PGSIZES,
.of_xlate = qcom_iommu_of_xlate,
next prev parent reply other threads:[~2023-10-02 23:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 13:43 [PATCH v8 00/24] iommu: Make default_domain's mandatory Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 01/24] iommu: Add iommu_ops->identity_domain Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 02/24] iommu: Add IOMMU_DOMAIN_PLATFORM Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 03/24] powerpc/iommu: Setup a default domain and remove set_platform_dma_ops Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 04/24] iommu: Add IOMMU_DOMAIN_PLATFORM for S390 Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 05/24] iommu/fsl_pamu: Implement a PLATFORM domain Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 06/24] iommu/tegra-gart: Remove tegra-gart Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 07/24] iommu/mtk_iommu_v1: Implement an IDENTITY domain Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 08/24] iommu: Reorganize iommu_get_default_domain_type() to respect def_domain_type() Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 09/24] iommu: Allow an IDENTITY domain as the default_domain in ARM32 Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 10/24] iommu/exynos: Implement an IDENTITY domain Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 11/24] iommu/tegra-smmu: " Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 12/24] iommu/tegra-smmu: Support DMA domains in tegra Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 13/24] iommu/omap: Implement an IDENTITY domain Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 14/24] iommu/msm: " Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 15/24] iommu: Remove ops->set_platform_dma_ops() Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 16/24] iommu/qcom_iommu: Add an IOMMU_IDENTITIY_DOMAIN Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 17/24] iommu/ipmmu: " Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 18/24] iommu/mtk_iommu: " Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 19/24] iommu/sun50i: " Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 20/24] iommu: Require a default_domain for all iommu drivers Jason Gunthorpe
2023-10-02 21:21 ` Dmitry Baryshkov
2023-10-02 23:00 ` Jason Gunthorpe [this message]
2023-10-03 8:34 ` Dmitry Baryshkov
2023-09-13 13:43 ` [PATCH v8 21/24] iommu: Add __iommu_group_domain_alloc() Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 22/24] iommu: Add ops->domain_alloc_paging() Jason Gunthorpe
2023-09-13 13:43 ` [PATCH v8 23/24] iommu: Convert simple drivers with DOMAIN_DMA to domain_alloc_paging() Jason Gunthorpe
2023-09-19 10:44 ` Yong Wu (吴勇)
2023-09-13 13:43 ` [PATCH v8 24/24] iommu: Convert remaining simple drivers " Jason Gunthorpe
2023-09-25 9:41 ` [PATCH v8 00/24] iommu: Make default_domain's mandatory Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002230000.GA682044@nvidia.com \
--to=jgg@nvidia$(echo .)com \
--cc=agross@kernel$(echo .)org \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=andersson@kernel$(echo .)org \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=baolin.wang@linux$(echo .)alibaba.com \
--cc=baolu.lu@linux$(echo .)intel.com \
--cc=digetx@gmail$(echo .)com \
--cc=dmitry.baryshkov@linaro$(echo .)org \
--cc=gerald.schaefer@linux$(echo .)ibm.com \
--cc=heiko@sntech$(echo .)de \
--cc=iommu@lists$(echo .)linux.dev \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=jsnitsel@redhat$(echo .)com \
--cc=kevin.tian@intel$(echo .)com \
--cc=konrad.dybcio@linaro$(echo .)org \
--cc=krzysztof.kozlowski@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mjrosato@linux$(echo .)ibm.com \
--cc=nicolinc@nvidia$(echo .)com \
--cc=npiggin@gmail$(echo .)com \
--cc=orsonzhai@gmail$(echo .)com \
--cc=robdclark@gmail$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=samuel@sholland$(echo .)org \
--cc=schnelle@linux$(echo .)ibm.com \
--cc=steven.price@arm$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=treding@nvidia$(echo .)com \
--cc=vdumpa@nvidia$(echo .)com \
--cc=wens@csie$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=yong.wu@mediatek$(echo .)com \
--cc=zhang.lyra@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox