From: Jason Gunthorpe <jgg@nvidia•com>
To: Sean Christopherson <seanjc@google•com>
Cc: kvm@vger•kernel.org, David Hildenbrand <david@redhat•com>,
Catalin Marinas <catalin.marinas@arm•com>,
Dave Hansen <dave.hansen@linux•intel.com>,
"H. Peter Anvin" <hpa@zytor•com>,
Alexander Gordeev <agordeev@linux•ibm.com>,
Claudio Imbrenda <imbrenda@linux•ibm.com>,
Will Deacon <will@kernel•org>,
linux-s390@vger•kernel.org, Janosch Frank <frankja@linux•ibm.com>,
x86@kernel•org, Ingo Molnar <mingo@redhat•com>,
Zenghui Yu <yuzenghui@huawei•com>,
Christian Borntraeger <borntraeger@linux•ibm.com>,
Vasily Gorbik <gor@linux•ibm.com>,
Suzuki K Poulose <suzuki.poulose@arm•com>,
Heiko Carstens <hca@linux•ibm.com>,
Nicholas Piggin <npiggin@gmail•com>,
Borislav Petkov <bp@alien8•de>,
kvmarm@lists•linux.dev, Thomas Gleixner <tglx@linutronix•de>,
linux-arm-kernel@lists•infradead.org,
Oliver Upton <oliver.upton@linux•dev>,
James Morse <james.morse@arm•com>,
Sven Schnelle <svens@linux•ibm.com>,
Marc Zyngier <maz@kernel•org>,
Paolo Bonzini <pbonzini@redhat•com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: Ping? Re: [PATCH rc] kvm: Prevent compiling virt/kvm/vfio.c unless VFIO is selected
Date: Wed, 29 Nov 2023 08:48:21 -0400 [thread overview]
Message-ID: <20231129124821.GU436702@nvidia.com> (raw)
In-Reply-To: <ZWagNsu1XQIqk5z9@google.com>
On Tue, Nov 28, 2023 at 06:21:42PM -0800, Sean Christopherson wrote:
> diff --git a/include/linux/vfio.h b/include/linux/vfio.h
> index 454e9295970c..a65b2513f8cd 100644
> --- a/include/linux/vfio.h
> +++ b/include/linux/vfio.h
> @@ -289,16 +289,12 @@ void vfio_combine_iova_ranges(struct rb_root_cached *root, u32 cur_nodes,
> /*
> * External user API
> */
> -#if IS_ENABLED(CONFIG_VFIO_GROUP)
> struct iommu_group *vfio_file_iommu_group(struct file *file);
> +
> +#if IS_ENABLED(CONFIG_VFIO_GROUP)
> bool vfio_file_is_group(struct file *file);
> bool vfio_file_has_dev(struct file *file, struct vfio_device *device);
> #else
> -static inline struct iommu_group *vfio_file_iommu_group(struct file *file)
> -{
> - return NULL;
> -}
> -
> static inline bool vfio_file_is_group(struct file *file)
> {
> return false;
>
So you symbol get on a symbol that can never be defined? Still says to
me the kconfig needs fixing :|
But sure, as a small patch it looks fine
Thanks,
Jason
next prev parent reply other threads:[~2023-11-29 12:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 18:18 [PATCH rc] kvm: Prevent compiling virt/kvm/vfio.c unless VFIO is selected Jason Gunthorpe
2023-09-22 0:00 ` Michael Ellerman
2023-11-10 6:08 ` Ping? " Michael Ellerman
2023-11-29 2:21 ` Sean Christopherson
2023-11-29 9:38 ` Michael Ellerman
2023-11-30 1:07 ` Sean Christopherson
2023-11-30 1:16 ` Jason Gunthorpe
2023-11-30 2:02 ` Sean Christopherson
2023-11-30 6:38 ` Michael Ellerman
2023-11-30 12:07 ` Jason Gunthorpe
2023-11-29 12:48 ` Jason Gunthorpe [this message]
2023-11-29 18:31 ` Sean Christopherson
2023-11-29 21:45 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129124821.GU436702@nvidia.com \
--to=jgg@nvidia$(echo .)com \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=david@redhat$(echo .)com \
--cc=frankja@linux$(echo .)ibm.com \
--cc=gor@linux$(echo .)ibm.com \
--cc=hca@linux$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=imbrenda@linux$(echo .)ibm.com \
--cc=james.morse@arm$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kvmarm@lists$(echo .)linux.dev \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maz@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=npiggin@gmail$(echo .)com \
--cc=oliver.upton@linux$(echo .)dev \
--cc=pbonzini@redhat$(echo .)com \
--cc=seanjc@google$(echo .)com \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=svens@linux$(echo .)ibm.com \
--cc=tglx@linutronix$(echo .)de \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=yuzenghui@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox