From: Jason Gunthorpe <jgg@nvidia•com>
To: Sean Christopherson <seanjc@google•com>
Cc: kvm@vger•kernel.org, David Hildenbrand <david@redhat•com>,
Catalin Marinas <catalin.marinas@arm•com>,
Dave Hansen <dave.hansen@linux•intel.com>,
"H. Peter Anvin" <hpa@zytor•com>,
Alexander Gordeev <agordeev@linux•ibm.com>,
Claudio Imbrenda <imbrenda@linux•ibm.com>,
Will Deacon <will@kernel•org>,
linux-s390@vger•kernel.org, Janosch Frank <frankja@linux•ibm.com>,
x86@kernel•org, Ingo Molnar <mingo@redhat•com>,
Zenghui Yu <yuzenghui@huawei•com>,
Christian Borntraeger <borntraeger@linux•ibm.com>,
Vasily Gorbik <gor@linux•ibm.com>,
Suzuki K Poulose <suzuki.poulose@arm•com>,
Heiko Carstens <hca@linux•ibm.com>,
Nicholas Piggin <npiggin@gmail•com>,
Borislav Petkov <bp@alien8•de>,
kvmarm@lists•linux.dev, Thomas Gleixner <tglx@linutronix•de>,
linux-arm-kernel@lists•infradead.org,
Oliver Upton <oliver.upton@linux•dev>,
James Morse <james.morse@arm•com>,
Sven Schnelle <svens@linux•ibm.com>,
Marc Zyngier <maz@kernel•org>,
Paolo Bonzini <pbonzini@redhat•com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: Ping? Re: [PATCH rc] kvm: Prevent compiling virt/kvm/vfio.c unless VFIO is selected
Date: Thu, 30 Nov 2023 08:07:43 -0400 [thread overview]
Message-ID: <20231130120743.GF1389974@nvidia.com> (raw)
In-Reply-To: <ZWftIIEpbLP2xF5H@google.com>
On Wed, Nov 29, 2023 at 06:02:08PM -0800, Sean Christopherson wrote:
> > > Ah, it's the same warning, I just missed the CONFIG_MODULES=n requirement.
> >
> > Oh, wait, doesn't that mean the approach won't work? IIRC doesn't
> > symbol_get turn into just &fn when non-modular turning this into a
> > link failure without the kconfig part?
>
> Yes, but it doesn't cause linker errors. IIUC, because the extern declaration
> is tagged "weak", a dummy default is used. E.g. on x86, this is what is generated
> with VFIO=y
Oh wow that is some pretty dark magic there :|
Jason
next prev parent reply other threads:[~2023-11-30 12:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 18:18 [PATCH rc] kvm: Prevent compiling virt/kvm/vfio.c unless VFIO is selected Jason Gunthorpe
2023-09-22 0:00 ` Michael Ellerman
2023-11-10 6:08 ` Ping? " Michael Ellerman
2023-11-29 2:21 ` Sean Christopherson
2023-11-29 9:38 ` Michael Ellerman
2023-11-30 1:07 ` Sean Christopherson
2023-11-30 1:16 ` Jason Gunthorpe
2023-11-30 2:02 ` Sean Christopherson
2023-11-30 6:38 ` Michael Ellerman
2023-11-30 12:07 ` Jason Gunthorpe [this message]
2023-11-29 12:48 ` Jason Gunthorpe
2023-11-29 18:31 ` Sean Christopherson
2023-11-29 21:45 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130120743.GF1389974@nvidia.com \
--to=jgg@nvidia$(echo .)com \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=david@redhat$(echo .)com \
--cc=frankja@linux$(echo .)ibm.com \
--cc=gor@linux$(echo .)ibm.com \
--cc=hca@linux$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=imbrenda@linux$(echo .)ibm.com \
--cc=james.morse@arm$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kvmarm@lists$(echo .)linux.dev \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maz@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=npiggin@gmail$(echo .)com \
--cc=oliver.upton@linux$(echo .)dev \
--cc=pbonzini@redhat$(echo .)com \
--cc=seanjc@google$(echo .)com \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=svens@linux$(echo .)ibm.com \
--cc=tglx@linutronix$(echo .)de \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=yuzenghui@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox