From: Mauro Carvalho Chehab <mchehab@kernel•org>
To: Shengjiu Wang <shengjiu.wang@nxp•com>
Cc: nicoleotsuka@gmail•com, alsa-devel@alsa-project•org,
lgirdwood@gmail•com, Xiubo.Lee@gmail•com, festevam@gmail•com,
tiwai@suse•com, linux-kernel@vger•kernel.org, tfiga@chromium•org,
hverkuil@xs4all•nl, linuxppc-dev@lists•ozlabs.org,
broonie@kernel•org, sakari.ailus@iki•fi, perex@perex•cz,
linux-media@vger•kernel.org, shengjiu.wang@gmail•com,
m.szyprowski@samsung•com
Subject: Re: [PATCH v12 08/15] media: uapi: Define audio sample format fourcc type
Date: Sat, 17 Feb 2024 10:19:26 +0100 [thread overview]
Message-ID: <20240217101926.3f1d2452@coco.lan> (raw)
In-Reply-To: <1705581128-4604-9-git-send-email-shengjiu.wang@nxp.com>
Em Thu, 18 Jan 2024 20:32:01 +0800
Shengjiu Wang <shengjiu.wang@nxp•com> escreveu:
> The audio sample format definition is from alsa,
> the header file is include/uapi/sound/asound.h, but
> don't include this header file directly, because in
> user space, there is another copy in alsa-lib.
> There will be conflict in userspace for include
> videodev2.h & asound.h and asoundlib.h
>
> Here still use the fourcc format.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp•com>
> ---
> .../userspace-api/media/v4l/pixfmt-audio.rst | 87 +++++++++++++++++++
> .../userspace-api/media/v4l/pixfmt.rst | 1 +
> drivers/media/v4l2-core/v4l2-ioctl.c | 13 +++
> include/uapi/linux/videodev2.h | 23 +++++
> 4 files changed, 124 insertions(+)
> create mode 100644 Documentation/userspace-api/media/v4l/pixfmt-audio.rst
>
> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-audio.rst b/Documentation/userspace-api/media/v4l/pixfmt-audio.rst
> new file mode 100644
> index 000000000000..04b4a7fbd8f4
> --- /dev/null
> +++ b/Documentation/userspace-api/media/v4l/pixfmt-audio.rst
> @@ -0,0 +1,87 @@
> +.. SPDX-License-Identifier: GFDL-1.1-no-invariants-or-later
> +
> +.. _pixfmt-audio:
> +
> +*************
> +Audio Formats
> +*************
> +
> +These formats are used for :ref:`audiomem2mem` interface only.
> +
> +.. tabularcolumns:: |p{5.8cm}|p{1.2cm}|p{10.3cm}|
> +
> +.. cssclass:: longtable
> +
> +.. flat-table:: Audio Format
> + :header-rows: 1
> + :stub-columns: 0
> + :widths: 3 1 4
> +
> + * - Identifier
> + - Code
> + - Details
> + * .. _V4L2-AUDIO-FMT-S8:
> +
> + - ``V4L2_AUDIO_FMT_S8``
> + - 'S8'
> + - Corresponds to SNDRV_PCM_FORMAT_S8 in ALSA
> + * .. _V4L2-AUDIO-FMT-S16-LE:
Hmm... why can't we just use SNDRV_*_FORMAT_*? Those are already part of
an uAPI header. No need to add any abstraction here and/or redefine
what is there already at include/uapi/sound/asound.h.
Thanks,
Mauro
next prev parent reply other threads:[~2024-02-17 9:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 12:31 [PATCH v12 00/15] Add audio support in v4l2 framework Shengjiu Wang
2024-01-18 12:31 ` [PATCH v12 01/15] ASoC: fsl_asrc: define functions for memory to memory usage Shengjiu Wang
2024-01-18 12:31 ` [PATCH v12 02/15] ASoC: fsl_easrc: " Shengjiu Wang
2024-01-18 12:31 ` [PATCH v12 03/15] ASoC: fsl_asrc: move fsl_asrc_common.h to include/sound Shengjiu Wang
2024-01-18 12:31 ` [PATCH v12 04/15] ASoC: fsl_asrc: register m2m platform device Shengjiu Wang
2024-01-18 12:31 ` [PATCH v12 05/15] ASoC: fsl_easrc: " Shengjiu Wang
2024-01-18 12:31 ` [PATCH v12 06/15] media: uapi: Add V4L2_CAP_AUDIO_M2M capability flag Shengjiu Wang
2024-01-18 12:32 ` [PATCH v12 07/15] media: v4l2: Add audio capture and output support Shengjiu Wang
2024-02-17 9:42 ` Mauro Carvalho Chehab
2024-02-19 6:35 ` Shengjiu Wang
2024-02-21 4:30 ` Tomasz Figa
2024-02-21 10:11 ` Shengjiu Wang
2024-02-21 11:16 ` Hans Verkuil
2024-02-21 11:13 ` Hans Verkuil
2024-02-21 4:32 ` Tomasz Figa
2024-01-18 12:32 ` [PATCH v12 08/15] media: uapi: Define audio sample format fourcc type Shengjiu Wang
2024-02-17 9:19 ` Mauro Carvalho Chehab [this message]
2024-02-19 4:05 ` Shengjiu Wang
2024-02-19 12:56 ` Mauro Carvalho Chehab
2024-02-21 11:10 ` Hans Verkuil
2024-02-22 3:50 ` Shengjiu Wang
2024-02-23 14:50 ` Hans Verkuil
2024-01-18 12:32 ` [PATCH v12 09/15] media: uapi: Add V4L2_CTRL_CLASS_M2M_AUDIO Shengjiu Wang
2024-01-18 12:32 ` [PATCH v12 10/15] media: uapi: Add audio rate controls support Shengjiu Wang
2024-02-17 9:57 ` Mauro Carvalho Chehab
2024-02-19 6:03 ` Shengjiu Wang
2024-02-19 12:16 ` Mauro Carvalho Chehab
2024-01-18 12:32 ` [PATCH v12 11/15] media: uapi: Declare interface types for Audio Shengjiu Wang
2024-01-18 12:32 ` [PATCH v12 12/15] media: uapi: Add an entity type for audio resampler Shengjiu Wang
2024-01-18 12:32 ` [PATCH v12 13/15] media: vivid: add fixed point test controls Shengjiu Wang
2024-01-18 12:32 ` [PATCH v12 14/15] media: imx-asrc: Add memory to memory driver Shengjiu Wang
2024-01-18 12:32 ` [PATCH v12 15/15] media: vim2m-audio: add virtual driver for audio memory to memory Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240217101926.3f1d2452@coco.lan \
--to=mchehab@kernel$(echo .)org \
--cc=Xiubo.Lee@gmail$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=festevam@gmail$(echo .)com \
--cc=hverkuil@xs4all$(echo .)nl \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=nicoleotsuka@gmail$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=sakari.ailus@iki$(echo .)fi \
--cc=shengjiu.wang@gmail$(echo .)com \
--cc=shengjiu.wang@nxp$(echo .)com \
--cc=tfiga@chromium$(echo .)org \
--cc=tiwai@suse$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox