Subject: Re: [PATCH 2/5] powerpc/64s: Use .machine power4 around dcbt

From: Segher Boessenkool <[email-masked]>
Date: Thu, 29 Feb 2024 11:20:25 -0600

On Thu, Feb 29, 2024 at 11:25:18PM +1100, Michael Ellerman wrote:
> There are multiple decodings for the "dcbt" mnemonic, so the assembler
> has to pick one.
> 
> That requires passing -many to the assembler, which is not recommended.
> 
> Without -many the clang 14 / binutils 2.38 build fails with:
> 
>   arch/powerpc/kernel/exceptions-64s.S:2976: Error: junk at end of line: `0b01010'
>   clang: error: assembler command failed with exit code 1 (use -v to see invocation)
> 
> Fix it by adding .machine directives around the use of dcbt to specify
> which encoding is desired.
> 
> Signed-off-by: Michael Ellerman <[email-masked]>

Looks good, thanks!

Acked-by: Segher Boessenkool <[email-masked]>

Segher