From: Jason Gunthorpe <jgg@nvidia•com>
To: peterx@redhat•com
Cc: x86@kernel•org, Yang Shi <shy828301@gmail•com>,
Muchun Song <muchun.song@linux•dev>,
linux-kernel@vger•kernel.org, Nicholas Piggin <npiggin@gmail•com>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel•org>,
linux-mm@kvack•org, "Naveen N. Rao" <naveen.n.rao@linux•ibm.com>,
"Kirill A . Shutemov" <kirill@shutemov•name>,
Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2 1/7] mm/ppc: Define pXd_large() with pXd_leaf()
Date: Mon, 4 Mar 2024 08:56:58 -0400 [thread overview]
Message-ID: <20240304125658.GO9179@nvidia.com> (raw)
In-Reply-To: <20240229084258.599774-2-peterx@redhat.com>
On Thu, Feb 29, 2024 at 04:42:52PM +0800, peterx@redhat•com wrote:
> From: Peter Xu <peterx@redhat•com>
>
> The two definitions are the same. The only difference is that pXd_large()
> is only defined with THP selected, and only on book3s 64bits.
>
> Instead of implementing it twice, make pXd_large() a macro to pXd_leaf().
> Define it unconditionally just like pXd_leaf(). This helps to prepare
> merging the two APIs.
>
> Cc: Michael Ellerman <mpe@ellerman•id.au>
> Cc: Nicholas Piggin <npiggin@gmail•com>
> Cc: Christophe Leroy <christophe.leroy@csgroup•eu>
> Cc: "Aneesh Kumar K.V" <aneesh.kumar@kernel•org>
> Cc: "Naveen N. Rao" <naveen.n.rao@linux•ibm.com>
> Cc: linuxppc-dev@lists•ozlabs.org
> Signed-off-by: Peter Xu <peterx@redhat•com>
> ---
> arch/powerpc/include/asm/book3s/64/pgtable.h | 16 ++--------------
> arch/powerpc/include/asm/pgtable.h | 2 +-
> 2 files changed, 3 insertions(+), 15 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia•com>
Jason
next prev parent reply other threads:[~2024-03-04 12:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 8:42 [PATCH v2 0/7] mm/treewide: Replace pXd_large() with pXd_leaf() peterx
2024-02-29 8:42 ` [PATCH v2 1/7] mm/ppc: Define " peterx
2024-03-04 12:56 ` Jason Gunthorpe [this message]
2024-02-29 8:42 ` [PATCH v2 2/7] mm/ppc: Replace pXd_is_leaf() " peterx
2024-03-04 12:57 ` Jason Gunthorpe
2024-02-29 8:42 ` [PATCH v2 3/7] mm/x86: Replace p4d_large() with p4d_leaf() peterx
2024-03-04 12:58 ` Jason Gunthorpe
2024-02-29 8:42 ` [PATCH v2 4/7] mm/x86: Drop two unnecessary pud_leaf() definitions peterx
2024-03-04 13:03 ` Jason Gunthorpe
2024-03-05 3:25 ` Peter Xu
2024-03-04 14:18 ` Thomas Gleixner
2024-02-29 8:42 ` [PATCH v2 5/7] mm/treewide: Replace pmd_large() with pmd_leaf() peterx
2024-03-04 13:09 ` Jason Gunthorpe
2024-02-29 8:42 ` [PATCH v2 6/7] mm/treewide: Replace pud_large() with pud_leaf() peterx
2024-03-04 13:09 ` Jason Gunthorpe
2024-02-29 8:42 ` [PATCH v2 7/7] mm/treewide: Drop pXd_large() peterx
2024-03-04 13:10 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304125658.GO9179@nvidia.com \
--to=jgg@nvidia$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=aneesh.kumar@kernel$(echo .)org \
--cc=kirill@shutemov$(echo .)name \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=muchun.song@linux$(echo .)dev \
--cc=naveen.n.rao@linux$(echo .)ibm.com \
--cc=npiggin@gmail$(echo .)com \
--cc=peterx@redhat$(echo .)com \
--cc=shy828301@gmail$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox