Subject: Re: [PATCH v2 4/7] mm/x86: Drop two unnecessary pud_leaf() definitions

From: Jason Gunthorpe <[email-masked]>
Date: Mon, 4 Mar 2024 09:03:34 -0400

On Thu, Feb 29, 2024 at 04:42:55PM +0800, [email-masked] wrote:
> From: Peter Xu <[email-masked]>
> 
> pud_leaf() has a fallback macro defined in include/linux/pgtable.h already.
> Drop the extra two for x86.
> 
> Cc: Thomas Gleixner <[email-masked]>
> Cc: Ingo Molnar <[email-masked]>
> Cc: Borislav Petkov <[email-masked]>
> Cc: Dave Hansen <[email-masked]>
> Cc: [email-masked]
> Signed-off-by: Peter Xu <[email-masked]>
> ---
>  arch/x86/include/asm/pgtable.h      | 1 -
>  include/asm-generic/pgtable-nopmd.h | 1 -
>  2 files changed, 2 deletions(-)

Reviewed-by: Jason Gunthorpe <[email-masked]>

> @@ -31,7 +31,6 @@ static inline int pud_none(pud_t pud)		{ return 0; }
>  static inline int pud_bad(pud_t pud)		{ return 0; }
>  static inline int pud_present(pud_t pud)	{ return 1; }
>  static inline int pud_user(pud_t pud)		{ return 0; }
> -static inline int pud_leaf(pud_t pud)		{ return 0; }

It would be nice to have a final patch making the signatures
consistent on all the arch inlines, it should return bool not int.

Jason