Subject: Re: [PATCH RFC 10/13] mm/gup: Merge pXd huge mapping checks

From: Jason Gunthorpe <[email-masked]>
Date: Thu, 7 Mar 2024 16:19:46 -0400

On Wed, Mar 06, 2024 at 06:41:44PM +0800, [email-masked] wrote:
> From: Peter Xu <[email-masked]>
> 
> Huge mapping checks in GUP are slightly redundant and can be simplified.
> 
> pXd_huge() now is the same as pXd_leaf().  pmd_trans_huge() and
> pXd_devmap() should both imply pXd_leaf(). Time to merge them into one.
> 
> Signed-off-by: Peter Xu <[email-masked]>
> ---
>  mm/gup.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Much better!

Reviewed-by: Jason Gunthorpe <[email-masked]>

Jason