From: Kees Cook <keescook@chromium•org>
To: Guenter Roeck <linux@roeck-us•net>
Cc: loongarch@lists•linux.dev, linux-doc@vger•kernel.org,
dri-devel@lists•freedesktop.org,
"Brendan Higgins" <brendan.higgins@linux•dev>,
linux-kselftest@vger•kernel.org, linux-riscv@lists•infradead.org,
"David Airlie" <airlied@gmail•com>,
"Arthur Grillo" <arthurgrillo@riseup•net>,
"Ville Syrjälä" <ville.syrjala@linux•intel.com>,
linux-arch@vger•kernel.org, linux-s390@vger•kernel.org,
"Daniel Diaz" <daniel.diaz@linaro•org>,
linux-sh@vger•kernel.org,
"Naresh Kamboju" <naresh.kamboju@linaro•org>,
"Maíra Canal" <mcanal@igalia•com>,
"Dan Carpenter" <dan.carpenter@linaro•org>,
netdev@lists•linux.dev, "Daniel Vetter" <daniel@ffwll•ch>,
"Arnd Bergmann" <arnd@arndb•de>,
"Maarten Lankhorst" <maarten.lankhorst@linux•intel.com>,
"Maxime Ripard" <mripard@kernel•org>,
"David Gow" <davidgow@google•com>,
linux-arm-kernel@lists•infradead.org, kunit-dev@googlegroups•com,
linux-parisc@vger•kernel.org, linux-kernel@vger•kernel.org,
"Thomas Zimmermann" <tzimmermann@suse•de>
Subject: Re: [PATCH 01/14] bug/kunit: Core support for suppressing warning backtraces
Date: Tue, 12 Mar 2024 15:00:58 -0700 [thread overview]
Message-ID: <202403121500.64A2C02@keescook> (raw)
In-Reply-To: <20240312170309.2546362-2-linux@roeck-us.net>
On Tue, Mar 12, 2024 at 10:02:56AM -0700, Guenter Roeck wrote:
> Some unit tests intentionally trigger warning backtraces by passing
> bad parameters to API functions. Such unit tests typically check the
> return value from those calls, not the existence of the warning backtrace.
>
> Such intentionally generated warning backtraces are neither desirable
> nor useful for a number of reasons.
> - They can result in overlooked real problems.
> - A warning that suddenly starts to show up in unit tests needs to be
> investigated and has to be marked to be ignored, for example by
> adjusting filter scripts. Such filters are ad-hoc because there is
> no real standard format for warnings. On top of that, such filter
> scripts would require constant maintenance.
>
> One option to address problem would be to add messages such as "expected
> warning backtraces start / end here" to the kernel log. However, that
> would again require filter scripts, it might result in missing real
> problematic warning backtraces triggered while the test is running, and
> the irrelevant backtrace(s) would still clog the kernel log.
>
> Solve the problem by providing a means to identify and suppress specific
> warning backtraces while executing test code.
>
> Cc: Dan Carpenter <dan.carpenter@linaro•org>
> Cc: Daniel Diaz <daniel.diaz@linaro•org>
> Cc: Naresh Kamboju <naresh.kamboju@linaro•org>
> Cc: Kees Cook <keescook@chromium•org>
> Signed-off-by: Guenter Roeck <linux@roeck-us•net>
Yup, this looks fine to me.
Reviewed-by: Kees Cook <keescook@chromium•org>
--
Kees Cook
next prev parent reply other threads:[~2024-03-12 22:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 17:02 [PATCH 00/14] Add support for suppressing warning backtraces Guenter Roeck
2024-03-12 17:02 ` [PATCH 01/14] bug/kunit: Core " Guenter Roeck
2024-03-12 22:00 ` Kees Cook [this message]
2024-03-12 17:02 ` [PATCH 02/14] kunit: bug: Count suppressed " Guenter Roeck
2024-03-12 22:02 ` Kees Cook
2024-03-12 17:02 ` [PATCH 03/14] kunit: Add test cases for backtrace warning suppression Guenter Roeck
2024-03-12 22:02 ` Kees Cook
2024-03-12 17:02 ` [PATCH 04/14] kunit: Add documentation for warning backtrace suppression API Guenter Roeck
2024-03-12 22:03 ` Kees Cook
2024-03-12 17:03 ` [PATCH 05/14] drm: Suppress intentional warning backtraces in scaling unit tests Guenter Roeck
2024-03-12 17:03 ` [PATCH 06/14] net: kunit: Suppress lock warning noise at end of dev_addr_lists tests Guenter Roeck
2024-03-12 17:03 ` [PATCH 07/14] x86: Add support for suppressing warning backtraces Guenter Roeck
2024-03-12 17:03 ` [PATCH 08/14] arm64: " Guenter Roeck
2024-03-12 17:03 ` [PATCH 09/14] loongarch: " Guenter Roeck
2024-03-12 17:03 ` [PATCH 10/14] parisc: " Guenter Roeck
2024-03-15 11:45 ` Helge Deller
2024-03-12 17:03 ` [PATCH 11/14] s390: " Guenter Roeck
2024-03-14 7:57 ` Geert Uytterhoeven
2024-03-14 13:54 ` Guenter Roeck
2024-03-12 17:03 ` [PATCH 12/14] sh: " Guenter Roeck
2024-03-12 17:03 ` [PATCH 13/14] riscv: " Guenter Roeck
2024-03-12 17:03 ` [PATCH 14/14] powerpc: " Guenter Roeck
2024-03-13 7:39 ` [PATCH 00/14] " Dan Carpenter
2024-03-14 7:19 ` Naresh Kamboju
2024-03-14 13:36 ` Geert Uytterhoeven
2024-03-14 14:37 ` Guenter Roeck
2024-03-14 15:02 ` Maxime Ripard
2024-03-14 15:29 ` Guenter Roeck
2024-03-16 16:16 ` Guenter Roeck
2024-03-18 3:24 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202403121500.64A2C02@keescook \
--to=keescook@chromium$(echo .)org \
--cc=airlied@gmail$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=arthurgrillo@riseup$(echo .)net \
--cc=brendan.higgins@linux$(echo .)dev \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=daniel.diaz@linaro$(echo .)org \
--cc=daniel@ffwll$(echo .)ch \
--cc=davidgow@google$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=kunit-dev@googlegroups$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=loongarch@lists$(echo .)linux.dev \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=mcanal@igalia$(echo .)com \
--cc=mripard@kernel$(echo .)org \
--cc=naresh.kamboju@linaro$(echo .)org \
--cc=netdev@lists$(echo .)linux.dev \
--cc=tzimmermann@suse$(echo .)de \
--cc=ville.syrjala@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox