From: Herve Codina <herve.codina@bootlin•com>
To: Michael Ellerman <mpe@ellerman•id.au>
Cc: Andrew Lunn <andrew@lunn•ch>,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
Vadim Fedorenko <vadim.fedorenko@linux•dev>,
Ratheesh Kannoth <rkannoth@marvell•com>,
Yury Norov <yury.norov@gmail•com>,
netdev@vger•kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes•dk>,
linux-kernel@vger•kernel.org, Eric Dumazet <edumazet@google•com>,
Mark Brown <broonie@kernel•org>,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
linuxppc-dev@lists•ozlabs.org,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH v7 1/5] net: wan: Add support for QMC HDLC
Date: Thu, 14 Mar 2024 08:12:00 +0100 [thread overview]
Message-ID: <20240314081200.5af62fab@bootlin.com> (raw)
In-Reply-To: <87ttl93f7i.fsf@mail.lhotse>
Hi Michael,
On Thu, 14 Mar 2024 10:05:37 +1100
Michael Ellerman <mpe@ellerman•id.au> wrote:
> Hi Herve,
>
> Herve Codina <herve.codina@bootlin•com> writes:
...
> This breaks when building as a module (eg. ppc32_allmodconfig):
>
> In file included from ../include/linux/device/driver.h:21,
> from ../include/linux/device.h:32,
> from ../include/linux/dma-mapping.h:8,
> from ../drivers/net/wan/fsl_qmc_hdlc.c:13:
> ../drivers/net/wan/fsl_qmc_hdlc.c:405:25: error: ‘qmc_hdlc_driver’ undeclared here (not in a function); did you mean ‘qmc_hdlc_probe’?
> 405 | MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
> | ^~~~~~~~~~~~~~~
>
>
> IIUIC it should be pointing to the table, not the driver, so:
>
> diff --git a/drivers/net/wan/fsl_qmc_hdlc.c b/drivers/net/wan/fsl_qmc_hdlc.c
> index 5fd7ed325f5b..705c3681fb92 100644
> --- a/drivers/net/wan/fsl_qmc_hdlc.c
> +++ b/drivers/net/wan/fsl_qmc_hdlc.c
> @@ -402,7 +402,7 @@ static const struct of_device_id qmc_hdlc_id_table[] = {
> { .compatible = "fsl,qmc-hdlc" },
> {} /* sentinel */
> };
> -MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
> +MODULE_DEVICE_TABLE(of, qmc_hdlc_id_table);
>
> static struct platform_driver qmc_hdlc_driver = {
> .driver = {
>
>
> Which then builds correctly.
My bad, I missed that one.
I fully agree with your modification.
Do you want me to make a patch (copy/paste of your proposed modification)
or do you plan to send the patch on your side ?
Best regards,
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-03-14 7:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 11:39 [PATCH v7 0/5] Add support for QMC HDLC Herve Codina
2024-03-07 11:39 ` [PATCH v7 1/5] net: wan: " Herve Codina
2024-03-13 23:05 ` Michael Ellerman
2024-03-14 7:12 ` Herve Codina [this message]
2024-03-14 10:51 ` Michael Ellerman
2024-03-07 11:39 ` [PATCH v7 2/5] MAINTAINERS: Add the Freescale QMC HDLC driver entry Herve Codina
2024-03-07 11:39 ` [PATCH v7 3/5] lib/bitmap: Introduce bitmap_scatter() and bitmap_gather() helpers Herve Codina
2024-03-07 11:39 ` [PATCH v7 4/5] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support Herve Codina
2024-03-07 11:39 ` [PATCH v7 5/5] net: wan: fsl_qmc_hdlc: Add framer support Herve Codina
2024-03-11 21:11 ` [PATCH v7 0/5] Add support for QMC HDLC Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240314081200.5af62fab@bootlin.com \
--to=herve.codina@bootlin$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=broonie@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@rasmusvillemoes$(echo .)dk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rkannoth@marvell$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
--cc=yury.norov@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox