Subject: Re: [PATCH v3 04/12] mm: Introduce vma_pgtable_walk_{begin|end}()

From: Jason Gunthorpe <[email-masked]>
Date: Fri, 22 Mar 2024 09:27:42 -0300

On Thu, Mar 21, 2024 at 06:07:54PM -0400, [email-masked] wrote:
> From: Peter Xu <[email-masked]>
> 
> Introduce per-vma begin()/end() helpers for pgtable walks.  This is a
> preparation work to merge hugetlb pgtable walkers with generic mm.
> 
> The helpers need to be called before and after a pgtable walk, will start
> to be needed if the pgtable walker code supports hugetlb pages.  It's a
> hook point for any type of VMA, but for now only hugetlb uses it to
> stablize the pgtable pages from getting away (due to possible pmd
> unsharing).
> 
> Reviewed-by: Christoph Hellwig <[email-masked]>
> Reviewed-by: Muchun Song <[email-masked]>
> Signed-off-by: Peter Xu <[email-masked]>
> ---
>  include/linux/mm.h |  3 +++
>  mm/memory.c        | 12 ++++++++++++
>  2 files changed, 15 insertions(+)

is_vm_hugetlb_page(vma) seems weirdly named. Regardless

Reviewed-by: Jason Gunthorpe <[email-masked]>

Jason