From: Bjorn Helgaas <helgaas@kernel•org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro•org>
Cc: "Krzysztof Wilczyński" <kw@linux•com>,
"Vignesh Raghavendra" <vigneshr@ti•com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext•com>,
imx@lists•linux.dev, linux-pci@vger•kernel.org,
"Lorenzo Pieralisi" <lpieralisi@kernel•org>,
"Minghuan Lian" <minghuan.Lian@nxp•com>,
"Thierry Reding" <thierry.reding@gmail•com>,
"Fabio Estevam" <festevam@gmail•com>,
"Marek Vasut" <marek.vasut+renesas@gmail•com>,
"Kishon Vijay Abraham I" <kishon@kernel•org>,
"Rob Herring" <robh@kernel•org>,
"Jesper Nilsson" <jesper.nilsson@axis•com>,
linux-tegra@vger•kernel.org, linux-arm-kernel@axis•com,
"Jonathan Hunter" <jonathanh@nvidia•com>,
linux-arm-kernel@lists•infradead.org,
"Siddharth Vadapalli" <s-vadapalli@ti•com>,
"Richard Zhu" <hongxing.zhu@nxp•com>,
"Srikanth Thokala" <srikanth.thokala@intel•com>,
linux-arm-msm@vger•kernel.org,
"Sascha Hauer" <s.hauer@pengutronix•de>,
linuxppc-dev@lists•ozlabs.org,
"Bjorn Helgaas" <bhelgaas@google•com>,
linux-omap@vger•kernel.org, "Mingkai Hu" <mingkai.hu@nxp•com>,
"Roy Zang" <roy.zang@nxp•com>,
"Niklas Cassel" <cassel@kernel•org>,
"Jingoo Han" <jingoohan1@gmail•com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas•com>,
linux-kernel@vger•kernel.org, mhi@lists•linux.dev,
linux-renesas-soc@vger•kernel.org,
"Masami Hiramatsu" <mhiramat@kernel•org>,
"Pengutronix Kernel Team" <kernel@pengutronix•de>,
"Shawn Guo" <shawnguo@kernel•org>,
"Lucas Stach" <l.stach@pengutronix•de>
Subject: Re: [PATCH 2/5] PCI: endpoint: Introduce 'epc_deinit' event and notify the EPF drivers
Date: Tue, 11 Jun 2024 17:06:40 -0500 [thread overview]
Message-ID: <20240611220640.GA1001976@bhelgaas> (raw)
In-Reply-To: <20240606-pci-deinit-v1-2-4395534520dc@linaro.org>
On Thu, Jun 06, 2024 at 12:56:35PM +0530, Manivannan Sadhasivam wrote:
> As like the 'epc_init' event, that is used to signal the EPF drivers about
> the EPC initialization, let's introduce 'epc_deinit' event that is used to
> signal EPC deinitialization.
>
> The EPC deinitialization applies only when any sort of fundamental reset
> is supported by the endpoint controller as per the PCIe spec.
>
> Reference: PCIe Base spec v5.0, sections 4.2.4.9.1 and 6.6.1.
PCIe r6.0, sec 4.2.5.9.1 and 6.6.1.
(Not 4.2.4.9.1, which no longer exists in r6.x)
> Currently, some EPC drivers like pcie-qcom-ep and pcie-tegra194 support
> PERST# as the fundamental reset. So the 'deinit' event will be notified to
> the EPF drivers when PERST# assert happens in the above mentioned EPC
> drivers.
>
> The EPF drivers, on receiving the event through the epc_deinit() callback
> should reset the EPF state machine and also cleanup any configuration that
> got affected by the fundamental reset like BAR, DMA etc...
>
> This change also warrants skipping the cleanups in unbind() if already done
> in epc_deinit().
>
> Reviewed-by: Niklas Cassel <cassel@kernel•org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro•org>
next prev parent reply other threads:[~2024-06-11 22:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 7:26 [PATCH 0/5] PCI: endpoint: Add EPC 'deinit' event and dw_pcie_ep_linkdown() API Manivannan Sadhasivam
2024-06-06 7:26 ` [PATCH 1/5] PCI: dwc: ep: Remove dw_pcie_ep_init_notify() wrapper Manivannan Sadhasivam
2024-06-06 10:29 ` Siddharth Vadapalli
2024-06-06 21:08 ` Frank Li
2024-06-07 9:21 ` Niklas Cassel
2024-06-06 7:26 ` [PATCH 2/5] PCI: endpoint: Introduce 'epc_deinit' event and notify the EPF drivers Manivannan Sadhasivam
2024-06-06 10:38 ` Siddharth Vadapalli
2024-06-06 21:10 ` Frank Li
2024-06-11 22:06 ` Bjorn Helgaas [this message]
2024-06-12 4:36 ` Manivannan Sadhasivam
2024-06-13 15:42 ` Markus Elfring
2024-06-06 7:26 ` [PATCH 3/5] PCI: dwc: ep: Add a generic dw_pcie_ep_linkdown() API to handle Link Down event Manivannan Sadhasivam
2024-06-06 10:52 ` Siddharth Vadapalli
2024-06-07 9:21 ` Niklas Cassel
2024-06-06 7:26 ` [PATCH 4/5] PCI: qcom-ep: Use the " Manivannan Sadhasivam
2024-06-07 9:22 ` Niklas Cassel
2024-06-06 7:26 ` [PATCH 5/5] PCI: layerscape-ep: " Manivannan Sadhasivam
2024-06-06 21:06 ` Frank Li
2024-06-07 9:22 ` Niklas Cassel
2024-06-07 9:31 ` [PATCH 0/5] PCI: endpoint: Add EPC 'deinit' event and dw_pcie_ep_linkdown() API Niklas Cassel
2024-06-07 12:06 ` Manivannan Sadhasivam
2024-06-10 6:53 ` Manivannan Sadhasivam
2024-06-21 19:37 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611220640.GA1001976@bhelgaas \
--to=helgaas@kernel$(echo .)org \
--cc=bhelgaas@google$(echo .)com \
--cc=cassel@kernel$(echo .)org \
--cc=festevam@gmail$(echo .)com \
--cc=hayashi.kunihiko@socionext$(echo .)com \
--cc=hongxing.zhu@nxp$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=jesper.nilsson@axis$(echo .)com \
--cc=jingoohan1@gmail$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=kishon@kernel$(echo .)org \
--cc=kw@linux$(echo .)com \
--cc=l.stach@pengutronix$(echo .)de \
--cc=linux-arm-kernel@axis$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lpieralisi@kernel$(echo .)org \
--cc=manivannan.sadhasivam@linaro$(echo .)org \
--cc=marek.vasut+renesas@gmail$(echo .)com \
--cc=mhi@lists$(echo .)linux.dev \
--cc=mhiramat@kernel$(echo .)org \
--cc=minghuan.Lian@nxp$(echo .)com \
--cc=mingkai.hu@nxp$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=roy.zang@nxp$(echo .)com \
--cc=s-vadapalli@ti$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=srikanth.thokala@intel$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=vigneshr@ti$(echo .)com \
--cc=yoshihiro.shimoda.uh@renesas$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox