Subject: Re: [PATCH] powerpc: Fixed duplicate copying in the early boot.

From: Segher Boessenkool <[email-masked]>
Date: Mon, 17 Jun 2024 11:13:36 -0500

Hi!

On Mon, Jun 17, 2024 at 10:35:09AM +0800, Jinglin Wen wrote:
> +	cmplwi	cr0,r4,0	/* runtime base addr is zero */

Just write
   cmpwi r4,0

cr0 is the default, also implicit in many other instructions, please
don't clutter the source code.  All the extra stuff makes you miss the
things that do matter!

The "l" is unnecessary, you only care about equality here after all.

Should it not be cmpdi here, though?

Segher