public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium•org>
To: Mike Rapoport <rppt@kernel•org>
Cc: Andrew Morton <akpm@linux-foundation•org>,
	Andreas Larsson <andreas@gaisler•com>,
	Andy Lutomirski <luto@kernel•org>,
	Ard Biesheuvel <ardb@kernel•org>, Arnd Bergmann <arnd@arndb•de>,
	Borislav Petkov <bp@alien8•de>, Brian Cain <bcain@quicinc•com>,
	Catalin Marinas <catalin.marinas@arm•com>,
	Christoph Hellwig <hch@infradead•org>,
	Christophe Leroy <christophe.leroy@csgroup•eu>,
	Dave Hansen <dave.hansen@linux•intel.com>,
	Dinh Nguyen <dinguyen@kernel•org>,
	Geert Uytterhoeven <geert@linux-m68k•org>,
	Guo Ren <guoren@kernel•org>, Helge Deller <deller@gmx•de>,
	Huacai Chen <chenhuacai@kernel•org>,
	Ingo Molnar <mingo@redhat•com>,
	Johannes Berg <johannes@sipsolutions•net>,
	John Paul Adrian Glaubitz <glaubitz@physik•fu-berlin.de>,
	Kent Overstreet <kent.overstreet@linux•dev>,
	"Liam R. Howlett" <Liam.Howlett@oracle•com>,
	Luis Chamberlain <mcgrof@kernel•org>,
	Mark Rutland <mark.rutland@arm•com>,
	Masami Hiramatsu <mhiramat@kernel•org>,
	Matt Turner <mattst88@gmail•com>,
	Max Filippov <jcmvbkbc@gmail•com>,
	Michael Ellerman <mpe@ellerman•id.au>,
	Michal Simek <monstr@monstr•eu>, Oleg Nesterov <oleg@redhat•com>,
	Palmer Dabbelt <palmer@dabbelt•com>,
	Peter Zijlstra <peterz@infradead•org>,
	Richard Weinberger <richard@nod•at>,
	Russell King <linux@armlinux•org.uk>, Song Liu <song@kernel•org>,
	Stafford Horne <shorne@gmail•com>,
	Steven Rostedt <rostedt@goodmis•org>,
	Thomas Bogendoerfer <tsbogend@alpha•franken.de>,
	Thomas Gleixner <tglx@linutronix•de>,
	Uladzislau Rezki <urezki@gmail•com>,
	Vineet Gupta <vgupta@kernel•org>, Will Deacon <will@kernel•org>,
	bpf@vger•kernel.org, linux-alpha@vger•kernel.org,
	linux-arch@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
	linux-csky@vger•kernel.org, linux-hexagon@vger•kernel.org,
	linux-kernel@vger•kernel.org, linux-m68k@lists•linux-m68k.org,
	linux-mips@vger•kernel.org, linux-mm@kvack•org,
	linux-modules@vger•kernel.org, linux-openrisc@vger•kernel.org,
	linux-parisc@vger•kernel.org, linux-riscv@lists•infradead.org,
	linux-sh@vger•kernel.org, linux-snps-arc@lists•infradead.org,
	linux-trace-kernel@vger•kernel.org, linux-um@lists•infradead.org,
	linuxppc-dev@lists•ozlabs.org, loongarch@lists•linux.dev,
	sparclinux@vger•kernel.org, x86@kernel•org
Subject: Bisected: [PATCH v5 8/8] x86/module: enable ROX caches for module text
Date: Thu, 10 Oct 2024 17:30:33 +0900	[thread overview]
Message-ID: <20241010083033.GA1279924@google.com> (raw)
In-Reply-To: <20241009180816.83591-9-rppt@kernel.org>

On (24/10/09 21:08), Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@kernel•org>
> 
> Enable execmem's cache of PMD_SIZE'ed pages mapped as ROX for module
> text allocations.
> 

With this modprobe disappoints kmemleak

[   12.700128] kmemleak: Found object by alias at 0xffffffffa000a000
[   12.702179] CPU: 5 UID: 0 PID: 410 Comm: modprobe Tainted: G                 N 6.12.0-rc2+ #760
[   12.704656] Tainted: [N]=TEST
[   12.705526] Call Trace:
[   12.706250]  <TASK>
[   12.706888]  dump_stack_lvl+0x3e/0xdb
[   12.707961]  __find_and_get_object+0x100/0x110
[   12.709256]  kmemleak_no_scan+0x2e/0xb0
[   12.710354]  kmemleak_load_module+0xad/0xe0
[   12.711557]  load_module+0x2391/0x45a0
[   12.712507]  __se_sys_finit_module+0x4e0/0x7a0
[   12.713599]  do_syscall_64+0x54/0xf0
[   12.714477]  ? irqentry_exit_to_user_mode+0x33/0x100
[   12.715696]  entry_SYSCALL_64_after_hwframe+0x4b/0x53
[   12.716931] RIP: 0033:0x7fc7af51f059
[   12.717816] Code: 08 89 e8 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 8f 1d 0d 00 f7 d8 64 89 01 48
[   12.722324] RSP: 002b:00007ffc1d0b0c18 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
[   12.724173] RAX: ffffffffffffffda RBX: 00005618a9439b20 RCX: 00007fc7af51f059
[   12.725884] RDX: 0000000000000000 RSI: 000056187aea098b RDI: 0000000000000003
[   12.727617] RBP: 0000000000000000 R08: 0000000000000060 R09: 00005618a943af60
[   12.729361] R10: 0000000000000038 R11: 0000000000000246 R12: 000056187aea098b
[   12.731101] R13: 0000000000040000 R14: 00005618a9439ac0 R15: 0000000000000000
[   12.732814]  </TASK>
[   12.733362] kmemleak: Object 0xffffffffa0000000 (size 2097152):
[   12.734800] kmemleak:   comm "modprobe", pid 410, jiffies 4294880489
[   12.736334] kmemleak:   min_count = 2
[   12.737228] kmemleak:   count = 0
[   12.738043] kmemleak:   flags = 0x5
[   12.738917] kmemleak:   checksum = 0
[   12.739783] kmemleak:   backtrace:
[   12.740606]  kmemleak_vmalloc+0x29/0xc0
[   12.741532]  kasan_alloc_module_shadow+0xbe/0xe0
[   12.742649]  execmem_vmalloc+0x116/0x220
[   12.743596]  execmem_alloc+0xfb/0x3d0
[   12.744479]  load_module+0x1e84/0x45a0
[   12.745383]  __se_sys_finit_module+0x4e0/0x7a0
[   12.746452]  do_syscall_64+0x54/0xf0
[   12.747319]  entry_SYSCALL_64_after_hwframe+0x4b/0x53
[   12.748772] kmemleak: Not scanning unknown object at 0xffffffffa000a000
[   12.750364] CPU: 5 UID: 0 PID: 410 Comm: modprobe Tainted: G                 N 6.12.0-rc2+ #760
[   12.752441] Tainted: [N]=TEST
[   12.753165] Call Trace:
[   12.753760]  <TASK>
[   12.754279]  dump_stack_lvl+0x3e/0xdb
[   12.755165]  kmemleak_load_module+0xad/0xe0
[   12.756165]  load_module+0x2391/0x45a0
[   12.757068]  __se_sys_finit_module+0x4e0/0x7a0
[   12.758135]  do_syscall_64+0x54/0xf0
[   12.759099]  ? irqentry_exit_to_user_mode+0x33/0x100
[   12.760292]  entry_SYSCALL_64_after_hwframe+0x4b/0x53
[   12.761508] RIP: 0033:0x7fc7af51f059
[   12.762372] Code: 08 89 e8 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 8f 1d 0d 00 f7 d8 64 89 01 48
[   12.772361] RSP: 002b:00007ffc1d0b0c18 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
[   12.774957] RAX: ffffffffffffffda RBX: 00005618a9439b20 RCX: 00007fc7af51f059
[   12.776635] RDX: 0000000000000000 RSI: 000056187aea098b RDI: 0000000000000003
[   12.778283] RBP: 0000000000000000 R08: 0000000000000060 R09: 00005618a943af60
[   12.779949] R10: 0000000000000038 R11: 0000000000000246 R12: 000056187aea098b
[   12.781619] R13: 0000000000040000 R14: 00005618a9439ac0 R15: 0000000000000000
[   12.783319]  </TASK>


  reply	other threads:[~2024-10-10  8:30 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 18:08 [PATCH v5 0/8] x86/module: use large ROX pages for text allocations Mike Rapoport
2024-10-09 18:08 ` [PATCH v5 1/8] mm: vmalloc: group declarations depending on CONFIG_MMU together Mike Rapoport
2024-10-10  6:54   ` Christoph Hellwig
2024-10-09 18:08 ` [PATCH v5 2/8] mm: vmalloc: don't account for number of nodes for HUGE_VMAP allocations Mike Rapoport
2024-10-10  6:54   ` Christoph Hellwig
2024-10-09 18:08 ` [PATCH v5 3/8] asm-generic: introduce text-patching.h Mike Rapoport
2024-10-10  6:55   ` Christoph Hellwig
2024-10-10  7:22   ` Geert Uytterhoeven
2024-10-10  8:04   ` Arnd Bergmann
2024-10-09 18:08 ` [PATCH v5 4/8] module: prepare to handle ROX allocations for text Mike Rapoport
2024-10-09 22:23   ` Song Liu
2024-10-10  5:43     ` Mike Rapoport
2024-10-10 17:18       ` Song Liu
2024-10-09 18:08 ` [PATCH v5 5/8] arch: introduce set_direct_map_valid_noflush() Mike Rapoport
2024-10-10  6:56   ` Christoph Hellwig
2024-10-09 18:08 ` [PATCH v5 6/8] x86/module: perpare module loading for ROX allocations of text Mike Rapoport
2024-10-10  6:57   ` Christoph Hellwig
2024-10-10 22:54   ` Nathan Chancellor
2024-10-11 12:58     ` Mike Rapoport
2024-10-15  8:29       ` Nathan Chancellor
2024-10-09 18:08 ` [PATCH v5 7/8] execmem: add support for cache of large ROX pages Mike Rapoport
2024-10-09 20:24   ` Andrew Morton
2024-10-10  9:29     ` Mike Rapoport
2024-10-10  6:58   ` Christoph Hellwig
2024-10-10 12:57     ` Mike Rapoport
2024-10-11  7:46       ` Christoph Hellwig
2024-10-13  8:43         ` Mike Rapoport
2024-10-14  3:26           ` Andrew Morton
2024-10-14 19:16             ` Luis Chamberlain
2024-10-15  4:09               ` Luis Chamberlain
2024-10-15  5:54                 ` Mike Rapoport
2024-10-15 20:11                   ` Luis Chamberlain
2024-10-16 10:40                     ` Mike Rapoport
2024-10-16 23:58                       ` Luis Chamberlain
2024-10-14  5:55           ` Christoph Hellwig
2024-10-14 13:07             ` Mike Rapoport
2024-10-10 18:35   ` Kees Bakker
2024-10-09 18:08 ` [PATCH v5 8/8] x86/module: enable ROX caches for module text Mike Rapoport
2024-10-10  8:30   ` Sergey Senozhatsky [this message]
2024-10-10 15:20     ` Bisected: " Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241010083033.GA1279924@google.com \
    --to=senozhatsky@chromium$(echo .)org \
    --cc=Liam.Howlett@oracle$(echo .)com \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=andreas@gaisler$(echo .)com \
    --cc=ardb@kernel$(echo .)org \
    --cc=arnd@arndb$(echo .)de \
    --cc=bcain@quicinc$(echo .)com \
    --cc=bp@alien8$(echo .)de \
    --cc=bpf@vger$(echo .)kernel.org \
    --cc=catalin.marinas@arm$(echo .)com \
    --cc=chenhuacai@kernel$(echo .)org \
    --cc=christophe.leroy@csgroup$(echo .)eu \
    --cc=dave.hansen@linux$(echo .)intel.com \
    --cc=deller@gmx$(echo .)de \
    --cc=dinguyen@kernel$(echo .)org \
    --cc=geert@linux-m68k$(echo .)org \
    --cc=glaubitz@physik$(echo .)fu-berlin.de \
    --cc=guoren@kernel$(echo .)org \
    --cc=hch@infradead$(echo .)org \
    --cc=jcmvbkbc@gmail$(echo .)com \
    --cc=johannes@sipsolutions$(echo .)net \
    --cc=kent.overstreet@linux$(echo .)dev \
    --cc=linux-alpha@vger$(echo .)kernel.org \
    --cc=linux-arch@vger$(echo .)kernel.org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-csky@vger$(echo .)kernel.org \
    --cc=linux-hexagon@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-m68k@lists$(echo .)linux-m68k.org \
    --cc=linux-mips@vger$(echo .)kernel.org \
    --cc=linux-mm@kvack$(echo .)org \
    --cc=linux-modules@vger$(echo .)kernel.org \
    --cc=linux-openrisc@vger$(echo .)kernel.org \
    --cc=linux-parisc@vger$(echo .)kernel.org \
    --cc=linux-riscv@lists$(echo .)infradead.org \
    --cc=linux-sh@vger$(echo .)kernel.org \
    --cc=linux-snps-arc@lists$(echo .)infradead.org \
    --cc=linux-trace-kernel@vger$(echo .)kernel.org \
    --cc=linux-um@lists$(echo .)infradead.org \
    --cc=linux@armlinux$(echo .)org.uk \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=loongarch@lists$(echo .)linux.dev \
    --cc=luto@kernel$(echo .)org \
    --cc=mark.rutland@arm$(echo .)com \
    --cc=mattst88@gmail$(echo .)com \
    --cc=mcgrof@kernel$(echo .)org \
    --cc=mhiramat@kernel$(echo .)org \
    --cc=mingo@redhat$(echo .)com \
    --cc=monstr@monstr$(echo .)eu \
    --cc=mpe@ellerman$(echo .)id.au \
    --cc=oleg@redhat$(echo .)com \
    --cc=palmer@dabbelt$(echo .)com \
    --cc=peterz@infradead$(echo .)org \
    --cc=richard@nod$(echo .)at \
    --cc=rostedt@goodmis$(echo .)org \
    --cc=rppt@kernel$(echo .)org \
    --cc=shorne@gmail$(echo .)com \
    --cc=song@kernel$(echo .)org \
    --cc=sparclinux@vger$(echo .)kernel.org \
    --cc=tglx@linutronix$(echo .)de \
    --cc=tsbogend@alpha$(echo .)franken.de \
    --cc=urezki@gmail$(echo .)com \
    --cc=vgupta@kernel$(echo .)org \
    --cc=will@kernel$(echo .)org \
    --cc=x86@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox