From: Sami Tolvanen <samitolvanen@google•com>
To: Matthew Maurer <mmaurer@google•com>
Cc: "Michael Ellerman" <mpe@ellerman•id.au>,
"Nicholas Piggin" <npiggin@gmail•com>,
"Christophe Leroy" <christophe.leroy@csgroup•eu>,
"Naveen N Rao" <naveen@kernel•org>,
"Madhavan Srinivasan" <maddy@linux•ibm.com>,
"Luis Chamberlain" <mcgrof@kernel•org>,
"Petr Pavlu" <petr.pavlu@suse•com>,
"Daniel Gomez" <da.gomez@samsung•com>,
"Masahiro Yamada" <masahiroy@kernel•org>,
"Nathan Chancellor" <nathan@kernel•org>,
"Nicolas Schier" <nicolas@fjasle•eu>,
"Miguel Ojeda" <ojeda@kernel•org>,
"Alex Gaynor" <alex.gaynor@gmail•com>,
"Boqun Feng" <boqun.feng@gmail•com>,
"Gary Guo" <gary@garyguo•net>,
"Björn Roy Baron" <bjorn3_gh@protonmail•com>,
"Benno Lossin" <benno.lossin@proton•me>,
"Andreas Hindborg" <a.hindborg@kernel•org>,
"Alice Ryhl" <aliceryhl@google•com>,
"Trevor Gross" <tmgross@umich•edu>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
linux-modules@vger•kernel.org, linux-kbuild@vger•kernel.org,
rust-for-linux@vger•kernel.org
Subject: Re: [PATCH v7 2/3] modpost: Produce extended MODVERSIONS information
Date: Thu, 24 Oct 2024 23:01:52 +0000 [thread overview]
Message-ID: <20241024230152.GB1382412@google.com> (raw)
In-Reply-To: <20241023-extended-modversions-v7-2-339787b43373@google.com>
On Wed, Oct 23, 2024 at 02:31:29AM +0000, Matthew Maurer wrote:
> Generate both the existing modversions format and the new extended one
> when running modpost. Presence of this metadata in the final .ko is
> guarded by CONFIG_EXTENDED_MODVERSIONS.
>
> We no longer generate an error on long symbols in modpost if
> CONFIG_EXTENDED_MODVERSIONS is set, as they can now be appropriately
> encoded in the extended section. These symbols will be skipped in the
> previous encoding. An error will still be generated if
> CONFIG_EXTENDED_MODVERSIONS is not set.
>
> Signed-off-by: Matthew Maurer <mmaurer@google•com>
Thanks for fixing this, LGTM.
Reviewed-by: Sami Tolvanen <samitolvanen@google•com>
Sami
next prev parent reply other threads:[~2024-10-24 23:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 2:31 [PATCH v7 0/3] Extended MODVERSIONS Support Matthew Maurer
2024-10-23 2:31 ` [PATCH v7 1/3] modules: Support extended MODVERSIONS info Matthew Maurer
2024-10-24 23:00 ` Sami Tolvanen
2024-10-25 11:14 ` Michael Ellerman
2024-10-25 15:17 ` Matthew Maurer
2024-10-30 5:35 ` Michael Ellerman
2024-10-23 2:31 ` [PATCH v7 2/3] modpost: Produce extended MODVERSIONS information Matthew Maurer
2024-10-24 23:01 ` Sami Tolvanen [this message]
2024-10-23 2:31 ` [PATCH v7 3/3] rust: Use gendwarfksyms + extended modversions for CONFIG_MODVERSIONS Matthew Maurer
2024-10-24 23:06 ` Sami Tolvanen
2024-10-24 23:07 ` [PATCH v7 0/3] Extended MODVERSIONS Support Sami Tolvanen
2024-10-25 4:53 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024230152.GB1382412@google.com \
--to=samitolvanen@google$(echo .)com \
--cc=a.hindborg@kernel$(echo .)org \
--cc=alex.gaynor@gmail$(echo .)com \
--cc=aliceryhl@google$(echo .)com \
--cc=benno.lossin@proton$(echo .)me \
--cc=bjorn3_gh@protonmail$(echo .)com \
--cc=boqun.feng@gmail$(echo .)com \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=da.gomez@samsung$(echo .)com \
--cc=gary@garyguo$(echo .)net \
--cc=linux-kbuild@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-modules@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=masahiroy@kernel$(echo .)org \
--cc=mcgrof@kernel$(echo .)org \
--cc=mmaurer@google$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=nathan@kernel$(echo .)org \
--cc=naveen@kernel$(echo .)org \
--cc=nicolas@fjasle$(echo .)eu \
--cc=npiggin@gmail$(echo .)com \
--cc=ojeda@kernel$(echo .)org \
--cc=petr.pavlu@suse$(echo .)com \
--cc=rust-for-linux@vger$(echo .)kernel.org \
--cc=tmgross@umich$(echo .)edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox