From: Jakub Kicinski <kuba@kernel•org>
To: Caleb Sander Mateos <csander@purestorage•com>
Cc: "Tal Gilboa" <talgi@nvidia•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Simon Horman" <horms@kernel•org>,
"Jonathan Corbet" <corbet@lwn•net>,
"Shay Agroskin" <shayagr@amazon•com>,
"Arthur Kiyanovski" <akiyano@amazon•com>,
"David Arinzon" <darinzon@amazon•com>,
"Noam Dagan" <ndagan@amazon•com>,
"Saeed Bishara" <saeedb@amazon•com>,
"Andrew Lunn" <andrew+netdev@lunn•ch>,
"Florian Fainelli" <florian.fainelli@broadcom•com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom•com>,
"Michael Chan" <michael.chan@broadcom•com>,
"Doug Berger" <opendmb@gmail•com>,
"Claudiu Manoil" <claudiu.manoil@nxp•com>,
"Vladimir Oltean" <vladimir.oltean@nxp•com>,
"Jian Shen" <shenjian15@huawei•com>,
"Salil Mehta" <salil.mehta@huawei•com>,
"Jijie Shao" <shaojijie@huawei•com>,
"Tony Nguyen" <anthony.l.nguyen@intel•com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel•com>,
"Sunil Goutham" <sgoutham@marvell•com>,
"Geetha sowjanya" <gakula@marvell•com>,
"Subbaraya Sundeep" <sbhatta@marvell•com>,
hariprasad <hkelam@marvell•com>, "Felix Fietkau" <nbd@nbd•name>,
"Sean Wang" <sean.wang@mediatek•com>,
"Mark Lee" <Mark-MC.Lee@mediatek•com>,
"Lorenzo Bianconi" <lorenzo@kernel•org>,
"Matthias Brugger" <matthias.bgg@gmail•com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora•com>,
"Saeed Mahameed" <saeedm@nvidia•com>,
"Tariq Toukan" <tariqt@nvidia•com>,
"Leon Romanovsky" <leon@kernel•org>,
"Louis Peens" <louis.peens@corigine•com>,
"Shannon Nelson" <shannon.nelson@amd•com>,
"Brett Creeley" <brett.creeley@amd•com>,
"Michael S. Tsirkin" <mst@redhat•com>,
"Jason Wang" <jasowang@redhat•com>,
"Xuan Zhuo" <xuanzhuo@linux•alibaba.com>,
"Eugenio Pérez" <eperezma@redhat•com>,
"Roy Pledge" <Roy.Pledge@nxp•com>,
"Christophe Leroy" <christophe.leroy@csgroup•eu>,
netdev@vger•kernel.org, linux-doc@vger•kernel.org,
linux-kernel@vger•kernel.org, intel-wired-lan@lists•osuosl.org,
linux-arm-kernel@lists•infradead.org,
linux-mediatek@lists•infradead.org, linux-rdma@vger•kernel.org,
oss-drivers@corigine•com, virtualization@lists•linux.dev,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 2/2] dim: pass dim_sample to net_dim() by reference
Date: Wed, 30 Oct 2024 16:48:05 -0700 [thread overview]
Message-ID: <20241030164805.40408945@kernel.org> (raw)
In-Reply-To: <20241030194914.3268865-2-csander@purestorage.com>
On Wed, 30 Oct 2024 13:49:08 -0600 Caleb Sander Mateos wrote:
> net_dim() is currently passed a struct dim_sample argument by value.
> struct dim_sample is 24 bytes. Since this is greater 16 bytes, x86-64
> passes it on the stack. All callers have already initialized dim_sample
> on the stack, so passing it by value requires pushing a duplicated copy
> to the stack. Either witing to the stack and immediately reading it, or
> perhaps dereferencing addresses relative to the stack pointer in a chain
> of push instructions, seems to perform quite poorly.
Looks like patch 1 didn't get CCed to netdev. Please repost?
--
pw-bot: cr
parent reply other threads:[~2024-10-31 0:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20241030194914.3268865-2-csander@purestorage.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030164805.40408945@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=Mark-MC.Lee@mediatek$(echo .)com \
--cc=Roy.Pledge@nxp$(echo .)com \
--cc=akiyano@amazon$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=brett.creeley@amd$(echo .)com \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=csander@purestorage$(echo .)com \
--cc=darinzon@amazon$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eperezma@redhat$(echo .)com \
--cc=florian.fainelli@broadcom$(echo .)com \
--cc=gakula@marvell$(echo .)com \
--cc=hkelam@marvell$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jasowang@redhat$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lorenzo@kernel$(echo .)org \
--cc=louis.peens@corigine$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=nbd@nbd$(echo .)name \
--cc=ndagan@amazon$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=opendmb@gmail$(echo .)com \
--cc=oss-drivers@corigine$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=saeedb@amazon$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=salil.mehta@huawei$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=shannon.nelson@amd$(echo .)com \
--cc=shaojijie@huawei$(echo .)com \
--cc=shayagr@amazon$(echo .)com \
--cc=shenjian15@huawei$(echo .)com \
--cc=talgi@nvidia$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=vladimir.oltean@nxp$(echo .)com \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox