From: Herve Codina <herve.codina@bootlin•com>
To: Javier Carrasco <javier.carrasco.cruz@gmail•com>
Cc: Qiang Zhao <qiang.zhao@nxp•com>,
Christophe Leroy <christophe.leroy@csgroup•eu>,
linuxppc-dev@lists•ozlabs.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH] soc: fsl: cpm1: tsa: switch to for_each_available_child_of_node_scoped()
Date: Thu, 14 Nov 2024 08:14:31 +0100 [thread overview]
Message-ID: <20241114081431.23296fd9@bootlin.com> (raw)
In-Reply-To: <20241002-tsa-scoped-v1-1-ba6a6d657f82@gmail.com>
Hi Javier,
On Wed, 02 Oct 2024 22:21:51 +0200
Javier Carrasco <javier.carrasco.cruz@gmail•com> wrote:
> The non-scoped variant of this macro turns error-prone as soon as error
> paths are included, because explicit calls to of_node_put() are required
> to avoid leaking memory.
>
> Using its scoped counterpart simplifies the code by removing the need of
> explicit calls to of_node_put(), as they are automatically triggered as
> soon as the child node goes out of scope. Moreover, it is more robust as
> it accounts for new error paths without having to worry about
> decrementing the object's refcount.
>
> Note that the device_node is declared within the macro, and its explicit
> declaration can be dropped as well if it is not used anywhere else.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail•com>
> ---
> drivers/soc/fsl/qe/tsa.c | 28 ++++------------------------
> 1 file changed, 4 insertions(+), 24 deletions(-)
Acked-by: Herve Codina <herve.codina@bootlin•com>
Best regards,
Hervé
prev parent reply other threads:[~2024-11-14 7:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 20:21 [PATCH] soc: fsl: cpm1: tsa: switch to for_each_available_child_of_node_scoped() Javier Carrasco
2024-11-14 7:14 ` Herve Codina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241114081431.23296fd9@bootlin.com \
--to=herve.codina@bootlin$(echo .)com \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=javier.carrasco.cruz@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=qiang.zhao@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox