From: Jason Gunthorpe <jgg@nvidia•com>
To: Leon Romanovsky <leon@kernel•org>
Cc: Marek Szyprowski <m.szyprowski@samsung•com>,
Abdiel Janulgue <abdiel.janulgue@gmail•com>,
Alexander Potapenko <glider@google•com>,
Alex Gaynor <alex.gaynor@gmail•com>,
Andrew Morton <akpm@linux-foundation•org>,
Christoph Hellwig <hch@lst•de>,
Danilo Krummrich <dakr@kernel•org>,
iommu@lists•linux.dev, Jason Wang <jasowang@redhat•com>,
Jens Axboe <axboe@kernel•dk>, Joerg Roedel <joro@8bytes•org>,
Jonathan Corbet <corbet@lwn•net>, Juergen Gross <jgross@suse•com>,
kasan-dev@googlegroups•com, Keith Busch <kbusch@kernel•org>,
linux-block@vger•kernel.org, linux-doc@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-mm@kvack•org,
linux-nvme@lists•infradead.org, linuxppc-dev@lists•ozlabs.org,
linux-trace-kernel@vger•kernel.org,
Madhavan Srinivasan <maddy@linux•ibm.com>,
Masami Hiramatsu <mhiramat@kernel•org>,
Michael Ellerman <mpe@ellerman•id.au>,
"Michael S. Tsirkin" <mst@redhat•com>,
Miguel Ojeda <ojeda@kernel•org>,
Robin Murphy <robin.murphy@arm•com>,
rust-for-linux@vger•kernel.org, Sagi Grimberg <sagi@grimberg•me>,
Stefano Stabellini <sstabellini@kernel•org>,
Steven Rostedt <rostedt@goodmis•org>,
virtualization@lists•linux.dev, Will Deacon <will@kernel•org>,
xen-devel@lists•xenproject.org
Subject: Re: [PATCH v1 08/16] kmsan: convert kmsan_handle_dma to use physical addresses
Date: Thu, 14 Aug 2025 09:44:48 -0300 [thread overview]
Message-ID: <20250814124448.GE699432@nvidia.com> (raw)
In-Reply-To: <20250814123506.GD310013@unreal>
On Thu, Aug 14, 2025 at 03:35:06PM +0300, Leon Romanovsky wrote:
> > Then check attrs here, not pfn_valid.
>
> attrs are not available in kmsan_handle_dma(). I can add it if you prefer.
That makes more sense to the overall design. The comments I gave
before were driving at a promise to never try to touch a struct page
for ATTR_MMIO and think this should be comphrensive to never touching
a struct page even if pfnvalid.
> > > So let's keep this patch as is.
> >
> > Still need to fix the remarks you clipped, do not check PageHighMem
> > just call kmap_local_pfn(). All thie PageHighMem stuff is new to this
> > patch and should not be here, it is the wrong way to use highmem.
>
> Sure, thanks
I am wondering if there is some reason it was written like this in the
first place. Maybe we can't even do kmap here.. So perhaps if there is
not a strong reason to change it just continue to check pagehighmem
and fail.
if (!(attrs & ATTR_MMIO) && PageHighMem(phys_to_page(phys)))
return;
Jason
next prev parent reply other threads:[~2025-08-14 12:45 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 12:42 [PATCH v1 00/16] dma-mapping: migrate to physical address-based API Leon Romanovsky
2025-08-04 12:42 ` [PATCH v1 01/16] dma-mapping: introduce new DMA attribute to indicate MMIO memory Leon Romanovsky
2025-08-06 17:31 ` Jason Gunthorpe
2025-08-04 12:42 ` [PATCH v1 02/16] iommu/dma: handle MMIO path in dma_iova_link Leon Romanovsky
2025-08-06 18:10 ` Jason Gunthorpe
2025-08-04 12:42 ` [PATCH v1 03/16] dma-debug: refactor to use physical addresses for page mapping Leon Romanovsky
2025-08-06 18:26 ` Jason Gunthorpe
2025-08-06 18:38 ` Leon Romanovsky
2025-08-04 12:42 ` [PATCH v1 04/16] dma-mapping: rename trace_dma_*map_page to trace_dma_*map_phys Leon Romanovsky
2025-08-04 12:42 ` [PATCH v1 05/16] iommu/dma: rename iommu_dma_*map_page to iommu_dma_*map_phys Leon Romanovsky
2025-08-06 18:44 ` Jason Gunthorpe
2025-08-04 12:42 ` [PATCH v1 06/16] iommu/dma: extend iommu_dma_*map_phys API to handle MMIO memory Leon Romanovsky
2025-08-07 12:07 ` Jason Gunthorpe
2025-08-04 12:42 ` [PATCH v1 07/16] dma-mapping: convert dma_direct_*map_page to be phys_addr_t based Leon Romanovsky
2025-08-07 12:13 ` Jason Gunthorpe
2025-08-04 12:42 ` [PATCH v1 08/16] kmsan: convert kmsan_handle_dma to use physical addresses Leon Romanovsky
2025-08-07 12:21 ` Jason Gunthorpe
2025-08-13 15:07 ` Leon Romanovsky
2025-08-14 12:13 ` Jason Gunthorpe
2025-08-14 12:35 ` Leon Romanovsky
2025-08-14 12:44 ` Jason Gunthorpe [this message]
2025-08-14 13:31 ` Leon Romanovsky
2025-08-14 14:14 ` Jason Gunthorpe
2025-08-04 12:42 ` [PATCH v1 09/16] dma-mapping: handle MMIO flow in dma_map|unmap_page Leon Romanovsky
2025-08-07 13:08 ` Jason Gunthorpe
2025-08-04 12:42 ` [PATCH v1 10/16] xen: swiotlb: Open code map_resource callback Leon Romanovsky
2025-08-07 14:40 ` Jürgen Groß
2025-08-04 12:42 ` [PATCH v1 11/16] dma-mapping: export new dma_*map_phys() interface Leon Romanovsky
2025-08-07 13:38 ` Jason Gunthorpe
2025-08-04 12:42 ` [PATCH v1 12/16] mm/hmm: migrate to physical address-based DMA mapping API Leon Romanovsky
2025-08-07 13:14 ` Jason Gunthorpe
2025-08-04 12:42 ` [PATCH v1 13/16] mm/hmm: properly take MMIO path Leon Romanovsky
2025-08-07 13:14 ` Jason Gunthorpe
2025-08-04 12:42 ` [PATCH v1 14/16] block-dma: migrate to dma_map_phys instead of map_page Leon Romanovsky
2025-08-04 12:42 ` [PATCH v1 15/16] block-dma: properly take MMIO path Leon Romanovsky
2025-08-04 12:42 ` [PATCH v1 16/16] nvme-pci: unmap MMIO pages with appropriate interface Leon Romanovsky
2025-08-07 13:45 ` Jason Gunthorpe
2025-08-13 15:37 ` Leon Romanovsky
2025-08-07 14:19 ` [PATCH v1 00/16] dma-mapping: migrate to physical address-based API Jason Gunthorpe
2025-08-08 18:51 ` Marek Szyprowski
2025-08-09 13:34 ` Jason Gunthorpe
2025-08-09 16:53 ` Demi Marie Obenour
2025-08-10 17:02 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814124448.GE699432@nvidia.com \
--to=jgg@nvidia$(echo .)com \
--cc=abdiel.janulgue@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alex.gaynor@gmail$(echo .)com \
--cc=axboe@kernel$(echo .)dk \
--cc=corbet@lwn$(echo .)net \
--cc=dakr@kernel$(echo .)org \
--cc=glider@google$(echo .)com \
--cc=hch@lst$(echo .)de \
--cc=iommu@lists$(echo .)linux.dev \
--cc=jasowang@redhat$(echo .)com \
--cc=jgross@suse$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=kasan-dev@googlegroups$(echo .)com \
--cc=kbusch@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-nvme@lists$(echo .)infradead.org \
--cc=linux-trace-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mhiramat@kernel$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=mst@redhat$(echo .)com \
--cc=ojeda@kernel$(echo .)org \
--cc=robin.murphy@arm$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=rust-for-linux@vger$(echo .)kernel.org \
--cc=sagi@grimberg$(echo .)me \
--cc=sstabellini@kernel$(echo .)org \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=will@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox