Subject: Re: [PATCH 5/6] lib/crypto: curve25519: Consolidate into single module

From: Eric Biggers <[email-masked]>
Date: Tue, 2 Sep 2025 19:12:11 -0700

On Mon, Sep 01, 2025 at 01:18:14PM -0700, Eric Biggers wrote:
> diff --git a/lib/crypto/tests/Kconfig b/lib/crypto/tests/Kconfig
> index 7e4e66f30a7a6..c0f3b64489dd6 100644
> --- a/lib/crypto/tests/Kconfig
> +++ b/lib/crypto/tests/Kconfig
> @@ -11,13 +11,14 @@ config CRYPTO_LIB_BLAKE2S_KUNIT_TEST
>  	  KUnit tests for the BLAKE2s cryptographic hash function.
>  
>  config CRYPTO_LIB_CURVE25519_KUNIT_TEST
>  	tristate "KUnit tests for Curve25519" if !KUNIT_ALL_TESTS
>  	depends on KUNIT
> -	default KUNIT_ALL_TESTS
> +	default KUNIT_ALL_TESTS || CRYPTO_SELFTESTS
>  	select CRYPTO_LIB_BENCHMARK_VISIBLE
>  	select CRYPTO_LIB_CURVE25519
> +	select CRYPTO_LIB_CURVE25519_GENERIC
>  	help
>  	  KUnit tests for Curve25519.

Small correction above: adding 'select CRYPTO_LIB_CURVE25519_GENERIC'
is unnecessary here.

- Eric