Subject: Re: [PATCH v4 06/10] drm/i915: Use scope-based cleanup helper

From: Jonathan Cameron <[email-masked]>
Date: Fri, 5 Sep 2025 11:02:48 +0100

On Wed,  3 Sep 2025 21:17:29 +0800
Zihuan Zhang <[email-masked]> wrote:

> Replace the manual cpufreq_cpu_put() with __free(put_cpufreq_policy)
> annotation for policy references. This reduces the risk of reference
> counting mistakes and aligns the code with the latest kernel style.
> 
> No functional change intended.
> 
> Signed-off-by: Zihuan Zhang <[email-masked]>
FWIW this one is fine if low impact.
Reviewed-by: Jonathan Cameron <[email-masked]>
> ---
>  drivers/gpu/drm/i915/gt/intel_llc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_llc.c b/drivers/gpu/drm/i915/gt/intel_llc.c
> index 1d19c073ba2e..f15e4c0fa54b 100644
> --- a/drivers/gpu/drm/i915/gt/intel_llc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_llc.c
> @@ -29,13 +29,11 @@ static struct intel_gt *llc_to_gt(struct intel_llc *llc)
>  
>  static unsigned int cpu_max_MHz(void)
>  {
> -	struct cpufreq_policy *policy;
> +	struct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(0);
>  	unsigned int max_khz;
>  
> -	policy = cpufreq_cpu_get(0);
>  	if (policy) {
>  		max_khz = policy->cpuinfo.max_freq;
> -		cpufreq_cpu_put(policy);
>  	} else {
>  		/*
>  		 * Default to measured freq if none found, PCU will ensure we