From: Herve Codina <herve.codina@bootlin•com>
To: Manivannan Sadhasivam <mani@kernel•org>
Cc: "Christian Zigotzky" <chzigotzky@xenosoft•de>,
"Bjorn Helgaas" <helgaas@kernel•org>,
"Lukas Wunner" <lukas@wunner•de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@oss•qualcomm.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux•intel.com>,
linux-pci@vger•kernel.org, "mad skateman" <madskateman@gmail•com>,
"R.T.Dickinson" <rtd2@xtra•co.nz>,
"Christian Zigotzky" <info@xenosoft•de>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
hypexed@yahoo•com.au, "Darren Stevens" <darren@stevens-zone•net>,
debian-powerpc@lists•debian.org,
"Thomas Petazzoni" <thomas.petazzoni@bootlin•com>
Subject: Re: [PPC] Boot problems after the pci-v6.18-changes
Date: Thu, 23 Oct 2025 11:19:47 +0200 [thread overview]
Message-ID: <20251023111947.6e960216@bootlin.com> (raw)
In-Reply-To: <vc7ehnmr6tjkkag3j543zwprwqdjyttovav2moo5ravpzzkmbi@qe4tds4e7nc6>
Hi Manivannan,
On Thu, 23 Oct 2025 14:19:46 +0530
Manivannan Sadhasivam <mani@kernel•org> wrote:
> On Thu, Oct 23, 2025 at 09:38:13AM +0200, Herve Codina wrote:
> > Hi Manivannan,
> >
> > On Wed, 15 Oct 2025 18:20:22 +0530
> > Manivannan Sadhasivam <mani@kernel•org> wrote:
> >
> > > Hi Herve,
> > >
> > > On Wed, Oct 15, 2025 at 01:58:11PM +0200, Herve Codina wrote:
> > > > Hi Christian,
> > > >
> > > > On Wed, 15 Oct 2025 13:30:44 +0200
> > > > Christian Zigotzky <chzigotzky@xenosoft•de> wrote:
> > > >
> > > > > Hello Herve,
> > > > >
> > > > > > On 15 October 2025 at 10:39 am, Herve Codina <herve.codina@bootlin•com> wrote:
> > > > > >
> > > > > > Hi All,
> > > > > >
> > > > > > I also observed issues with the commit f3ac2ff14834 ("PCI/ASPM: Enable all
> > > > > > ClockPM and ASPM states for devicetree platforms")
> > > > >
> > > > > Thanks for reporting.
> > > > >
> > > > > >
> > > > > > Also tried the quirk proposed in this discussion (quirk_disable_aspm_all)
> > > > > > an the quirk also fixes the timing issue.
> > > > >
> > > > > Where have you added quirk_disable_aspm_all?
> > > >
> > > > --- 8< ---
> > > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> > > > index 214ed060ca1b..a3808ab6e92e 100644
> > > > --- a/drivers/pci/quirks.c
> > > > +++ b/drivers/pci/quirks.c
> > > > @@ -2525,6 +2525,17 @@ static void quirk_disable_aspm_l0s_l1(struct pci_dev *dev)
> > > > */
> > > > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080, quirk_disable_aspm_l0s_l1);
> > > >
> > > > +static void quirk_disable_aspm_all(struct pci_dev *dev)
> > > > +{
> > > > + pci_info(dev, "Disabling ASPM\n");
> > > > + pci_disable_link_state(dev, PCIE_LINK_STATE_ALL);
> > >
> > > Could you please try disabling L1SS and L0s separately to see which one is
> > > causing the issue? Like,
> > >
> > > pci_disable_link_state(dev, PCIE_LINK_STATE_L1_1 | PCIE_LINK_STATE_L1_2);
> > >
> > > pci_disable_link_state(dev, PCIE_LINK_STATE_L0S);
> > >
> >
> > I did tests and here are the results:
> >
> > - quirk pci_disable_link_state(dev, PCIE_LINK_STATE_ALL)
> > Issue not present
> >
> > - quirk pci_disable_link_state(dev, PCIE_LINK_STATE_L1_1 | PCIE_LINK_STATE_L1_2)
> > Issue present, timings similar to timings already reported
> > (hundreds of ms).
> >
> > - quirk pci_disable_link_state(dev, PCIE_LINK_STATE_L0S);
> > Issue present, timings still incorrect but lower
> > 64 bytes from 192.168.32.100: seq=10 ttl=64 time=16.738 ms
> > 64 bytes from 192.168.32.100: seq=11 ttl=64 time=39.500 ms
> > 64 bytes from 192.168.32.100: seq=12 ttl=64 time=62.178 ms
> > 64 bytes from 192.168.32.100: seq=13 ttl=64 time=84.709 ms
> > 64 bytes from 192.168.32.100: seq=14 ttl=64 time=107.484 ms
> >
>
> This is weird. Looks like all ASPM states (L0s, L1ss) are contributing to the
> increased latency, which is more than what should occur. This makes me ignore
> inspecting the L0s/L1 exit latency fields :/
>
> Bjorn sent out a patch [1] that enables only L0s and L1 by default. But it
> might not help you. I don't honestly know how you are seeing this much of the
> latency. This could the due to an issue in the PCI component (host or endpoint),
> or even the board routing. Identifying which one is causing the issue is going
> to be tricky as it would require some experimentation.
I've just tested the patch from Bjorn and I confirm that it doesn't fix my issue.
>
> If you are motivated, we can start to isolate this issue to the endpoint first.
> Is it possible for you to connect a different PCI card to your host and check
> whether you are seeing the increased latency? If the different PCI card is not
> exhibiting the same behavior, then the current device is the culprit and we
> should be able to quirk it.
Will see what I can do.
Best regards,
Hervé
next prev parent reply other threads:[~2025-10-23 9:26 UTC|newest]
Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 11:59 Radeon NI: GIT kernel with the nislands_smc commit doesn't boot on a Freescale P5040 board and P.A.Semi Nemo board Christian Zigotzky
2021-04-30 15:26 ` Deucher, Alexander
2021-04-30 15:56 ` Gustavo A. R. Silva
2021-05-03 22:25 ` [FSL P50x0] Xorg always restarts again and again after the the PowerPC updates 5.13-1 Christian Zigotzky
2021-05-04 4:56 ` Christophe Leroy
2021-05-04 7:21 ` Christian Zigotzky
2021-05-04 7:47 ` Christophe Leroy
2021-05-04 8:29 ` Christian Zigotzky
2021-05-04 8:58 ` Christophe Leroy
2021-05-04 9:09 ` Christian Zigotzky
2021-05-04 9:11 ` Christophe Leroy
2021-05-04 9:46 ` Christian Zigotzky
2021-05-04 9:49 ` Christophe Leroy
2021-05-04 10:07 ` Christian Zigotzky
2021-05-04 11:02 ` Christian Zigotzky
2021-05-04 13:48 ` Christian Zigotzky
2021-05-04 14:48 ` Christophe Leroy
2021-05-04 14:52 ` Christian Zigotzky
2021-05-04 14:41 ` Christophe Leroy
2021-05-04 14:59 ` Christian Zigotzky
2021-05-04 15:17 ` Christophe Leroy
2021-05-05 12:43 ` Christian Zigotzky
2021-05-06 6:12 ` Christophe Leroy
2021-05-06 7:56 ` Christian Zigotzky
2021-05-06 8:09 ` Christophe Leroy
2021-05-06 13:58 ` Christian Zigotzky
2021-05-08 16:39 ` Christian Zigotzky
2021-05-09 12:27 ` Christian Zigotzky
2021-05-09 17:43 ` Christophe Leroy
2021-05-09 21:46 ` Christian Zigotzky
2021-05-09 17:36 ` Christophe Leroy
2021-05-13 6:47 ` Christian Zigotzky
2021-05-13 10:01 ` Christophe Leroy
2021-05-13 15:19 ` Christian Zigotzky
2021-05-13 15:51 ` Christophe Leroy
2021-05-13 16:35 ` Christian Zigotzky
2021-05-13 17:00 ` Christophe Leroy
2021-05-13 20:20 ` Christian Zigotzky
2021-05-13 22:58 ` Nicholas Piggin
2021-05-14 0:19 ` Christian Zigotzky
2021-05-04 14:44 ` Christophe Leroy
2021-05-06 23:55 ` Radeon NI: GIT kernel with the nislands_smc commit doesn't boot on a Freescale P5040 board and P.A.Semi Nemo board Gustavo A. R. Silva
2021-05-07 6:43 ` Christian Zigotzky
2021-05-08 11:33 ` Christian Zigotzky
2021-05-09 23:04 ` Gustavo A. R. Silva
2023-11-02 14:45 ` Fbdev issue after the drm updates 'drm-next-2023-10-31-1' Christian Zigotzky
2023-11-07 8:36 ` Christian Zigotzky
2023-11-12 14:23 ` Christian Zigotzky
2023-11-13 12:48 ` Geert Uytterhoeven
2023-11-13 13:12 ` Christian Zigotzky
2023-11-14 9:45 ` Christian Zigotzky
2023-11-15 8:33 ` Geert Uytterhoeven
2023-11-15 9:22 ` Gerd Hoffmann
2023-11-16 13:13 ` Geert Uytterhoeven
2021-11-04 10:45 ` [VirtIO GPU] Xorg doesn't start with the DRM updates 'drm-next-2021-11-03' in a virtual e5500 QEMU KVM-HV machine on a Freescale P5040 board Christian Zigotzky
[not found] ` <20211104214249.1802789-1-vivek.kasireddy@intel.com>
2021-11-05 18:05 ` [PATCH] drm/virtio: Fix NULL dereference error in virtio_gpu_poll Christian Zigotzky
2021-11-08 14:48 ` [FSL P50x0] Cyrus+ board doesn't boot with the PowerPC updates 5.16-1 Christian Zigotzky
2021-11-09 14:45 ` [PASEMI] Nemo board doesn't recognize any ATA disks with the pci-v5.16 updates Christian Zigotzky
2021-11-09 15:10 ` Christian Zigotzky
2021-11-09 16:58 ` Bjorn Helgaas
2021-11-09 22:40 ` Krzysztof Wilczyński
2021-11-09 23:05 ` Arnd Bergmann
2021-11-09 23:18 ` Krzysztof Wilczyński
2021-11-10 16:42 ` Robert Święcki
2021-11-10 3:52 ` Damien Le Moal
2021-11-10 18:07 ` Christian Zigotzky
2021-11-10 18:41 ` Bjorn Helgaas
2021-11-10 19:09 ` Marc Zyngier
2021-11-11 5:24 ` Christian Zigotzky
2021-11-11 7:13 ` Marc Zyngier
2021-11-11 7:47 ` Christian Zigotzky
2021-11-11 10:20 ` Marc Zyngier
2021-11-11 10:44 ` Christian Zigotzky
2021-11-11 11:24 ` Marc Zyngier
2021-11-11 11:54 ` Christian Zigotzky
2021-11-11 22:21 ` Olof Johansson
2021-11-12 11:49 ` Segher Boessenkool
2021-11-11 17:39 ` Marc Zyngier
2021-11-12 9:40 ` Christian Zigotzky
2021-11-12 10:11 ` Christian Zigotzky
2021-11-12 11:00 ` Christian Zigotzky
2021-11-12 13:41 ` Marc Zyngier
2021-11-12 14:15 ` Christian Zigotzky
2021-11-12 14:46 ` Marc Zyngier
2021-11-12 15:01 ` Christian Zigotzky
2021-11-12 15:05 ` Christian Zigotzky
2025-10-08 16:35 ` [PPC] Boot problems after the pci-v6.18-changes Christian Zigotzky
2025-10-08 16:40 ` John Paul Adrian Glaubitz
2025-10-08 16:47 ` Christian Zigotzky
2025-10-08 19:51 ` Bjorn Helgaas
2025-10-09 4:54 ` Christian Zigotzky
2025-10-09 5:37 ` Lukas Wunner
2025-10-11 5:12 ` Christian Zigotzky
2025-10-11 5:25 ` Lukas Wunner
2025-10-11 15:11 ` Manivannan Sadhasivam
2025-10-11 19:34 ` Christian Zigotzky
2025-10-12 7:47 ` Christian Zigotzky
2025-10-12 8:26 ` Christian Zigotzky
2025-10-13 4:46 ` Christian Zigotzky
2025-10-13 5:02 ` Christian Zigotzky
2025-10-13 5:23 ` Christian Zigotzky
2025-10-13 14:50 ` Christian Zigotzky
2025-10-13 15:02 ` Christian Zigotzky
2025-10-13 15:38 ` Christian Zigotzky
2025-10-13 15:58 ` Manivannan Sadhasivam
2025-10-14 4:48 ` Christian Zigotzky
2025-10-14 4:55 ` Christian Zigotzky
2025-10-15 6:41 ` Manivannan Sadhasivam
2025-10-13 16:01 ` Manivannan Sadhasivam
2025-10-15 8:13 ` Herve Codina
2025-10-15 11:30 ` Christian Zigotzky
2025-10-15 11:58 ` Herve Codina
2025-10-15 12:27 ` Christian Zigotzky
2025-10-15 12:59 ` Herve Codina
2025-10-15 13:14 ` Christian Zigotzky
2025-10-15 13:17 ` Christian Zigotzky
2025-10-15 13:34 ` Herve Codina
2025-10-15 16:54 ` Christian Zigotzky
2025-10-15 17:15 ` Christian Zigotzky
2025-10-16 3:28 ` Christian Zigotzky
2025-10-16 7:36 ` Christian Zigotzky
2025-10-16 7:53 ` Manivannan Sadhasivam
2025-10-16 10:44 ` Christian Zigotzky
2025-10-17 5:35 ` Christian Zigotzky
2025-10-15 16:23 ` Manivannan Sadhasivam
2025-10-15 13:07 ` Christian Zigotzky
2025-10-15 12:50 ` Manivannan Sadhasivam
2025-10-23 7:38 ` Herve Codina
2025-10-23 8:49 ` Manivannan Sadhasivam
2025-10-23 9:19 ` Herve Codina [this message]
2025-10-23 16:59 ` Bjorn Helgaas
2025-10-15 23:40 ` Bjorn Helgaas
2025-10-13 21:06 ` Bjorn Helgaas
2025-10-14 18:51 ` Bjorn Helgaas
2025-10-30 22:11 ` Bjorn Helgaas
2025-11-01 5:39 ` Christian Zigotzky
2025-11-01 7:50 ` Christian Zigotzky
2025-11-01 7:59 ` Christian Zigotzky
2025-11-01 17:06 ` Manivannan Sadhasivam
2025-11-03 18:28 ` Christian Zigotzky
2025-11-05 22:09 ` Bjorn Helgaas
2025-11-06 8:48 ` Hongxing Zhu
2025-11-06 18:25 ` Bjorn Helgaas
2025-11-07 2:26 ` Hongxing Zhu
2025-11-07 5:06 ` Christian Zigotzky
2025-11-11 5:15 ` Christian Zigotzky
2025-11-11 12:20 ` Bjorn Helgaas
2025-11-12 3:40 ` Christian Zigotzky
2025-11-13 0:44 ` Bjorn Helgaas
2021-11-09 16:13 ` [FSL P50x0] Cyrus+ board doesn't boot with the PowerPC updates 5.16-1 Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023111947.6e960216@bootlin.com \
--to=herve.codina@bootlin$(echo .)com \
--cc=chzigotzky@xenosoft$(echo .)de \
--cc=darren@stevens-zone$(echo .)net \
--cc=debian-powerpc@lists$(echo .)debian.org \
--cc=helgaas@kernel$(echo .)org \
--cc=hypexed@yahoo$(echo .)com.au \
--cc=ilpo.jarvinen@linux$(echo .)intel.com \
--cc=info@xenosoft$(echo .)de \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lukas@wunner$(echo .)de \
--cc=madskateman@gmail$(echo .)com \
--cc=mani@kernel$(echo .)org \
--cc=manivannan.sadhasivam@oss$(echo .)qualcomm.com \
--cc=rtd2@xtra$(echo .)co.nz \
--cc=thomas.petazzoni@bootlin$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox