From: Bjorn Helgaas <helgaas@kernel•org>
To: linux-pci@vger•kernel.org
Cc: Christian Zigotzky <chzigotzky@xenosoft•de>,
Manivannan Sadhasivam <mani@kernel•org>,
mad skateman <madskateman@gmail•com>,
"R . T . Dickinson" <rtd2@xtra•co.nz>,
Darren Stevens <darren@stevens-zone•net>,
John Paul Adrian Glaubitz <glaubitz@physik•fu-berlin.de>,
Lukas Wunner <lukas@wunner•de>,
luigi burdo <intermediadc@hotmail•com>, Al <al@datazap•net>,
Roland <rol7and@gmx•com>, Hongxing Zhu <hongxing.zhu@nxp•com>,
hypexed@yahoo•com.au, linuxppc-dev@lists•ozlabs.org,
debian-powerpc@lists•debian.org, linux-kernel@vger•kernel.org,
Bjorn Helgaas <bhelgaas@google•com>
Subject: Re: [PATCH 0/2] PCI/ASPM: Allow quirks to avoid L0s and L1
Date: Thu, 6 Nov 2025 17:45:51 -0600 [thread overview]
Message-ID: <20251106234551.GA1976429@bhelgaas> (raw)
In-Reply-To: <20251106183643.1963801-1-helgaas@kernel.org>
On Thu, Nov 06, 2025 at 12:36:37PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google•com>
>
> We enabled ASPM too aggressively in v6.18-rc1. f3ac2ff14834 ("PCI/ASPM:
> Enable all ClockPM and ASPM states for devicetree platforms") enabled ASPM
> L0s, L1, and (if advertised) L1 PM Substates.
>
> L1 PM Substates and Clock PM in particular are a problem because they
> depend on CLKREQ# and sometimes device-specific configuration, and none of
> this is discoverable in a generic way.
>
> df5192d9bb0e ("PCI/ASPM: Enable only L0s and L1 for devicetree platforms")
> (v6.18-rc3) backed off and omitted Clock PM and L1 Substates.
>
> L0s and L1 are generically discoverable, but some devices advertise them
> even though they don't work correctly. This series is a way to avoid L0s
> and L1 in that case.
>
> Bjorn Helgaas (2):
> PCI/ASPM: Cache Link Capabilities so quirks can override them
> PCI/ASPM: Avoid L0s and L1 on Freescale Root Ports
>
> drivers/pci/pcie/aspm.c | 42 ++++++++++++++++++++---------------------
> drivers/pci/probe.c | 5 ++---
> drivers/pci/quirks.c | 12 ++++++++++++
> include/linux/pci.h | 1 +
> 4 files changed, 36 insertions(+), 24 deletions(-)
I put these on for-linus, hopefully for v6.18. I would like to have
some review and testing before asking Linus to pull them, especially
since the first one is not completely trivial and is a change (but
shouldn't be a functional change) for all platforms.
next prev parent reply other threads:[~2025-11-06 23:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 18:36 [PATCH 0/2] PCI/ASPM: Allow quirks to avoid L0s and L1 Bjorn Helgaas
2025-11-06 18:36 ` [PATCH 1/2] PCI/ASPM: Cache Link Capabilities so quirks can override them Bjorn Helgaas
2025-11-07 1:17 ` Shawn Lin
2025-11-07 6:03 ` Manivannan Sadhasivam
2025-11-07 5:32 ` Lukas Wunner
2025-11-07 15:25 ` Bjorn Helgaas
2025-11-06 18:36 ` [PATCH 2/2] PCI/ASPM: Avoid L0s and L1 on Freescale Root Ports Bjorn Helgaas
2025-11-07 5:35 ` Lukas Wunner
2025-11-07 6:09 ` Manivannan Sadhasivam
2025-11-07 21:55 ` Bjorn Helgaas
2025-11-06 23:45 ` Bjorn Helgaas [this message]
2025-11-07 2:33 ` [PATCH 0/2] PCI/ASPM: Allow quirks to avoid L0s and L1 Hongxing Zhu
2025-11-07 5:40 ` Manivannan Sadhasivam
2025-11-07 6:33 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106234551.GA1976429@bhelgaas \
--to=helgaas@kernel$(echo .)org \
--cc=al@datazap$(echo .)net \
--cc=bhelgaas@google$(echo .)com \
--cc=chzigotzky@xenosoft$(echo .)de \
--cc=darren@stevens-zone$(echo .)net \
--cc=debian-powerpc@lists$(echo .)debian.org \
--cc=glaubitz@physik$(echo .)fu-berlin.de \
--cc=hongxing.zhu@nxp$(echo .)com \
--cc=hypexed@yahoo$(echo .)com.au \
--cc=intermediadc@hotmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lukas@wunner$(echo .)de \
--cc=madskateman@gmail$(echo .)com \
--cc=mani@kernel$(echo .)org \
--cc=rol7and@gmx$(echo .)com \
--cc=rtd2@xtra$(echo .)co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox