From: Jason Gunthorpe <jgg@nvidia•com>
To: Zi Yan <ziy@nvidia•com>
Cc: "Balbir Singh" <balbirs@nvidia•com>,
"Matthew Wilcox" <willy@infradead•org>,
"Alistair Popple" <apopple@nvidia•com>,
"Matthew Brost" <matthew.brost@intel•com>,
"Vlastimil Babka" <vbabka@suse•cz>,
"Francois Dugast" <francois.dugast@intel•com>,
intel-xe@lists•freedesktop.org, dri-devel@lists•freedesktop.org,
"adhavan Srinivasan" <maddy@linux•ibm.com>,
"Nicholas Piggin" <npiggin@gmail•com>,
"Michael Ellerman" <mpe@ellerman•id.au>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel•org>,
"Felix Kuehling" <Felix.Kuehling@amd•com>,
"Alex Deucher" <alexander.deucher@amd•com>,
"Christian König" <christian.koenig@amd•com>,
"David Airlie" <airlied@gmail•com>,
"Simona Vetter" <simona@ffwll•ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux•intel.com>,
"Maxime Ripard" <mripard@kernel•org>,
"Thomas Zimmermann" <tzimmermann@suse•de>,
"Lyude Paul" <lyude@redhat•com>,
"Danilo Krummrich" <dakr@kernel•org>,
"David Hildenbrand" <david@kernel•org>,
"Oscar Salvador" <osalvador@suse•de>,
"Andrew Morton" <akpm@linux-foundation•org>,
"Leon Romanovsky" <leon@kernel•org>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle•com>,
"Liam R . Howlett" <Liam.Howlett@oracle•com>,
"Mike Rapoport" <rppt@kernel•org>,
"Suren Baghdasaryan" <surenb@google•com>,
"Michal Hocko" <mhocko@suse•com>,
linuxppc-dev@lists•ozlabs.org, kvm@vger•kernel.org,
linux-kernel@vger•kernel.org, amd-gfx@lists•freedesktop.org,
nouveau@lists•freedesktop.org, linux-mm@kvack•org,
linux-cxl@vger•kernel.org
Subject: Re: [PATCH v6 1/5] mm/zone_device: Reinitialize large zone device private folios
Date: Tue, 20 Jan 2026 09:53:40 -0400 [thread overview]
Message-ID: <20260120135340.GA1134360@nvidia.com> (raw)
In-Reply-To: <EE2956E3-CCEA-4EF9-A1A4-A483245091FC@nvidia.com>
On Mon, Jan 19, 2026 at 09:50:16PM -0500, Zi Yan wrote:
> >> I suppose we want some prep_single_page(page) and some reorg to share
> >> code with the other prep function.
>
> This is just an unnecessary need due to lack of knowledge of/do not want
> to investigate core MM page and folio initialization code.
It will be better to keep this related code together, not spread all
around.
> >> I don't think so. It should do the above job efficiently and iterate
> >> over the page list exactly once.
>
> folio initialization should not iterate over any page list, since folio is
> supposed to be treated as a whole instead of individual pages.
The tail pages need to have the right data in them or compound_head
won't work.
> folio->mapping = NULL;
> folio->memcg_data = 0;
> folio->flags.f &= ~PAGE_FLAGS_CHECK_AT_PREP;
>
> should be enough.
This seems believable to me for setting up an order 0 page.
> if (order)
> folio_set_large_rmappable(folio);
That one is in zone_device_folio_init()
And maybe the naming has got really confused if we have both functions
now :\
Jason
next prev parent reply other threads:[~2026-01-20 13:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 11:10 [PATCH v6 0/5] Enable THP support in drm_pagemap Francois Dugast
2026-01-16 11:10 ` [PATCH v6 1/5] mm/zone_device: Reinitialize large zone device private folios Francois Dugast
2026-01-16 13:10 ` Balbir Singh
2026-01-16 16:07 ` Vlastimil Babka
2026-01-16 17:20 ` Jason Gunthorpe
2026-01-16 17:27 ` Vlastimil Babka
2026-01-22 8:02 ` Vlastimil Babka
2026-01-16 17:49 ` Jason Gunthorpe
2026-01-16 19:17 ` Vlastimil Babka
2026-01-16 20:31 ` Matthew Brost
2026-01-17 0:51 ` Jason Gunthorpe
2026-01-17 3:55 ` Matthew Brost
2026-01-17 4:42 ` Balbir Singh
2026-01-17 5:27 ` Matthew Brost
2026-01-19 5:59 ` Alistair Popple
2026-01-19 14:20 ` Jason Gunthorpe
2026-01-19 20:09 ` Zi Yan
2026-01-19 20:35 ` Jason Gunthorpe
2026-01-19 22:15 ` Balbir Singh
2026-01-20 2:50 ` Zi Yan
2026-01-20 13:53 ` Jason Gunthorpe [this message]
2026-01-21 3:01 ` Zi Yan
2026-01-22 7:19 ` Matthew Brost
2026-01-22 8:00 ` Vlastimil Babka
2026-01-22 9:10 ` Balbir Singh
2026-01-22 21:41 ` Andrew Morton
2026-01-22 22:53 ` Alistair Popple
2026-01-23 6:45 ` Vlastimil Babka
2026-01-22 14:29 ` Jason Gunthorpe
2026-01-22 15:46 ` Jason Gunthorpe
2026-01-23 2:41 ` Zi Yan
2026-01-23 14:19 ` Jason Gunthorpe
2026-01-21 3:51 ` Balbir Singh
2026-01-17 0:19 ` Jason Gunthorpe
2026-01-19 5:41 ` Alistair Popple
2026-01-19 14:24 ` Jason Gunthorpe
2026-01-16 22:34 ` Andrew Morton
2026-01-16 22:36 ` Matthew Brost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120135340.GA1134360@nvidia.com \
--to=jgg@nvidia$(echo .)com \
--cc=Felix.Kuehling@amd$(echo .)com \
--cc=Liam.Howlett@oracle$(echo .)com \
--cc=airlied@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexander.deucher@amd$(echo .)com \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=apopple@nvidia$(echo .)com \
--cc=balbirs@nvidia$(echo .)com \
--cc=chleroy@kernel$(echo .)org \
--cc=christian.koenig@amd$(echo .)com \
--cc=dakr@kernel$(echo .)org \
--cc=david@kernel$(echo .)org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=francois.dugast@intel$(echo .)com \
--cc=intel-xe@lists$(echo .)freedesktop.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=leon@kernel$(echo .)org \
--cc=linux-cxl@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lorenzo.stoakes@oracle$(echo .)com \
--cc=lyude@redhat$(echo .)com \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=maddy@linux$(echo .)ibm.com \
--cc=matthew.brost@intel$(echo .)com \
--cc=mhocko@suse$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=mripard@kernel$(echo .)org \
--cc=nouveau@lists$(echo .)freedesktop.org \
--cc=npiggin@gmail$(echo .)com \
--cc=osalvador@suse$(echo .)de \
--cc=rppt@kernel$(echo .)org \
--cc=simona@ffwll$(echo .)ch \
--cc=surenb@google$(echo .)com \
--cc=tzimmermann@suse$(echo .)de \
--cc=vbabka@suse$(echo .)cz \
--cc=willy@infradead$(echo .)org \
--cc=ziy@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox