From: Rob Herring <robh@kernel•org>
To: Bartosz Golaszewski <bartosz.golaszewski@oss•qualcomm.com>
Cc: Saravana Kannan <saravanak@kernel•org>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
"Rafael J. Wysocki" <rafael@kernel•org>,
Danilo Krummrich <dakr@kernel•org>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel•org>,
Shawn Guo <shawnguo@kernel•org>,
Sascha Hauer <s.hauer@pengutronix•de>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Fabio Estevam <festevam@gmail•com>,
Geert Uytterhoeven <geert+renesas@glider•be>,
Magnus Damm <magnus.damm@gmail•com>,
Chen-Yu Tsai <wens@kernel•org>,
Jernej Skrabec <jernej.skrabec@gmail•com>,
Samuel Holland <samuel@sholland•org>, Frank Li <Frank.Li@nxp•com>,
devicetree@vger•kernel.org, linux-kernel@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org,
linux-arm-kernel@lists•infradead.org, imx@lists•linux.dev,
linux-renesas-soc@vger•kernel.org, linux-sunxi@lists•linux.dev,
driver-core@lists•linux.dev, Peng Fan <peng.fan@nxp•com>
Subject: Re: [PATCH v2 0/9] soc: remove direct accesses to of_root from drivers/soc/
Date: Tue, 24 Feb 2026 12:38:32 -0600 [thread overview]
Message-ID: <20260224183832.GB3239922-robh@kernel.org> (raw)
In-Reply-To: <20260223-soc-of-root-v2-0-b45da45903c8@oss.qualcomm.com>
On Mon, Feb 23, 2026 at 02:37:15PM +0100, Bartosz Golaszewski wrote:
> linux/of.h declares a set of variables providing addresses of certain
> key OF nodes. The pointers being variables can't profit from stubs
> provided for when CONFIG_OF is disabled which means that drivers
> accessing these variables can't profit from CONFIG_COMPILE_TEST=y
> coverage.
>
> There are drivers under drivers/soc/ that access the of_root node. This
> series introduces new OF helpers for reading the machine compatible and
> model strings, exports an existing SoC helper that reads the machine
> string from the root node and finally replaces all direct accesses to
> of_root with new or already existing helper functions.
>
> Merging strategy: first two patches should be either acked by Rob or
> picked up into an immutable branch based on v7.0-rc1, the rest can go
> through the SoC tree.
SoC tree is good.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss•qualcomm.com>
> ---
> Changes in v2:
> - rename of_machine_get_compatible() to of_machine_read_compatible() and
> add the index argument
> - add a stub for of_machine_read_compatible() for !CONFIG_OF
> - provide of_machine_read_model() to avoid having to look-up the root
> node via of_find_node_by_path("/")
> - rename soc_device_get_machine() to soc_attr_read_machine() before
> making it an exported symbol
> - Link to v1: https://lore.kernel.org/r/20260119-soc-of-root-v1-0-32a0fa9a78b4@oss.qualcomm.com
>
> ---
> Bartosz Golaszewski (9):
> of: provide of_machine_read_compatible()
> of: provide of_machine_read_model()
> base: soc: order includes alphabetically
> base: soc: rename and export soc_device_get_machine()
> soc: fsl: guts: don't access of_root directly
> soc: imx8m: don't access of_root directly
> soc: imx9: don't access of_root directly
> soc: renesas: don't access of_root directly
> soc: sunxi: mbus: don't access of_root directly
For all but patch 8,
Reviewed-by: Rob Herring (Arm) <robh@kernel•org>
next prev parent reply other threads:[~2026-02-24 18:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 13:37 [PATCH v2 0/9] soc: remove direct accesses to of_root from drivers/soc/ Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 1/9] of: provide of_machine_read_compatible() Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 2/9] of: provide of_machine_read_model() Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 3/9] base: soc: order includes alphabetically Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 4/9] base: soc: rename and export soc_device_get_machine() Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 5/9] soc: fsl: guts: don't access of_root directly Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 6/9] soc: imx8m: " Bartosz Golaszewski
2026-02-25 7:55 ` Peng Fan
2026-03-24 10:24 ` Alexander Stein
2026-04-27 6:47 ` Francesco Dolcini
2026-04-27 9:31 ` Francesco Dolcini
2026-02-23 13:37 ` [PATCH v2 7/9] soc: imx9: " Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 8/9] soc: renesas: " Bartosz Golaszewski
2026-02-24 18:32 ` Rob Herring
2026-02-25 9:42 ` Bartosz Golaszewski
2026-02-25 21:47 ` Rob Herring
2026-03-02 16:32 ` Geert Uytterhoeven
2026-03-02 17:18 ` Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 9/9] soc: sunxi: mbus: " Bartosz Golaszewski
2026-02-24 18:38 ` Rob Herring [this message]
2026-02-26 9:28 ` [PATCH v2 0/9] soc: remove direct accesses to of_root from drivers/soc/ Bartosz Golaszewski
2026-03-12 15:18 ` Greg Kroah-Hartman
2026-03-13 8:36 ` Bartosz Golaszewski
2026-03-13 9:22 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224183832.GB3239922-robh@kernel.org \
--to=robh@kernel$(echo .)org \
--cc=Frank.Li@nxp$(echo .)com \
--cc=bartosz.golaszewski@oss$(echo .)qualcomm.com \
--cc=chleroy@kernel$(echo .)org \
--cc=dakr@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=driver-core@lists$(echo .)linux.dev \
--cc=festevam@gmail$(echo .)com \
--cc=geert+renesas@glider$(echo .)be \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=imx@lists$(echo .)linux.dev \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=magnus.damm@gmail$(echo .)com \
--cc=peng.fan@nxp$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=samuel@sholland$(echo .)org \
--cc=saravanak@kernel$(echo .)org \
--cc=shawnguo@kernel$(echo .)org \
--cc=wens@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox