From: Christoph Hellwig <hch@lst•de>
To: Eric Biggers <ebiggers@kernel•org>
Cc: Christoph Hellwig <hch@lst•de>,
Andrew Morton <akpm@linux-foundation•org>,
Richard Henderson <richard.henderson@linaro•org>,
Matt Turner <mattst88@gmail•com>,
Magnus Lindholm <linmag7@gmail•com>,
Russell King <linux@armlinux•org.uk>,
Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will@kernel•org>,
Huacai Chen <chenhuacai@kernel•org>,
WANG Xuerui <kernel@xen0n•name>,
Madhavan Srinivasan <maddy@linux•ibm.com>,
Michael Ellerman <mpe@ellerman•id.au>,
Nicholas Piggin <npiggin@gmail•com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel•org>,
Paul Walmsley <pjw@kernel•org>,
Palmer Dabbelt <palmer@dabbelt•com>,
Albert Ou <aou@eecs•berkeley.edu>,
Alexandre Ghiti <alex@ghiti•fr>,
Heiko Carstens <hca@linux•ibm.com>,
Vasily Gorbik <gor@linux•ibm.com>,
Alexander Gordeev <agordeev@linux•ibm.com>,
Christian Borntraeger <borntraeger@linux•ibm.com>,
Sven Schnelle <svens@linux•ibm.com>,
"David S. Miller" <davem@davemloft•net>,
Andreas Larsson <andreas@gaisler•com>,
Richard Weinberger <richard@nod•at>,
Anton Ivanov <anton.ivanov@cambridgegreys•com>,
Johannes Berg <johannes@sipsolutions•net>,
Thomas Gleixner <tglx@kernel•org>, Ingo Molnar <mingo@redhat•com>,
Borislav Petkov <bp@alien8•de>,
Dave Hansen <dave.hansen@linux•intel.com>,
x86@kernel•org, "H. Peter Anvin" <hpa@zytor•com>,
Herbert Xu <herbert@gondor•apana.org.au>,
Dan Williams <dan.j.williams@intel•com>, Chris Mason <clm@fb•com>,
David Sterba <dsterba@suse•com>, Arnd Bergmann <arnd@arndb•de>,
Song Liu <song@kernel•org>, Yu Kuai <yukuai@fnnas•com>,
Li Nan <linan122@huawei•com>,
linux-alpha@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, loongarch@lists•linux.dev,
linuxppc-dev@lists•ozlabs.org, linux-riscv@lists•infradead.org,
linux-s390@vger•kernel.org, sparclinux@vger•kernel.org,
linux-um@lists•infradead.org, linux-crypto@vger•kernel.org,
linux-btrfs@vger•kernel.org, linux-arch@vger•kernel.org,
linux-raid@vger•kernel.org
Subject: Re: [PATCH 09/25] xor: move generic implementations out of asm-generic/xor.h
Date: Tue, 3 Mar 2026 17:09:11 +0100 [thread overview]
Message-ID: <20260303160911.GI7021@lst.de> (raw)
In-Reply-To: <20260228071521.GK65277@quark>
On Fri, Feb 27, 2026 at 11:15:21PM -0800, Eric Biggers wrote:
> This makes the generic code always be included in xor.ko, even when the
> architecture doesn't need it. For example, x86_64 doesn't need it,
> since it always selects either the AVX or SSE code.
True. OTOH it is tiny.
> Have you considered putting the generic code in xor-core.c (or in
> headers included by it) before xor_arch.h is included, and putting
> __maybe_unused on the xor_block_template structs? Then they'll still be
> available for arch_xor_init() to use, but any of them that aren't used
> in a particular build will be optimized out as dead code by the
> compiler.
And earlier version did this, but it's a bit ugly. What I might
consider is to require architectures that provide optimized version
to opt into any generic one they want to use. This would require
extra kconfig symbols, but be a lot cleaner overall.
next prev parent reply other threads:[~2026-03-03 16:09 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 15:10 cleanup the RAID5 XOR library Christoph Hellwig
2026-02-26 15:10 ` [PATCH 01/25] xor: assert that xor_blocks is not called from interrupt context Christoph Hellwig
2026-02-27 14:24 ` Peter Zijlstra
2026-03-03 16:00 ` Christoph Hellwig
2026-03-03 19:55 ` Eric Biggers
2026-03-04 14:51 ` Christoph Hellwig
2026-03-04 15:15 ` Peter Zijlstra
2026-03-04 15:42 ` Christoph Hellwig
2026-03-04 15:01 ` Heiko Carstens
2026-03-04 15:06 ` Christoph Hellwig
2026-03-04 15:08 ` Heiko Carstens
2026-02-26 15:10 ` [PATCH 02/25] arm/xor: remove in_interrupt() handling Christoph Hellwig
2026-02-26 15:10 ` [PATCH 03/25] um/xor: don't override XOR_SELECT_TEMPLATE Christoph Hellwig
2026-02-26 21:45 ` Richard Weinberger
2026-02-26 22:00 ` hch
2026-02-27 7:39 ` Johannes Berg
2026-02-28 4:30 ` Eric Biggers
2026-03-02 7:38 ` Johannes Berg
2026-02-26 15:10 ` [PATCH 04/25] xor: move to lib/raid/ Christoph Hellwig
2026-02-28 4:35 ` Eric Biggers
2026-03-03 16:01 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 05/25] xor: small cleanups Christoph Hellwig
2026-02-26 15:10 ` [PATCH 06/25] xor: cleanup registration and probing Christoph Hellwig
2026-02-28 4:41 ` Eric Biggers
2026-02-26 15:10 ` [PATCH 07/25] xor: split xor.h Christoph Hellwig
2026-02-28 4:43 ` Eric Biggers
2026-03-03 16:03 ` Christoph Hellwig
2026-03-03 16:15 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 08/25] xor: remove macro abuse for XOR implementation registrations Christoph Hellwig
2026-02-26 15:10 ` [PATCH 09/25] xor: move generic implementations out of asm-generic/xor.h Christoph Hellwig
2026-02-26 15:40 ` Arnd Bergmann
2026-02-28 7:15 ` Eric Biggers
2026-03-03 16:09 ` Christoph Hellwig [this message]
2026-03-10 14:00 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 10/25] alpha: move the XOR code to lib/raid/ Christoph Hellwig
2026-02-26 15:10 ` [PATCH 11/25] arm: " Christoph Hellwig
2026-02-26 15:10 ` [PATCH 12/25] arm64: " Christoph Hellwig
2026-02-26 15:10 ` [PATCH 13/25] loongarch: " Christoph Hellwig
2026-02-26 15:10 ` [PATCH 14/25] powerpc: " Christoph Hellwig
2026-02-26 15:10 ` [PATCH 15/25] riscv: " Christoph Hellwig
2026-02-28 5:37 ` Eric Biggers
2026-02-26 15:10 ` [PATCH 16/25] sparc: " Christoph Hellwig
2026-02-28 5:47 ` Eric Biggers
2026-03-03 16:04 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 17/25] s390: " Christoph Hellwig
2026-02-27 9:09 ` Heiko Carstens
2026-02-27 14:13 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 18/25] x86: " Christoph Hellwig
2026-02-27 14:30 ` Peter Zijlstra
2026-02-27 23:55 ` Eric Biggers
2026-02-28 10:31 ` Peter Zijlstra
2026-03-03 16:05 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 19/25] xor: avoid indirect calls for arm64-optimized ops Christoph Hellwig
2026-02-26 15:10 ` [PATCH 20/25] xor: make xor.ko self-contained in lib/raid/ Christoph Hellwig
2026-02-28 6:42 ` Eric Biggers
2026-03-03 16:06 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 21/25] xor: add a better public API Christoph Hellwig
2026-02-28 6:50 ` Eric Biggers
2026-03-03 16:07 ` Christoph Hellwig
2026-03-10 6:58 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 22/25] async_xor: use xor_gen Christoph Hellwig
2026-02-28 6:55 ` Eric Biggers
2026-02-26 15:10 ` [PATCH 23/25] btrfs: " Christoph Hellwig
2026-02-26 15:10 ` [PATCH 24/25] xor: pass the entire operation to the low-level ops Christoph Hellwig
2026-02-28 6:58 ` Eric Biggers
2026-03-03 16:09 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 25/25] xor: use static_call for xor_gen Christoph Hellwig
2026-02-27 14:36 ` Peter Zijlstra
2026-02-26 18:20 ` cleanup the RAID5 XOR library Andrew Morton
2026-02-28 7:35 ` Eric Biggers
2026-03-03 16:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303160911.GI7021@lst.de \
--to=hch@lst$(echo .)de \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alex@ghiti$(echo .)fr \
--cc=andreas@gaisler$(echo .)com \
--cc=anton.ivanov@cambridgegreys$(echo .)com \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=arnd@arndb$(echo .)de \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=chleroy@kernel$(echo .)org \
--cc=clm@fb$(echo .)com \
--cc=dan.j.williams@intel$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=dsterba@suse$(echo .)com \
--cc=ebiggers@kernel$(echo .)org \
--cc=gor@linux$(echo .)ibm.com \
--cc=hca@linux$(echo .)ibm.com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=hpa@zytor$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=kernel@xen0n$(echo .)name \
--cc=linan122@huawei$(echo .)com \
--cc=linmag7@gmail$(echo .)com \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-btrfs@vger$(echo .)kernel.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-raid@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-um@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=loongarch@lists$(echo .)linux.dev \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mattst88@gmail$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=pjw@kernel$(echo .)org \
--cc=richard.henderson@linaro$(echo .)org \
--cc=richard@nod$(echo .)at \
--cc=song@kernel$(echo .)org \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=svens@linux$(echo .)ibm.com \
--cc=tglx@kernel$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=yukuai@fnnas$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox