From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: Douglas Anderson <dianders@chromium•org>
Cc: "Rafael J . Wysocki" <rafael@kernel•org>,
Danilo Krummrich <dakr@kernel•org>,
Alan Stern <stern@rowland•harvard.edu>,
Saravana Kannan <saravanak@kernel•org>,
Christoph Hellwig <hch@lst•de>,
Eric Dumazet <edumazet@google•com>,
Johan Hovold <johan@kernel•org>,
Leon Romanovsky <leon@kernel•org>,
Alexander Lobakin <aleksander.lobakin@intel•com>,
Alexey Kardashevskiy <aik@ozlabs•ru>,
Robin Murphy <robin.murphy@arm•com>,
Andrew Morton <akpm@linux-foundation•org>,
Frank.Li@kernel•org, Jason Gunthorpe <jgg@ziepe•ca>,
alex@ghiti•fr, alexander.stein@ew•tq-group.com,
andre.przywara@arm•com, andrew@codeconstruct•com.au,
andrew@lunn•ch, andriy.shevchenko@linux•intel.com,
aou@eecs•berkeley.edu, ardb@kernel•org, bhelgaas@google•com,
brgl@kernel•org, broonie@kernel•org, catalin.marinas@arm•com,
chleroy@kernel•org, davem@davemloft•net, david@kernel•org,
devicetree@vger•kernel.org, dmaengine@vger•kernel.org,
driver-core@lists•linux.dev, gbatra@linux•ibm.com,
gregory.clement@bootlin•com, hkallweit1@gmail•com,
iommu@lists•linux.dev, jirislaby@kernel•org, joel@jms•id.au,
joro@8bytes•org, kees@kernel•org, kevin.brodsky@arm•com,
kuba@kernel•org, lenb@kernel•org, lgirdwood@gmail•com,
linux-acpi@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linux-aspeed@lists•ozlabs.org, linux-cxl@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-mips@vger•kernel.org,
linux-mm@kvack•org, linux-pci@vger•kernel.org,
linux-riscv@lists•infradead.org, linux-serial@vger•kernel.org,
linux-snps-arc@lists•infradead.org, linux-usb@vger•kernel.org,
linux@armlinux•org.uk, linuxppc-dev@lists•ozlabs.org,
m.szyprowski@samsung•com, maddy@linux•ibm.com, mani@kernel•org,
maz@kernel•org, miko.lenczewski@arm•com, mpe@ellerman•id.au,
netdev@vger•kernel.org, npiggin@gmail•com, osalvador@suse•de,
oupton@kernel•org, pabeni@redhat•com, palmer@dabbelt•com,
peter.ujfalusi@gmail•com, peterz@infradead•org, pjw@kernel•org,
robh@kernel•org, sebastian.hesselbarth@gmail•com,
tglx@kernel•org, tsbogend@alpha•franken.de, vgupta@kernel•org,
vkoul@kernel•org, will@kernel•org, willy@infradead•org,
yangyicong@hisilicon•com, yeoreum.yun@arm•com
Subject: Re: [PATCH v4 0/9] driver core: Fix some race conditions
Date: Sun, 5 Apr 2026 07:27:46 +0200 [thread overview]
Message-ID: <2026040539-sponge-publisher-2b42@gregkh> (raw)
In-Reply-To: <20260404000644.522677-1-dianders@chromium.org>
On Fri, Apr 03, 2026 at 05:04:54PM -0700, Douglas Anderson wrote:
> NOTE: one potentially "controversial" choice I made in some patches
> was to always reserve a flag ID even if a flag is only used under
> certain CONFIG_ settings. This is a change from how things were
> before. Keeping the numbering consistent and allowing easy
> compile-testing of both CONFIG settings seemed worth it, especially
> since it won't take up any extra space until we've added a lot more
> flags.
Nah, this is fine, I don't see any problems with this as the original
code kind of was doing the same thing with the "hole" in the structure
if those options were not enabled.
> I only marked the first patch as a "Fix" since it is the only one
> fixing observed problems. Other patches could be considered fixes too
> if folks want.
>
> I tested the first patch in the series backported to kernel 6.6 on the
> Pixel phone that was experiencing the race. I added extra printouts to
> make sure that the problem was hitting / addressed. The rest of the
> patches are tested with allmodconfig with arm32, arm64, ppc, and
> x86. I boot tested on an arm64 Chromebook running mainline.
I'm guessing your tests passed? :)
Anyway, this looks great, unless there are any objections, other than
the "needs to be undefined", which a follow-on patch can handle, I'll
queue them up next week for 7.1-rc1.
thanks,
greg k-h
next prev parent reply other threads:[~2026-04-05 5:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-04 0:04 [PATCH v4 0/9] driver core: Fix some race conditions Douglas Anderson
2026-04-04 0:04 ` [PATCH v4 5/9] driver core: Replace dev->dma_ops_bypass with dev_dma_ops_bypass() Douglas Anderson
2026-04-04 0:05 ` [PATCH v4 9/9] driver core: Replace dev->offline + ->offline_disabled with accessors Douglas Anderson
2026-04-04 17:11 ` [PATCH v4 0/9] driver core: Fix some race conditions Rafael J. Wysocki
2026-04-05 5:27 ` Greg Kroah-Hartman [this message]
2026-04-05 12:02 ` Danilo Krummrich
2026-04-05 22:43 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026040539-sponge-publisher-2b42@gregkh \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=Frank.Li@kernel$(echo .)org \
--cc=aik@ozlabs$(echo .)ru \
--cc=akpm@linux-foundation$(echo .)org \
--cc=aleksander.lobakin@intel$(echo .)com \
--cc=alex@ghiti$(echo .)fr \
--cc=alexander.stein@ew$(echo .)tq-group.com \
--cc=andre.przywara@arm$(echo .)com \
--cc=andrew@codeconstruct$(echo .)com.au \
--cc=andrew@lunn$(echo .)ch \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=ardb@kernel$(echo .)org \
--cc=bhelgaas@google$(echo .)com \
--cc=brgl@kernel$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chleroy@kernel$(echo .)org \
--cc=dakr@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=david@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dianders@chromium$(echo .)org \
--cc=dmaengine@vger$(echo .)kernel.org \
--cc=driver-core@lists$(echo .)linux.dev \
--cc=edumazet@google$(echo .)com \
--cc=gbatra@linux$(echo .)ibm.com \
--cc=gregory.clement@bootlin$(echo .)com \
--cc=hch@lst$(echo .)de \
--cc=hkallweit1@gmail$(echo .)com \
--cc=iommu@lists$(echo .)linux.dev \
--cc=jgg@ziepe$(echo .)ca \
--cc=jirislaby@kernel$(echo .)org \
--cc=joel@jms$(echo .)id.au \
--cc=johan@kernel$(echo .)org \
--cc=joro@8bytes$(echo .)org \
--cc=kees@kernel$(echo .)org \
--cc=kevin.brodsky@arm$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lenb@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-aspeed@lists$(echo .)ozlabs.org \
--cc=linux-cxl@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mani@kernel$(echo .)org \
--cc=maz@kernel$(echo .)org \
--cc=miko.lenczewski@arm$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=npiggin@gmail$(echo .)com \
--cc=osalvador@suse$(echo .)de \
--cc=oupton@kernel$(echo .)org \
--cc=pabeni@redhat$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=peter.ujfalusi@gmail$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=pjw@kernel$(echo .)org \
--cc=rafael@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=robin.murphy@arm$(echo .)com \
--cc=saravanak@kernel$(echo .)org \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=stern@rowland$(echo .)harvard.edu \
--cc=tglx@kernel$(echo .)org \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=vgupta@kernel$(echo .)org \
--cc=vkoul@kernel$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=willy@infradead$(echo .)org \
--cc=yangyicong@hisilicon$(echo .)com \
--cc=yeoreum.yun@arm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox